1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-18 20:13:21 +08:00
Commit Graph

631 Commits

Author SHA1 Message Date
Bartłomiej Dach
ed397c8fee
Add failing assertions 2024-12-27 09:04:41 +01:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
Closes https://github.com/ppy/osu/issues/31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00
Bartłomiej Dach
fdc41ace7e
Fix flaky editor beatmap creation test
As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53.

Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.
2024-12-13 17:35:41 +09:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files 2024-12-10 14:19:55 +09:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Salman Alshamrani
8e0f6fc12d Re-encode difficulties on resource change 2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8 Merge branch 'master' into editor-multiple-background-audio-files 2024-12-04 04:31:15 -05:00
Salman Alshamrani
06824c1658 Add failing test case 2024-12-04 04:20:09 -05:00
Salman Alshamrani
2a6fbb59ff Add failing test case 2024-12-04 02:32:00 -05:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...
2024-12-03 14:17:14 +01:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Salman Alshamrani
489d7a30ec Perform a single Save call rather than doing it in each difficulty 2024-11-28 18:37:13 -05:00
Salman Alshamrani
238a1ce284 Fix tests reliability and improve code
Shaved off lots of copypasta so the test actually shows what it's testing.
2024-11-27 15:27:21 -05:00
Salman Alshamrani
4b8094d0db Update test coverage 2024-11-27 05:58:06 -05:00
Bartłomiej Dach
c69d36dc96
Remove leftover [Solo] attribute 2024-11-26 12:40:49 +01:00
Dean Herbert
e0199386a3
Add failing test case showing changing selection in editor affects samples 2024-11-26 17:33:41 +09:00
Salman Alshamrani
dc210d59b5 Add test coverage for sync button 2024-11-24 00:45:11 -05:00
Salman Alshamrani
259ad8ae0f Add failing test cases 2024-11-23 23:52:14 -05:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge 2024-11-22 18:47:32 +09:00
Salman Alshamrani
6e9ff49e59
Merge branch 'master' into editor-slider-touch-support-2 2024-10-23 17:02:38 -04:00
Dean Herbert
2103b3e186
Merge pull request #28863 from OliBomby/additions
Add toggles and hotkeys for configuring sample addition bank
2024-10-23 15:52:55 +09:00
Salman Alshamrani
0fa1d22210 Add tests covering expected behaviour when going on/off compose area 2024-10-14 15:12:09 -04:00
Dean Herbert
5c826be652
Merge pull request #29860 from bdach/fix-nudging
Only allow seek to next/previous object via keybinding if there is no selection
2024-10-07 15:36:19 +09:00
Bartłomiej Dach
114e53f8b2
Add failing test 2024-10-04 10:00:37 +02:00
Bartłomiej Dach
1280d7ea15
Fix tests again 2024-10-03 15:05:15 +02:00
Bartłomiej Dach
8a650deab6
Fix tests 2024-10-03 13:11:02 +02:00
Bartłomiej Dach
b15608343b
Replace setup screen controls with new "form" controls 2024-10-03 11:49:03 +02:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
OliBomby
3769b0da5d Fix TestHotkeysUnifySliderSamplesAndNodeSamples 2024-10-01 11:02:46 +02:00
Bartłomiej Dach
a9818854f4
Merge pull request #30024 from peppy/edit-url-decode
Fix editor timestamp URLs not working when they contain a space
2024-10-01 09:44:18 +02:00
Dean Herbert
1b4215576d
Merge branch 'master' into additions 2024-10-01 16:38:56 +09:00
Dean Herbert
590f27e0a0
Merge branch 'master' into hotkeys-in-context-menus 2024-10-01 15:50:19 +09:00
Bartłomiej Dach
75fc57c34b
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration 2024-09-30 13:36:16 +02:00
Dean Herbert
a258059d43
Merge pull request #29918 from bdach/control-drag
Add to existing selection when dragging with control pressed
2024-09-30 14:00:36 +09:00
Dean Herbert
c46d787f1e
Merge pull request #29949 from minetoblend/feature/scale-around-center
Support scaling around center when scaling with select box
2024-09-28 21:37:39 +09:00
Dean Herbert
f6c5f975ee
Add failing test showing url decoding is not being performed 2024-09-27 20:08:26 +09:00
Bartłomiej Dach
eb725ec1fb
Nudge test coverage to also cover discovered fail case 2024-09-27 12:13:11 +02:00
Bartłomiej Dach
b45fedc356
Merge branch 'master' into control-drag 2024-09-27 11:39:50 +02:00
Marvin Schürz
15c4b1dc8f Move mouse horizontally in test to make sure it doesn't accidentally maintain aspect ratio 2024-09-24 13:45:03 +02:00
Marvin Schürz
3ad7342964 Add tests for shift and alt modifiers in select box 2024-09-24 13:35:56 +02:00
OliBomby
a9ebfbe431 Assert default origin not null in rotation handle 2024-09-23 11:37:42 +02:00
Dean Herbert
188a430418
Merge branch 'master' into grids-3 2024-09-19 18:21:05 +09:00
Bartłomiej Dach
2d3b027f85
Add test case covering desired behaviour 2024-09-18 15:18:13 +02:00
Dean Herbert
58fe502af4
Merge branch 'master' into beatmap-info-purge 2024-09-15 04:53:35 +09:00
Bartłomiej Dach
2ccb4a48eb
Add test coverage for seeking between objects in editor 2024-09-13 11:40:01 +02:00
Bartłomiej Dach
1292a34b9d
Add failing test coverage for object nudging 2024-09-13 11:39:56 +02:00
Bartłomiej Dach
0c4f5bcdaa
Decouple editor main menu items from DrawableOsuMenuItem
It didn't ever really make sense for it to be sharing the implementation
details of that (e.g. colouring of primary/dangerous actions), and with
the hotkey display things got outright hacky, so I'm decoupling it
entirely.
2024-09-04 12:16:52 +02:00
Bartłomiej Dach
4811481483
Merge pull request #29639 from peppy/detached-beatmap-cache
Improve song select load and reload with large beatmap databases
2024-08-30 15:00:20 +02:00