1186 Commits

• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Fetch more scores for supporter scope leaderboards

  Which are: global and team leaderboards with mods, and friends and
  country leaderboards.
  
  Only attempting this because of
  https://github.com/ppy/osu/issues/31056#issuecomment-2719787189. Not
  sure if this addresses the concern 🤷

  Bartłomiej Dach · 2025-05-12 09:54:56 +02:00
  934c2440cc
• Cache local user supporter status between game executions

  Fixes startup sounds from potentially being fetched from the wrong
  source if API connection establishment takes longer than the intro
  screen takes to load.
  
  Closes https://github.com/ppy/osu/issues/22492.

  Dean Herbert · 2025-05-07 14:02:09 +09:00
  84f44eb3ad
• Merge branch 'master' into feat/block-users
  Dean Herbert · 2025-04-23 13:55:18 +09:00
  c5748a0eae
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Update API beatmap model to include user play count
  Salman Alshamrani · 2025-04-11 02:24:38 +09:00
  6bb84e4364
• Update scores request to move away from old endpoint
  Bartłomiej Dach · 2025-04-10 09:46:46 +02:00
  17bcc28429
• Add support for ruleset-specific user tags

  Follow-up from https://github.com/ppy/osu-web/pull/12059

  Bartłomiej Dach · 2025-04-02 13:12:49 +02:00
  22f2c6f7b9
• Implement blocking users from context menu
  Zihad · 2025-03-27 22:37:37 +06:00
  afce72896f
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Rename APIUser.IsOnline and add better documentation around online checks
  Dean Herbert · 2025-03-19 15:01:40 +09:00
  b17ec5e69d
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Fix tag add request using wrong method
  Dean Herbert · 2025-03-17 12:20:37 +09:00
  f9078b98dd
• Switch add beatmap tag request to using path paramx

  See https://github.com/ppy/osu-web/pull/11999.

  Bartłomiej Dach · 2025-03-13 12:07:19 +01:00
  607c83abd6
• Fix namespace
  Dean Herbert · 2025-03-08 22:18:08 +09:00
  2272ca1ae5
• Update property name in line with web changes
  Bartłomiej Dach · 2025-03-05 08:05:15 +01:00
  3661107e4f
• Add UI for assigning custom tags to beatmaps

  Visual part for https://github.com/ppy/osu/issues/31913. Opening
  separately for appropriate visual UI adjustments.
  
  Also mostly ready to be hooked up to the results screen, pending merge
  of https://github.com/ppy/osu-web/pull/11951.

  Bartłomiej Dach · 2025-03-04 13:08:02 +01:00
  c051ff84d2
• Fix unable to join multiplayer rooms with many users
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  3024a98658
• update guest difficulty display to consistent with the web page
  cdwcgt · 2025-02-20 21:49:30 +08:00
  9d7b01bcd4
• Send "notify on discussion replies" setting value in beatmap creation request
  Bartłomiej Dach · 2025-02-19 12:45:37 +01:00
  687c9d6e17
• Add sleep to reduce spinning when waiting on two factor auth
  Dean Herbert · 2025-02-18 23:52:55 +09:00
  7566da8663
• Do not allow flushed requests to transition API into Failing state

  Flushes are assumed to have already come from a definitive state change
  (read: disconnection). Allowing the exceptions that come from failing
  the flushed requests to trigger the `Failing` code paths makes
  completely incorrect behaviour possible.

  Bartłomiej Dach · 2025-02-18 10:20:38 +01:00
  930e02300f
• Do not attempt to automatically reconnect if there is no login to use

  Because it'll fail anyway - there is either no username or no password.
  The reason why this is important is that the block was also setting API
  state to `Connecting`.

  Bartłomiej Dach · 2025-02-18 10:14:00 +01:00
  d6552f00be
• Add local guard before scheduled placeholder user set

  When API is in `RequiresSecondFactorAuth` state, `attemptConnect()` is
  called over and over in a loop, with no sleeping, which means that the
  scheduler accumulates hundreds of thousands of these delegates. Sure you
  could add a sleep in there maybe, but it seems pretty wasteful to have
  the `localUser.IsDefault` guard *inside* the schedule anyway, so this is
  what I opted for.

  Bartłomiej Dach · 2025-02-18 10:10:51 +01:00
  8299dfc6f2
• Add API models for teams
  Dean Herbert · 2025-02-14 17:39:20 +09:00
  88188e8fcb
• Adjust timeouts to be much higher for upload requests

  It seems that right now these timeouts do not check for actual data
  movement, which is to say if a user with a very slow connection is
  uploading and it takes more than `Timeout`, their upload will fail.
  
  For now let's set these values high enough that most users will not be
  affected.

  Dean Herbert · 2025-02-07 18:39:01 +09:00
  ce88ecfb3c
• Merge branch 'master' into bss/the-actual-submission
  Dean Herbert · 2025-02-07 17:44:48 +09:00
  6335228fb0
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Remove unnecessary suppressions
  Bartłomiej Dach · 2025-02-06 08:38:28 +01:00
  e1a146d487
• Suppress inspections for now
  Bartłomiej Dach · 2025-02-06 08:32:08 +01:00
  5e74d82fc1
• Add API request & response structures for beatmap submission
  Bartłomiej Dach · 2025-02-05 14:00:50 +01:00
  8940ee5d9c
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Move bindables to OsuConfigManager & SessionStatics
  Dan Balasescu · 2025-01-16 19:33:42 +09:00
  8400726887
• Allow setting of DummyAPIAccess status
  Dan Balasescu · 2025-01-16 17:06:54 +09:00
  c1f0c47586
• Expose as IBindable from IAPIProvider, writes via config
  Dan Balasescu · 2025-01-16 17:05:18 +09:00
  b54d959263
• Make config the definitive status value
  Dan Balasescu · 2025-01-15 00:01:19 +09:00
  b7a9b77efe
• Remove Status and Activity bindables from APIUser

  As for the tests, I'm (ab)using the `IsOnline` state for the time being
  to restore functionality.

  Dan Balasescu · 2025-01-14 23:45:30 +09:00
  20108e3b74
• Revert name change
  Dean Herbert · 2025-01-14 20:41:18 +09:00
  91fa2e70d8
• Merge branch 'master' into api-startup-state
  Dean Herbert · 2025-01-14 20:39:05 +09:00
  3523a2fe61
• Merge pull request #31507 from peppy/api-startup-user

  Ensure API starts up with `LocalUser` in correct state

  Dan Balasescu · 2025-01-14 20:36:55 +09:00
  f2b7984e5a
• Merge pull request #31444 from smoogipoo/friend-presence-2

  Add notifications for when friends go online or offline

  Dean Herbert · 2025-01-14 18:58:19 +09:00
  b4d054fdc0
• Ensure API state is Connecting immediately on startup when credentials are present

  Currently, there's a period where the API is `Offline` even though it is
  about to connect (as soon as the `run` thread starts up).
  
  This can cause any `Queue`d requests to fail if they arrive too early.
  
  To avoid this, let's ensure the `Connecting` state is set as early as
  possible.

  Dean Herbert · 2025-01-14 18:18:53 +09:00
  55ae0403d8
• Remove unused using
  Dan Balasescu · 2025-01-14 17:54:40 +09:00
  156207d347
• Simplify operations on local list
  Dan Balasescu · 2025-01-14 17:52:26 +09:00
  51c7c218bf
• Ensure API starts up with LocalUser in correct state

  I noticed in passing that in a very edge case scenario where the API's
  `run` thread doesn't run before it is loaded into the game, something
  could access it and get a guest `LocalUser` when the local user actually
  has a valid login.
  
  Put another way, the `protected HasLogin` could be `true` while
  `LocalUser` is `Guest`.
  
  I think we want to avoid this, so I've moved the initial set of the
  local user earlier in the initialisation process.
  
  If this is controversial in any way, the PR can be closed and we can
  assume no one is ever going to run into this scenario (or that it
  doesn't matter enough even if they did).

  Dean Herbert · 2025-01-14 17:43:43 +09:00
  f6073d4ac0
• Add separate path for friend presence notifications

  It proved to be too difficult to deal with the flow that clears user
  states on stopping the watching of global presence updates. It's not
  helped in the least that friends are updated via the API, so there's a
  third flow to consider (and the timings therein - both server-spectator
  and friends are updated concurrently).
  
  Simplest is to separate the friends flow, though this does mean some
  logic and state duplication.

  Dan Balasescu · 2025-01-09 17:31:01 +09:00
  7268b2e077
• Appease message pack new inspections
  Dean Herbert · 2025-01-08 03:13:29 +09:00
  d5f2bdf6cd
• Display notification on friend presence changes
  Dan Balasescu · 2025-01-07 19:12:33 +09:00
  51b62a6d8e
• Merge branch 'master' into close-playlists
  Bartłomiej Dach · 2024-11-28 14:01:36 +01:00
  2e6f43a75d