62522 Commits

This Branch

This Branch

All Branches

• Remove unused translations
  Dean Herbert · 2023-09-19 17:53:00 +09:00
  cdb5fea513
• Pass ArchiveReader instead of Stream to simplify resolution code
  Dean Herbert · 2023-09-19 17:49:15 +09:00
  f726c38215
• Fix log output using incorrect name
  Dean Herbert · 2023-09-19 17:34:24 +09:00
  0593c76c57
• Adjust sizing slightly to remove need for CollapsibleButtonContainerSlim
  Dean Herbert · 2023-09-19 17:20:58 +09:00
  7f30354e61
• Add comment mentioning why hover is disabled on the notification type
  Dean Herbert · 2023-09-19 16:35:22 +09:00
  0555d22eb8
• Tweak nano beatmap card UX further to meet expectations
  Bartłomiej Dach · 2023-09-19 08:36:32 +02:00
  8e199de78a
• Merge branch 'master' into missing-beatmap
  Dean Herbert · 2023-09-19 04:01:56 +09:00
  72457147a7
• Merge pull request #24846 from bdach/get-reader-regression

  Fix `MemoryStreamArchiveReader.GetStream()` failing in some cases

  Dean Herbert · 2023-09-18 22:06:33 +09:00
  163b6df357
• Auto-close notification after successful download
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  25e43bd7d7
• Use different copy when auto-downloading
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  4cdd19bb5a
• Rename spectator-specific settings to more generic (with backwards migration)
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  3bddf4bf9a
• Make missing beatmap notification simple

  Progress didn't work for several reasons:
  
  - It was spinning when nothing was actually happening yet
    (especially egregious with autodownload off)
  
  - It was blocking exits (as all progress notifications do)
  
  - When actually going to download, two progress notifications would
    pertain to one thing
  
  - It wasn't helping much with the actual implementation of score
    re-import, cancelling the progress notification would result in
    similarly jank UX of beatmap importing but not the score.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  27471ad170
• Reword and localise copy
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  b2c98da330
• Integrate nano beatmap card into the notification
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  2709c6cd67
• Add very basic visual tests for missing beatmap notification

  The full-stack test using the whole 9 `OsuGameTest` yards is unusable
  for rapid development. I don't really get how you could ever design
  anything using it without tossing your computer out the window.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  775f96f061
• Fix OsuTestScene.CreateAPIBeatmapSet() not backlinking set beatmaps to the set
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  47764b3012
• Redo nano beatmap card design to fit needs better

  Wanting to use this inside notification, it turns out that the original
  design did not work very well at such narrow widths, and additionally
  the typical button setup borrowed from elsewhere resulted in teeny tiny
  action buttons.
  
  To that end, slim down the design (get rid of thumbnail, audio preview,
  make expandable right side slimmer), as well as change the entire panel
  so that it has only one action associated with it at all times, and
  clicking the panel in any place triggers that action.

  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  5fcd736332
• Merge branch 'get-reader-regression' into missing-beatmap
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  67b5dfb9cf
• Merge branch 'beatmap-card-nano' into missing-beatmap
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  06d1a2a316
• Merge pull request #24822 from bdach/scoring-test-scene-taiko

  Add scoring test scene for taiko

  Dean Herbert · 2023-09-18 21:04:40 +09:00
  18c18fef22
• Merge branch 'master' into scoring-test-scene-taiko
  Dean Herbert · 2023-09-18 19:55:05 +09:00
  41f2644713
• Merge pull request #24821 from bdach/scoring-test-scene-osu

  Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)

  Dean Herbert · 2023-09-18 19:54:14 +09:00
  f3b6aa5435
• Merge pull request #24845 from bdach/beatmap-card-nano

  Implement nano beatmap card

  Dean Herbert · 2023-09-18 19:08:27 +09:00
  4a00795fc5
• Fix MemoryStreamArchiveReader.GetStream() failing in some cases

  `MemoryStreamArchiveReader` introduced in
  0657b55196 would previously use
  `MemoryStream.GetBuffer()` to retrieve the underlying byte buffer with
  stream data. However, this is not generally the method you would want,
  for two reasons:
  
  1. It can fail if the stream wasn't created in the way that supports it.
  2. As per
  
  	https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.getbuffer?view=net-7.0#system-io-memorystream-getbuffer,
  
     it will return the _raw_ contents of the buffer, including
     potentially unused bytes.
  
  To fix, use `MemoryStream.ToArray()` instead, which avoids both
  pitfalls. Notably, `ToArray()` always returns the full contents of the
  buffer, regardless of `Position`, as documented in:
  
      https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.toarray?view=net-7.0#system-io-memorystream-toarray

  Bartłomiej Dach · 2023-09-18 11:50:36 +02:00
  e57d7d1205
• Implement nano beatmap card
  Bartłomiej Dach · 2023-09-18 11:30:14 +02:00
  5c2413c06b
• Fix grammar in comment
  Bartłomiej Dach · 2023-09-18 10:46:14 +02:00
  59b9a636d3
• Merge pull request #24739 from peppy/fix-slider-tick-misssing

  Fix sliders not always being the correct length

  Bartłomiej Dach · 2023-09-18 10:21:50 +02:00
  0985bb0577
• Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris

  Parse only supported schemes as URIs

  Bartłomiej Dach · 2023-09-18 10:20:09 +02:00
  3709861132
• Fix link protocol allowlist allowing too much
  Bartłomiej Dach · 2023-09-18 09:20:24 +02:00
  d3cc6dbaa0
• Add failing test case for fake (but still incorrectly allowed) protocol
  Bartłomiej Dach · 2023-09-18 09:19:12 +02:00
  a2df123c6d
• Merge pull request #24828 from Joehuu/fix-dummy-ar5

  Fix dummy beatmap showing AR 5 on song select

  Dean Herbert · 2023-09-16 15:01:47 +09:00
  5eebc879d1
• Fix dummy beatmap showing AR 5 on song select
  Joseph Madamba · 2023-09-15 20:26:17 -07:00
  c2685da94c
• Add taiko scoring test scene
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  c6445a327b
• Add example scenarios and configurable score multiplier
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  ebdc501e5b
• Refactor further to allow extensibility to other rulesets
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  0c22ff2a80
• Minimum viable changes for ruleset-specific scoring test scenes
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  45751dd1f2
• Adjust slider calculations to new method API

  Code originally read
  
  	Velocity = scoringDistance / beatLength
  		 = BASE_SCORING_DISTANCE * SliderMultiplier * GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  
  Given (mathematically, floats are not generally as forgiving):
  
  	GetPrecisionAdjustedBeatLength() = beatLength / GetPrecisionAdjustedSliderVelocityMultiplier()
  
  it follows that (inverting both sides):
  
  	1 / GetPrecisionAdjustedBeatLength() = GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  
  and therefore
  
  	Velocity = BASE_SCORING_DISTANCE * SliderMultiplier * GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  		 = BASE_SCORING_DISTANCE * SliderMultiplier / GetPrecisionAdjustedBeatLength()
  
  and to recover `scoringDistance`
  
  	scoringDistance = Velocity * beatLength

  Bartłomiej Dach · 2023-09-15 12:30:25 +02:00
  5c6cd879dd
• Merge branch 'master' into fix-slider-tick-misssing
  Bartłomiej Dach · 2023-09-15 12:09:54 +02:00
  4275af1343
• Manually reorder objects in expected mapping

  The test added in 64baa4d01a was
  previously failing despite applying a fix. This was caused by the fact
  that in stable, the last `sliderScoreTimingPoint` (i.e. the
  `LegacyLastTick` is pulled back by 36ms, but the list of all of them
  is not re-sorted afterwards, causing objects to be exported in
  non-chronological order to the resultant conversion mapping.
  lazer correctly sorts the objects, causing a false positive.

  Bartłomiej Dach · 2023-09-15 12:07:59 +02:00
  86c46a5b3f
• Merge pull request #24738 from peppy/no-legacy-difficulty-control-point

  Remove `LegacyDifficultyControlPoint` / `LegacyBpmMultiplier`

  Bartłomiej Dach · 2023-09-15 12:01:56 +02:00
  1ae8665a08
• Merge branch 'master' into no-legacy-difficulty-control-point
  Bartłomiej Dach · 2023-09-15 11:14:28 +02:00
  a6fab28461
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Merge pull request #24807 from peppy/import-task-improve

  Clean up `ImportTask` / `ArchiveReader` implementations

  Bartłomiej Dach · 2023-09-14 20:24:32 +02:00
  b2b18092cf
• Merge branch 'master' into import-task-improve
  Bartłomiej Dach · 2023-09-14 19:37:01 +02:00
  9b391cd661
• Bring back disposal of stream after copy-out to MemoryStream

  Was there in previous code and got removed in the refactor. I'd rather
  have it than not.

  Bartłomiej Dach · 2023-09-14 19:36:35 +02:00
  c8b18acd4d
• Merge pull request #24802 from peppy/mod-select-difficulty-multiplier-animation

  Rename "difficulty multiplier" to "score multiplier" and add more animation hinting

  Bartłomiej Dach · 2023-09-14 19:21:20 +02:00
  f7156599a6
• somehow accidentally removed backslashes
  Lukynka CZE · 2023-09-14 17:55:53 +02:00
  9b8fdcbcdc
• add visual test
  Lukynka CZE · 2023-09-14 17:48:10 +02:00
  2a18f76b02
• add unit test
  Lukynka CZE · 2023-09-14 17:46:42 +02:00
  25926af782