53111 Commits

This Branch

This Branch

All Branches

• Add test coverage for batch-import path
  Salman Ahmed · 2022-07-07 18:06:35 +03:00
  cd4755fbd9
• Fix skins potentially being duplicated on batch import

  Resolves https://github.com/ppy/osu/discussions/19024#discussioncomment-3099200

  Dean Herbert · 2022-07-07 22:39:07 +09:00
  cf1da1dd18
• Merge pull request #19026 from peppy/async-track-operations

  Use fire-and-forget async operations on global track

  Dan Balasescu · 2022-07-07 19:45:03 +09:00
  7086779cf4
• Merge pull request #19028 from peppy/add-skin-keyword

  Allow searching for "skins" to find current skin setting

  Dan Balasescu · 2022-07-07 19:40:23 +09:00
  5e3c6d6e56
• Merge pull request #19027 from peppy/realm-nested-writes

  Add nested transaction handling to realm helper methods

  Dan Balasescu · 2022-07-07 19:40:08 +09:00
  c8b05a5ef2
• Allow searching for "skins" to find current skin setting
  Dean Herbert · 2022-07-07 18:26:04 +09:00
  d88fd8a5b0
• Add test coverage of nested rollback for good measure
  Dean Herbert · 2022-07-07 18:19:01 +09:00
  bf10f2db2e
• Fix transaction not being disposed
  Dean Herbert · 2022-07-07 18:15:38 +09:00
  ac216d94a8
• Update various tests to enable NRT to avoid new inspection failures
  Dean Herbert · 2022-07-07 17:51:49 +09:00
  dd5b127fb5
• Add automatic transaction handling to realm helper methods
  Dean Herbert · 2022-07-07 17:36:25 +09:00
  5197d0fa9e
• Merge pull request #19022 from peppy/better-file-loading-exceptions

  Add local handling of cases where a beatmap's file cannot be found on disk

  Dan Balasescu · 2022-07-07 17:21:19 +09:00
  d4c539687e
• Use fire-and-forget async operations on global track

  This avoids any blocking overhead caused by a backlogged audio thread.
  Test seem to pass so might be okay?
  
  Note that order is still guaranteed due to the `ensureUpdateThread`
  queueing system framework-side.

  Dean Herbert · 2022-07-07 17:15:45 +09:00
  7ef03dd2cb
• Update framework
  Dean Herbert · 2022-07-07 17:13:16 +09:00
  45c5b7e7dd
• Merge pull request #19007 from goodtrailer/fix-rewind-spinner-accent

  Fix default spinner's accent on rewind in user replays

  Dean Herbert · 2022-07-07 17:13:08 +09:00
  2eba38ca88
• Merge pull request #19023 from peppy/fix-convert-custom-rulesets

  Fix song select placeholder not showing convert hint for custom rulesets

  Dan Balasescu · 2022-07-07 16:19:20 +09:00
  65829d8feb
• Fix song select placeholder not showing convert hint for custom rulesets
  Dean Herbert · 2022-07-07 14:46:51 +09:00
  e1b434b5dc
• Change storyboard parsing logic to not completely fail if only .osb read fails

  Changes to allow the storyboard to exist if only the `.osu` is
  available. Reads better IMO.

  Dean Herbert · 2022-07-07 14:33:20 +09:00
  e81cebf27d
• Add local handling of cases where a beatmap's file cannot be found on disk
  Dean Herbert · 2022-07-07 14:29:19 +09:00
  c4b6893709
• Merge pull request #19021 from frenzibyte/fix-flaky-tests-envvar

  Fix flaky tests not running at all with environment variable set

  Dean Herbert · 2022-07-07 10:56:38 +09:00
  e5dd7b1654
• Fix flaky tests not running at all with environment variable set
  Salman Ahmed · 2022-07-07 04:24:10 +03:00
  9115072917
• Merge pull request #19020 from frenzibyte/mgcc-descriptive-asserts

  Improve asserts in `TestSeekPerformsInGameplayTime` to be more descriptive

  Dan Balasescu · 2022-07-07 08:51:24 +09:00
  1ff3b19360
• Improve asserts in TestSeekPerformsInGameplayTime to be more descriptive
  Salman Ahmed · 2022-07-07 01:00:55 +03:00
  a5b01b8920
• Rename method and make duration optional
  Salman Ahmed · 2022-07-06 23:38:11 +03:00
  7f94405c9e
• Merge pull request #19014 from peppy/line-buffered-reader-simplification

  Enable NRT and simplify `LineBufferedReader`

  Dan Balasescu · 2022-07-06 20:27:04 +09:00
  b9acdcdbe2
• Avoid usage of finally in potentially hot path
  Dean Herbert · 2022-07-06 19:55:51 +09:00
  c2f1069073
• Revert old behaviour of ReadToEnd
  Dean Herbert · 2022-07-06 19:55:51 +09:00
  01bc6e5cb7
• Merge pull request #19013 from peppy/fix-param-naming

  Fix incorrect case in `CatcherArea` parameter

  Dan Balasescu · 2022-07-06 19:46:52 +09:00
  8f63592d6b
• Merge pull request #19018 from peppy/memory-caching-component-statistics

  Add statistics display for `MemoryCachingComponent`s

  Dan Balasescu · 2022-07-06 19:20:36 +09:00
  6340caf27d
• Merge pull request #19015 from peppy/improve-beatmap-parsing-performance

  Fix `BeatSyncedContainer` unintentionally blocking on beatmap load

  Dan Balasescu · 2022-07-06 18:41:07 +09:00
  9f76118ee0
• Add statistics display for MemoryCachingComponents

  Never sure if these are working as they should (or how well they are
  working). This helps quite a bit.

  Dean Herbert · 2022-07-06 18:38:40 +09:00
  a1b6ec60c8
• Use -1 to specify default buffer size
  Dean Herbert · 2022-07-06 15:43:35 +09:00
  12d396a513
• Fix BeatSyncedContainer unintentionally blocking on beatmap load
  Dean Herbert · 2022-07-06 14:58:06 +09:00
  ae49aafde2
• Enable NRT and simplify LineBufferedReader
  Dean Herbert · 2022-07-06 14:57:56 +09:00
  a52ea3cabe
• Merge pull request #18993 from Joehuu/fix-personal-best-delete-context-menu

  Fix personal best score showing delete option on context menu

  Dean Herbert · 2022-07-06 14:53:35 +09:00
  7053a8507b
• Fix incorrect case in CatcherArea parameter
  Dean Herbert · 2022-07-06 14:28:50 +09:00
  c95eb2d2c1
• Merge pull request #19010 from peppy/forgotten-password-link

  Add forgotten password link to login form

  Dan Balasescu · 2022-07-06 13:55:18 +09:00
  73a5f9e911
• Apply NRT to LoginForm and remove nullability of IAPIProvider
  Dean Herbert · 2022-07-06 01:29:00 +09:00
  6fb00d84f9
• Add forgotten password link to login form
  Dean Herbert · 2022-07-06 01:25:04 +09:00
  3a68f386a8
• Merge pull request #19005 from Susko3/initial-cookie

  Allow MIDI and joysticks to trigger the osu! cookie on the initial screen

  Dean Herbert · 2022-07-05 19:26:56 +09:00
  85e589f863
• Split into a function
  Susko3 · 2022-07-05 11:15:37 +02:00
  4c3789ec5d
• Merge pull request #19006 from peppy/realm-locking-test-safety

  Fix intermittent realm migration test failures

  Dan Balasescu · 2022-07-05 16:23:43 +09:00
  9c1fda6048
• Add note regarding why the realmRetrievalLock return is done on the async thread
  Dean Herbert · 2022-07-05 16:23:10 +09:00
  33db508301
• Fix spinner accent animation on rewind
  goodtrailer · 2022-07-04 22:58:41 -07:00
  1e6def8209
• Ensure blocking restoration only completes after update callback work is completed
  Dean Herbert · 2022-07-05 14:39:14 +09:00
  5adec2c738
• Rename realm ThreadLocal to better convey what it's doing

  Every time I looked at this code I have to re-learn what it's doing.
  Changing these variable names should help quite a bit.

  Dean Herbert · 2022-07-05 13:38:25 +09:00
  1b98936328
• Trigger the initial cookie with midi and joysticks
  Susko3 · 2022-07-05 00:38:18 +02:00
  bb0f212448
• Fix delete local score test having no files
  Joseph Madamba · 2022-07-04 11:04:20 -07:00
  f1b55d743c
• Merge pull request #18997 from peppy/fix-realm-backup-ctor-fail

  Fix realm backup creation failing when run from `RealmAccess` constructor

  Dan Balasescu · 2022-07-04 18:41:57 +09:00
  b49a1aab8a
• Fix realm backup creation failing when run from RealmAccess constructor

  At the point of construction, we are not on the update thread, but it
  doesn't really matter at this point because there's no other usages.

  Dean Herbert · 2022-07-04 16:45:23 +09:00
  506409a9c4
• Add test coverage of corrupt realm creating backup
  Dean Herbert · 2022-07-04 16:45:23 +09:00
  64edc6888d