1646 Commits

• Add already existing localisation support from CommonStrings (#37401)

  decided to do this mostly because of the non-localised `BackButton` that
  was bothering my eyes
  
  changes can be reviewed commit by commit

  Denis Titovets · 2026-05-07 00:07:28 +09:00
  b8729cb7fd
• Add ability to search for users (#37225)

  This was a private request for roundtable event usage. It’s also a
  common feature request, so I decided to spend a bit of time getting this
  working well-enough.
  
  
  https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5
  
  
  ---
  
  ### Delay loading spinner / loading layer initial load briefly to avoid
  flickering
  
  There's cases in this overlay where loading takes a few milliseconds.
  The loading spinner gets annoying. This also happens elsewhere, so this
  could be considered a global fix. Separate PR? probably...
  
  ### Ingest loading state of dashboard child content to show more correct
  loading layer
  
  Each display had their own loading layer implementation, but this is
  already too deep (inside the scroll content) and doesn't display great
  when for instance, results don't take up the full screen height.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-07 14:14:49 +02:00
  c570db6c40
• Fix song select dropdowns not being navigable with keyboard (#37158)

  - Closes https://github.com/ppy/osu/issues/31684
  
  Uses the global action variant of up and down for dropdown menus. It is
  already used in multiplayer/playlist room/beatmap navigation and
  gameplay menu overlays.
  
  Comment wording is derived from:
  
  https://github.com/ppy/osu/blob/fc817627e56b7db1c46e2f00fc9a3bd14af51211/osu.Game/Graphics/UserInterface/FocusedTextBox.cs#L73-L74

  Joseph Madamba · 2026-04-01 20:59:47 +09:00
  556be552c3
• Switch online play screens to new header (#37074)

  Specifically the one used on the daily challenge screen. Was bugging me
  that playlists/multi have that old yellow header design used, so I've
  changed it. Will probably come in handy once the footer/leaderboard
  changes are in.
  
  Also localized the headers while at it.
  
  Multiplayer:
  
  
  ![osu_2026-03-23_20-03-22](https://github.com/user-attachments/assets/1f262aea-8bf9-412d-9c4a-89addd65bf38)
  
  Playlists:
  
  
  ![osu_2026-03-23_20-34-18](https://github.com/user-attachments/assets/3f7d349e-7c03-4f56-8e57-1c65ae746235)
  
  The only thing I'm wondering about is whether the detail thing
  (participant count/playlist length) should be using the highlight colour
  here. The old design had them be yellow, but I feel like the pink on
  this one stands out too much.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-25 16:36:18 +09:00
  86ef145f56
• Keep any stateful dropdown menu open on click (#37021)

  Right click is a very obfuscated UX which most users won't find. This
  makes more sense to the average user (probably).
  
  Caveat: clicking away actually sends clicks to underlying UI. This is
  not the case in macOS or windows (locally, same app; globally it still
  sends clicks to other windows).
  
  Coming from https://github.com/ppy/osu/discussions/36926.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-21 22:18:02 +09:00
  1016bca280
• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Fix missed using statement
  Dean Herbert · 2026-03-09 08:22:16 +09:00
  7227afebbb
• Update a few sample playback usages to use new helper method
  Dean Herbert · 2026-03-07 23:39:20 +09:00
  e3a0464e90
• Fix LoadingLayer centering

  oops.

  Dean Herbert · 2026-03-07 02:51:50 +09:00
  de9cf751d2
• Fix loading spinner not being centered correctly (#36849)

  One of those things you can't un-see.
  
  Closes https://github.com/ppy/osu/issues/36832.

  Dean Herbert · 2026-03-06 12:11:16 +01:00
  b46656e7d3
• Refactor ShearedButton to allow easier relative sizing (#36802)

  This commit rearranges the contents of `ShearedButtons` to be more
  independent of each other in regards to sizing. Thanks to that, the
  custom logic related to enabling autosizing is no longer necessary.
  Witdh and height are no longer set via the constructor, and can be
  freely configured using the initializer syntax.
  
  Additionally, this allows the button to use relative sizing without
  having to resort to any hackery with `Size` (this will come in handy for
  me when implementing the new footer on multiplayer screens).
  
  Given that most of the `ShearedButton`s currently in use set their width
  explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
  default previously. Instead it is set on the only two such buttons (show
  converts/selected mods on ssv2). I suppose it might be a good idea to
  have it set that by default if no `Width` is specified, as right now
  it'll just not show anything.
  
  Also I've set the margin on the text field by default in all cases
  instead of only when autosizing like how it was previously, since
  otherwise it would be a pain to set that on each button instance when
  needed. I've checked all affected components and could not find any text
  overflowing issues that this could cause.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00
  b76a7e1bb6
• Remove all song select v1 files

  This contains no code changes (that would need review), only file
  deletion and extraction where required in a few odd cases.

  Dean Herbert · 2026-03-03 16:45:14 +09:00
  1a8d2855d4
• Add ability for LoadingLayer to block all keyboard input
  Dean Herbert · 2026-02-18 20:01:38 +09:00
  83587e2265
• Fix some text boxes no longer having borders (#36526)

  Regressed in d6bf4fd90d.
  
  One very visible instance of this regression is the login form.
  
  
  https://github.com/user-attachments/assets/5ba10ac5-4cb1-49af-b55c-89cf58ca0b44
  
  The `CommentEditor` usage was discovered with one of my favourite tricks
  which is doing
  
  ```diff
  diff --git a/osu.Game/Graphics/UserInterface/OsuTextBox.cs b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  index fefe776b01..c17cca726b 100644
  --- a/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  +++ b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  @@ -42,6 +42,12 @@ public partial class OsuTextBox : BasicTextBox
               Margin = new MarginPadding { Left = 2 },
           };
   
  +        public new bool Masking
  +        {
  +            get => base.Masking;
  +            set => base.Masking = value;
  +        }
  +
           protected bool DrawBorder { get; init; } = true;
   
           private OsuCaret? caret;
  
  ```
  
  and then looking for usages of the setter. That's all due diligence
  you're getting here, I'm not auditing every single text box in the game.
  
  And yes, the `CommentEditor` usage is OMEGA dodgy but the change applied
  here is the only one that preserves its visual appearance. I'm not
  putting in time to fix it.

  Bartłomiej Dach · 2026-01-29 19:11:10 +09:00
  7d476b4b7c
• Fix dropdown margins and animations being weird

  This was attempted to be fixed by frenzibyte using some hack workaround
  logic, but this is the true fix.
  
  Things were never matching due to `UpdateSize` spamming `Resize`
  transforms every frame, causing the fade out to complete before
  transforms have reached a final state.

  Dean Herbert · 2026-01-28 14:22:41 +09:00
  6bdb0e1cbb
• Fix border showing for inner text boxes incorrectly

  I turned masking back on on these for better visuals (text masking
  aligns with rest of elements) but turns out this implicitly makes
  borders draw.

  Dean Herbert · 2026-01-27 18:36:37 +09:00
  d6bf4fd90d
• Standardise hover sounds for form elements

  Closes #36444.

  Dean Herbert · 2026-01-27 17:06:14 +09:00
  dba17b1fa6
• Remove unnecessary and incorrect colour application
  Dean Herbert · 2026-01-09 16:27:33 +09:00
  a2d2c3287b
• Fix now playing overlay buttons not showing toggle colour correctly

  Closes https://github.com/ppy/osu/issues/36280.

  Dean Herbert · 2026-01-09 15:18:29 +09:00
  3f577aae60
• feat: added whitespaces between "fps"/"ms" and it's value in FPSCounterTooltip.cs
  Jonas Schips · 2026-01-06 13:37:10 +01:00
  86a3c19547
• feat: added whitespace between "fps"/"ms" and it's value to prevent clipping
  Jonas Schips · 2026-01-06 13:10:34 +01:00
  53a5157a2f
• Fix incorrect OsuAnimatedButton's DimColour

  for child classes without override

  Denis Titovets · 2026-01-01 20:48:38 +03:00
  2fc621b4f3
• Remove dim effect from disabled spread displays on song select panels
  Bartłomiej Dach · 2025-12-31 10:05:59 +01:00
  a6545bea68
• Add minimal spread display control for beatmap set panels
  Bartłomiej Dach · 2025-12-30 12:39:18 +01:00
  e2a245b049
• Make setter protected to fix build error
  Salman Alshamrani · 2025-12-23 06:31:26 -05:00
  95cf050298
• Expose constant for max decimal digits display
  Salman Alshamrani · 2025-12-23 06:14:48 -05:00
  fa32be37d6
• Revert unintended change
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  a1d4d44151
• Make sound playback consistent across all disabled controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  cb32d2da3e
• Add label and tooltip formatting to form sliders
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  4ee7e6f787
• Merge pull request #35757 from peppy/settings-wank

  Adjust settings buttons and general section to feel better

  Bartłomiej Dach · 2025-11-25 08:46:00 +01:00
  9e3486d4e6
• Adjust some more visual metrics to feel better
  Dean Herbert · 2025-11-25 01:05:31 +09:00
  64668eafb9
• Reduce abstractions of rounded button
  Dean Herbert · 2025-11-25 00:55:42 +09:00
  b0762fc8ec
• Merge pull request #35751 from bdach/seek-differently

  Debounce continuous track seeks to at most one every 200ms

  Dean Herbert · 2025-11-21 17:59:57 +09:00
  2c40e116e1
• Debounce continuous track seeks to at most one every 500ms

  See https://github.com/ppy/osu/pull/35677#issuecomment-3555903209.

  Bartłomiej Dach · 2025-11-20 12:23:31 +01:00
  6052ed790d
• Use new sliders-with-text-input in editor toolboxes

  Addresses https://github.com/ppy/osu/discussions/35732.
  
  And yes, I renamed "perfect curve threshold" to "bias" so that the text
  can fit. Sue me.

  Bartłomiej Dach · 2025-11-19 13:22:20 +01:00
  4b59a4657f
• Delay seeking the current track when dragging now playing overlay progress bar until commit (#35677)

  RFC. Written to address
  https://osu.ppy.sh/community/forums/topics/2150023.
  
  Few other things we might want to happen here:
  
  - pause the track when starting the drag
  - figure out what to do when a drag is held while the track changes in
    the background (which was impossible to happen before this)
  
  but I want to see the reaction to this first.

  Bartłomiej Dach · 2025-11-11 14:18:40 +09:00
  4c72a60ee2
• Fix pressing Enter on song select with IME active advancing to gameplay instead of confirming choice (#35619)

  Closes https://github.com/ppy/osu/issues/35568.

  Bartłomiej Dach · 2025-11-06 16:06:52 +09:00
  dbefba57ce
• Add sounds
  Dan Balasescu · 2025-09-24 19:47:13 +09:00
  3c37fb11be
• Make ShearedButton block mouse down events

  Closes https://github.com/ppy/osu/issues/33748.
  
  I (and tests) can't find any regressions from this. One would hope we
  aren't relying on fall-through mouse down anywhere beneath buttons..

  Dean Herbert · 2025-07-01 19:30:47 +09:00
  ed189fecf4
• Fix dropdown search bar not having placeholder text
  Salman Alshamrani · 2025-06-24 09:10:13 +03:00
  3599269cba
• Fix incorect masking when displayed at small sizes
  Dean Herbert · 2025-06-16 19:50:12 +09:00
  42e7a69db6
• Fix failing test
  Dean Herbert · 2025-06-16 19:39:37 +09:00
  13df477fc0
• Visual pass on loading spinner

  Fixes regression mentioned
  [here](https://github.com/ppy/osu/pull/33509#issuecomment-2951271131).
  
  Adjust visuals and metrics slightly.

  Dean Herbert · 2025-06-16 15:47:57 +09:00
  c888431201
• Add localisation support to difficulty range slider
  Salman Alshamrani · 2025-06-14 15:05:05 +03:00
  977c26d02f
• Adjust loading spinner to not use masking as all when no box
  Dean Herbert · 2025-06-07 02:19:15 +09:00
  c25396c7d6
• Fix loading spinner without a box clipping
  Joseph Madamba · 2025-06-06 08:47:32 -07:00
  15be762f71
• SongSelectV2: Fix some missing/incorrect SFX
  Jamie Taylor · 2025-05-30 21:31:26 +09:00
  cf6e9f8ad8
• Add icon specification to OsuMenuItem

  This isn't used visually for context menus, but is handy to have when
  using this class to convey more general information about actions,
  including usages outside of context menus where an icon is relevant to
  have.

  Dean Herbert · 2025-05-23 15:46:52 +09:00
  1cf4636d31
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Update filter control's status text with beatmap displayed count

  This also fixes code running in `Update` which shouldn't be, by
  consuming the new `NewItemsPresented` callback.
  
  Fields and properties are renamed to knock some sense into things (was
  previously called two or three different things).

  Dean Herbert · 2025-05-09 15:05:41 +09:00
  1edbdc5aac