Bartłomiej Dach
628e7a71ed
Ignore possible nulls in Type.GetType() calls
...
They're mostly used in extensibility scenarios, so everything happens in
runtime. There is no better resolution than to crash with a null
reference exception.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
044770f1a2
Locally suppress warning in SerializationReader
...
`SerializationReader` is not written in a form that would support
turning nullability checking on for the entire class. The biggest
problem there is the inner `DynamicDeserializer` static class, whose
members are initialised via an `initialize()` method, which the compiler
knows nothing about.
For this reason, just opt to suppress the single inspection about
returning a `null` from a method with a return type of `string` (rider
expects `string?`). It would have been also viable to enable nullability
checking for this one method, but that's pretty much the same thing and
adds no safety anyways, so just disable the warning to minimise
surprise.
2021-05-14 23:29:34 +02:00
Dean Herbert
b5954a55ad
Remove empty <returns> xmldoc
2021-04-12 17:46:14 +09:00
Dean Herbert
4795170c60
Add back the default json converter locally to ensure it's actually used
2021-03-19 20:07:13 +09:00
Dean Herbert
b1c4ac9f42
Remove local implementation of Vector2Converter
...
This has been moved to framework in
https://github.com/ppy/osu-framework/pull/4285 .
2021-03-19 19:01:32 +09:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
Dean Herbert
8ab7d07eab
Tidy up config parsing logic
2021-02-12 12:57:57 +09:00
Lucas A
f0dfa9f8f3
Use the newest config file available (where the local username matches the filename)
2021-02-08 11:12:25 +01:00
Lucas A
f6d08f54e6
Use the oldest user config file available when there happens to be multiple config files available.
2021-02-05 21:19:13 +01:00
Lucas A
383c40b992
Address remaining reviews suggestions.
2021-01-26 20:35:42 +01:00
Lucas A
2a2b6f347e
Use a lazy for delegating Songs directory locating until it is actually used.
2021-01-26 19:07:05 +01:00
Lucas A
043385f919
Rename const and fix unintended tabbing.
2021-01-26 18:45:04 +01:00
Lucas A
a4a7f0c578
Address CI inspections.
2021-01-25 19:05:16 +01:00
Lucas A
f0fdad2f83
Construct a DesktopStorage pointing to the absolute path of the song directory.
2021-01-24 22:04:46 +01:00
Lucas A
9a5790cd31
Implement StableStorage class.
2021-01-24 19:18:16 +01:00
Dean Herbert
a7f78d706a
Merge branch 'master' into fix-legacy-skin-texture-loader-store
2020-12-22 12:09:35 +09:00
smoogipoo
e23d81bfc6
Use enum property
2020-12-21 16:56:45 +09:00
Dean Herbert
a5bcf1dc20
Expose resources to skin via interface (and share common pieces with beatmap)
2020-12-21 15:18:52 +09:00
Bartłomiej Dach
89bf7b1bd6
Resolve CA1835 inspection
...
"Change the `ReadAsync` method call to use the
`Stream.ReadAsync(Memory<byte>, CancellationToken)` overload"
2020-11-01 18:51:39 +01:00
Dean Herbert
31f6051db9
Add missing xmldoc
2020-10-19 15:36:27 +09:00
Dean Herbert
1989141968
Merge branch 'master' into tourney-asset-refactor
2020-10-07 21:34:07 +09:00
Dean Herbert
58e84760b9
Fix path empty string check causing regression in behaviour
2020-09-03 19:17:07 +09:00
Dean Herbert
218cc39a4c
Avoid throwing exceptions when MutatePath is called with null path
2020-09-03 13:20:23 +09:00
Shivam
c167727ac6
Merge branch 'master' into tourney-asset-refactor
...
# Conflicts:
# osu.Game/IO/OsuStorage.cs
2020-08-09 12:38:41 +02:00
smoogipoo
00a2fbce06
Fix test failures
2020-07-06 22:41:58 +09:00
smoogipoo
1effe71ec2
Add dialog for storage options
2020-07-06 22:03:09 +09:00
Shivam
66e61aacff
Logger now shows the actual path of the destination
...
Forgot to change this while changing the param from string to Storage
2020-07-02 00:32:09 +02:00
Shivam
c3cd2a74f5
Move general purpose migration to MigratableStorage
2020-07-01 22:57:16 +02:00
smoogipoo
cdcad94e9f
Handle exception thrown due to custom stoage on startup
2020-07-01 17:47:29 +09:00
smoogipoo
ab15b6031d
Update with framework-side storage changes
2020-07-01 17:12:07 +09:00
Shivam
47a732ef60
Address review comments
...
Now asserting instead of an if-statement, change cast from OsuStorage to MigratableStorage and make internal virtual properties protected.
2020-06-24 23:01:56 +02:00
Shivam
af11340849
Fix nullref exceptions and redundant explicit type
2020-06-24 02:13:28 +02:00
Shivam
c32ef5e718
Address formatting issues
2020-06-24 00:37:29 +02:00
Shivam
8e8458ab8f
make migrate public abstract in base and override
2020-06-23 23:58:28 +02:00
Shivam
a47d34f1db
make ignore properties protected virtual get-only in base
2020-06-23 23:34:26 +02:00
Shivam
a899c754f1
Remove whitespace at the end of xmldoc line
2020-06-22 13:03:24 +02:00
Shivam
a94dcc4923
Add xmldoc to MigratableStorage
2020-06-22 12:59:38 +02:00
Shivam
6b14079c0a
InspectCode changes
2020-06-22 12:43:01 +02:00
Shivam
f878388d57
Fix TestMigrationToSeeminglyNestedTarget failing
2020-06-22 11:56:14 +02:00
Shivam
21774b8967
Move static properties to parent class and inherit OsuStorage from it
2020-06-22 11:38:50 +02:00
Shivam
dd9697032c
Introduce new class MigratableStorage
2020-06-16 17:39:20 +02:00
smoogipoo
092f5b6521
Fix incorrect reference + simplify
2020-06-03 17:41:05 +09:00
smoogipoo
8aa8d2c880
Resolve NREs
2020-06-03 16:59:37 +09:00
Dean Herbert
6904d5d247
Remove unnecessary override
2020-05-25 13:12:53 +09:00
Dean Herbert
1977affe7e
Fix OpenInNativeExplorer not working correctly for wrapped storages
2020-05-25 09:27:11 +09:00
Dean Herbert
6ca102bc3f
Attempt delete operations more than once
2020-05-15 13:19:03 +09:00
Dean Herbert
9ed0e8891b
Merge branch 'fix-nested-folder-migration-endless-copy' into migration-ui
2020-05-15 13:04:16 +09:00
Dean Herbert
0690d81bbb
Add protection against migrating to a nested folder
2020-05-15 10:40:26 +09:00
Dean Herbert
25bbb02999
Throw better exceptions from OsuStorage
2020-05-15 10:28:03 +09:00
