534 Commits

• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• Add clamping to SliderMultiplier and SliderTickRate at parsing time
  Dean Herbert · 2023-05-09 20:53:20 +09:00
  ca5e8b290f
• Rename slider multiplier variable back for now
  Dean Herbert · 2023-05-09 16:58:19 +09:00
  944da06c10
• Rename SliderMultiplier to BaseSliderVelocity
  Dean Herbert · 2023-05-08 13:13:09 +09:00
  f7d44c3013
• Move struct to bottom of file
  Dean Herbert · 2023-05-03 13:33:31 +09:00
  f930c4bd0a
• Split out default and sample application
  Dean Herbert · 2023-05-03 13:30:45 +09:00
  48fd99818e
• Refactor applyLegacyInfoAndDefaults for legibility
  Dean Herbert · 2023-05-03 13:26:50 +09:00
  cca15f930c
• Move pragma disable to top of LegacyBeatmapDecoder

  Makes more sense as it's used multiple times in the class.

  Dean Herbert · 2023-05-03 13:19:14 +09:00
  588a4e6196
• remove all redundancies from encoded control points
  OliBomby · 2023-05-01 16:53:38 +02:00
  8c21fddb5e
• dont encode custom sample bank for objects without legacy samples
  OliBomby · 2023-05-01 14:56:29 +02:00
  8302bb1f37
• dont assign custom sample bank and volume to hitobjects in non-mania gamemodes

  this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject

  OliBomby · 2023-05-01 12:31:27 +02:00
  cef9f73d34
• Merge remote-tracking branch 'upstream/master' into sample-control-points
  OliBomby · 2023-04-30 19:47:03 +02:00
  608fa3cc73
• fix legacy encoder writing sample info while not writing node samples
  OliBomby · 2023-04-30 17:46:47 +02:00
  139a1d7e6d
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• fixed sample control point applying
  OliBomby · 2023-04-26 14:32:12 +02:00
  1b4f4372d5
• fix invalidoperation exception
  OliBomby · 2023-04-26 14:28:48 +02:00
  5accb05f45
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• remove hitobject SampleControlPoint usage from LegacyBeatmapEncoder
  OliBomby · 2023-04-25 16:00:40 +02:00
  c37875bee8
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Switched to lowercase
  Haspamelodica · 2023-04-21 02:35:28 +02:00
  e90660c1a4
• Fixed video importing bug #23259
  Haspamelodica · 2023-04-21 02:10:24 +02:00
  b62de5514c
• Gracefully handle beatmaps specifying images using the video storyboard type
  Dean Herbert · 2023-03-13 18:24:16 +09:00
  da947d8661
• Move OmitFirstBarLine to TimingControlPoint
  Dean Herbert · 2023-02-28 19:29:31 +09:00
  044b0604b2
• Fix editor exporting beatmap combo colours in wrong order
  Salman Ahmed · 2023-01-03 13:41:08 +03:00
  4491a5ba9f
• Use StringSplitOptions.TrimEntries for string.Split() when possible
  Berkan Diler · 2022-12-27 09:41:58 +01:00
  182f36c434
• Remove redundant type specs
  Bartłomiej Dach · 2022-12-26 23:12:53 +01:00
  cb2b0d4178
• Fix typo
  Berkan Diler · 2022-12-26 20:38:35 +01:00
  fcbb21c75e
• Use generic Enum methods
  Berkan Diler · 2022-12-26 20:36:39 +01:00
  c7ca4bbba5
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Add support for storyboards with incorrect path specifications (\\ instead of \)

  Closes https://github.com/ppy/osu/issues/21204.

  Dean Herbert · 2022-11-21 16:12:01 +09:00
  3da21e596a
• Don't trim whitespace from variable keys / values
  Dean Herbert · 2022-11-08 13:30:11 +09:00
  064a245c50
• Decode variables earlier in flow in case they include indent logic

  Without this change, the `depth` calculation could be incorrect.

  Dean Herbert · 2022-11-08 13:29:42 +09:00
  b764d1bd04
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• Merge branch 'master' into fix-17143
  Dan Balasescu · 2022-10-25 13:44:58 +09:00
  6177df2a24
• Fix huge oversight causing test failures
  Dean Herbert · 2022-10-19 23:54:12 +09:00
  677b8d09f8
• Add and consume sample bank constants
  Dean Herbert · 2022-10-19 20:47:58 +09:00
  579d5b51eb
• Fix some older beatmaps having missing backgrounds

  Closes https://github.com/ppy/osu/issues/20824.
  
  Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.

  Dean Herbert · 2022-10-19 16:01:10 +09:00
  59e2478b0e
• Move check to LegacyDifficultyControlPoint
  Dan Balasescu · 2022-10-13 15:05:15 +09:00
  338115ff6a
• Introduce BpmMultiplierMania, remove after the fact clamps
  sw1tchbl4d3 · 2022-10-12 11:14:01 +02:00
  df0501235d
• Move clamps directly to the usages in the conversion algorithm
  sw1tchbl4d3 · 2022-10-10 09:36:18 +02:00
  f8036658c7
• Fix legacy BpmMultiplier clamp value
  sw1tchbl4d3 · 2022-10-09 11:25:47 +02:00
  e0904e263f
• Disable alpha component parsing in beatmap / skin colour sections
  Dean Herbert · 2022-09-21 16:11:41 +09:00
  992441b9de
• Fix test failures
  Khang · 2022-08-24 03:37:33 -04:00
  adea29c106
• Document why beatLength can be NaN
  Khang · 2022-08-24 02:10:19 -04:00
  c9f364d6a0
• Move GenerateTicks to LegacyDifficultyControlPoint and remove support for NaN slider velocity support for other rulesets (at least for now)
  Khang · 2022-08-23 14:07:18 -04:00
  c1ced85b5e
• Treat NaN slider velocity timing points as 1.0x but without slider ticks
  Khang · 2022-08-22 21:58:38 -04:00
  9f08c474ca
• Allow NaN during beatmap parsing if desired
  Khang · 2022-08-22 21:04:26 -04:00
  e8d4bc4497