101 Commits

• Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)

  Turns out that items could be in an order that isn't the same as how
  things look on the carousel, so this change ensures that for testing
  purposes they are sorted by Y position.
  
  Also uses the `CarouselItem.Visible` flag to ensure that we don't have
  to wait for drawable fade transitions after a filter operation.

  Dean Herbert · 2023-03-03 17:18:34 +09:00
  a14dede036
• Add better coverage and more comments explaining the structure of test setup
  Dean Herbert · 2023-03-03 17:18:14 +09:00
  7a092ea995
• Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes

  From a user's perspective, changing a sort / order mode shouldn't filter
  away results, but we were doing this.
  
  In terms of UX expectations, in stable this kind of scenario would
  results in a group being added to the end of son select with "Not
  ranked" or "Unknown". I think we should aim to match this eventually.

  Dean Herbert · 2023-03-03 16:36:18 +09:00
  82293c0c86
• Remove OnlineID sort consideration
  Dean Herbert · 2023-01-18 19:21:02 +09:00
  3b27774561
• Add test coverage of carousel sort expectations

  This covers the fail case of removing and adding items (see
  https://github.com/ppy/osu/issues/21926) but also covers the proposed
  forward implementation, which now considers `DateAdded` and `OnlineID`.

  Dean Herbert · 2023-01-17 16:40:25 +09:00
  92fc439f82
• Fix potential nullref in certain beatmap carousel tests
  Salman Ahmed · 2023-01-13 19:42:09 +03:00
  e6ff262521
• remove unnecessary usages of nullable forgiveness, add asserts for debugging
  mk56-spn · 2023-01-09 18:36:55 +01:00
  69260ca3c3
• Fix errors in test
  mk56-spn · 2023-01-08 19:18:28 +01:00
  a32c4a64e7
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add failing test case
  Bartłomiej Dach · 2022-11-20 10:07:32 +01:00
  b3667821eb
• Move test to improve diff readability
  Endrik Tombak · 2022-10-24 22:55:09 +03:00
  b95091fbb0
• Write new tests
  Endrik Tombak · 2022-10-24 22:50:56 +03:00
  9def12c60b
• Add missing null check in BeatmapCarousel tests
  Dean Herbert · 2022-09-07 16:22:11 +09:00
  b50116e9e4
• Add failing test of date submitted search failing
  Dean Herbert · 2022-09-01 19:59:27 +09:00
  148e487c02
• Fix some BeatmapCarousel tests not correctly reinitialising local data per run

  Closes https://github.com/ppy/osu/issues/19949.

  Dean Herbert · 2022-08-25 14:03:26 +09:00
  1032b2a68c
• Add failing test case
  Salman Ahmed · 2022-08-01 18:43:01 +03:00
  682192dbd7
• Improve existing test coverage to cover order changes from other sort modes
  Salman Ahmed · 2022-07-26 10:24:51 +03:00
  91ffa7007f
• Move test to stand-alone class and add full ui testing
  Dean Herbert · 2022-07-19 18:50:27 +09:00
  f6de76e057
• Add beatmap update button
  Dean Herbert · 2022-07-19 18:29:36 +09:00
  eaf4f6dbb7
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add test coverage checking carousel panel visual state after ruleset filter change
  Dean Herbert · 2022-02-11 15:21:01 +09:00
  f012f64fd1
• Fix TestSelectingFilteredRuleset failing under visual tests due to using local database
  Dean Herbert · 2022-02-03 16:04:05 +09:00
  41aa4b8cca
• Merge branch 'master' into song-select-scroll-position-during-delete
  Bartłomiej Dach · 2022-01-27 20:46:19 +01:00
  04d6ca59a3
• Add failing test coverage showing carousel deletions don't keep scroll position
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  f2cecad83b
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Remove outdated comment
  Dean Herbert · 2022-01-14 21:40:35 +09:00
  9900a3f408
• Fix beatmap carousel test failures
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  41d90cd0b5
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• "Update" BeatmapCarousel
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3152d2d8a0
• Miscellaneous fixes that don't fit elsewhere
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  e6fdd0e969
• Remove unnecessary assigns of EF foreign ID fields in tests
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  2cb97dd599
• Update sets of BeatmapSet.Metadata to instead create a Beatmap
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  37673f4cf8
• Update mock model usage to set GUIDs instead of ints
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  e6f6558ddf
• Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel
  Dean Herbert · 2021-11-25 16:29:06 +09:00
  e6cfe44652
• Fix a few incorrectly updated arguments
  Dean Herbert · 2021-11-24 18:14:18 +09:00
  7603f7eb36
• Combine all test data BeatmapSetInfo creation into a single method
  Dean Herbert · 2021-11-24 18:07:32 +09:00
  0c819b9cfb
• Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests
  Dean Herbert · 2021-11-24 14:52:08 +09:00
  44c34ca7b2
• Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
  Dean Herbert · 2021-11-24 13:27:37 +09:00
  8c60f37508
• Use Equals in carousel tests for better realm compatibility
  Dean Herbert · 2021-11-22 17:20:21 +09:00
  001f7c36f3
• Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:52:44 +09:00
  692e846acd
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
  Dean Herbert · 2021-11-11 17:19:46 +09:00
  ebe58cee11
• Update all existing usages of AuthorString/AuthorId

  Unfortunately the getters need to be left in place else EF breaks.

  Dean Herbert · 2021-11-04 18:59:37 +09:00
  ed07ee8c61
• Fix one more missed case
  Dean Herbert · 2021-10-29 18:35:15 +09:00
  04acc7601c
• Fix test scene and remove "impossible" nullable coalesce
  Dean Herbert · 2021-10-29 18:22:23 +09:00
  07e3ced315
• Rename BeatmapInfo variables which were named beatmap for clarity
  Dean Herbert · 2021-10-02 12:45:34 +09:00
  973c31132b
• Fix test potentially not waiting for drawable beatmaps to be loaded
  Dean Herbert · 2021-05-27 16:12:49 +09:00
  5c44083856
• Remove ScrollableContent container from carousel

  This was causing multiple issues with masking and sizing and really
  didn't need to exist in the first place. Also not sure why the pool was
  nested inside the scroll container, but it isn't any more. Probably for
  the best.

  Dean Herbert · 2020-11-26 18:28:54 +09:00
  f8db7a9902