56421 Commits

This Branch

This Branch

All Branches

• Fix regex by allowing file extensions + typed new

  Apparently, the _whole_ filename was checked with GetValidArchiveContentFilename,
  not just the stem.

  nullium21 · 2022-10-28 09:19:34 +03:00
  c1e9398c19
• Use a regex for matching invalid characters instead

  What the regex does is it matches everything except alphanumeric and [_()[] -], excluding EOL since regex101 seems to also match it, and we probably don't want that to happen.

  nullium21 · 2022-10-27 10:33:50 +03:00
  68d1febe6e
• Only use 0-9A-Za-z-_()[] characters in filenames
  nullium21 · 2022-10-26 13:31:32 +03:00
  dffebdf7ed
• Merge pull request #20941 from peppy/fix-distance-snap-offset

  Offset start of distance snap grid drawing if reference object's start time doesn't align

  Dan Balasescu · 2022-10-26 13:46:31 +09:00
  72b594d72e
• Merge pull request #20922 from ekrctb/fix-mania-hold-note-fade-out

  Fix hold note disappearing instantly without fade out

  Dan Balasescu · 2022-10-26 13:44:40 +09:00
  a8393a81a4
• Offset start of distance snap grid drawing if reference object's start time doesn't align

  Closes #20938.

  Dean Herbert · 2022-10-26 13:11:26 +09:00
  2016d33055
• Add test coverage of distance snap grid failing visually
  Dean Herbert · 2022-10-26 13:10:54 +09:00
  cab9a1c012
• Move distance snap grid test cursor behind grid to better visualise centre-points
  Dean Herbert · 2022-10-26 13:10:54 +09:00
  5f10b81af1
• Merge pull request #20934 from bdach/fix-taiko-flashlight-regression

  Fix invalid taiko flashlight size calculation

  Dean Herbert · 2022-10-26 12:11:48 +09:00
  ccbc39910c
• Merge pull request #20912 from LittleEndu/carousel-do-not-select-random

  Make beatmap carousel select nearest to selection when selection was filtered

  Dean Herbert · 2022-10-26 11:40:56 +09:00
  7249542167
• Merge pull request #20937 from Joehuu/listing-scroll-to-top-tags/source

  Scroll beatmap listing to top when searching via tags/source

  Dean Herbert · 2022-10-26 11:37:09 +09:00
  0ed40c8676
• Clamp backwards index to total current items to fix edge case of item removal
  Dean Herbert · 2022-10-26 11:03:11 +09:00
  d9d083752a
• Scroll beatmap listing to top when searching via tags/source
  Joseph Madamba · 2022-10-25 18:06:49 -07:00
  8505848b1a
• Merge pull request #20901 from peppy/add-editor-object-clone

  Add ability to clone objects in the editor

  Bartłomiej Dach · 2022-10-25 22:16:07 +02:00
  181c7d1d6e
• Rename one more "{duplicate -> clone}" reference
  Bartłomiej Dach · 2022-10-25 21:34:41 +02:00
  f5ca447b8e
• Merge branch 'master' into add-editor-object-clone
  Bartłomiej Dach · 2022-10-25 21:33:52 +02:00
  bcdf24b972
• Merge pull request #20903 from peppy/beat-snap-divisor-hotkey

  Add ability to use `Shift`+`Number` to set current beat divisor in editor

  Bartłomiej Dach · 2022-10-25 21:06:59 +02:00
  2ddb94db64
• Merge branch 'master' into beat-snap-divisor-hotkey
  Bartłomiej Dach · 2022-10-25 20:32:32 +02:00
  3d31c9bbc5
• Attempt to make flashlight code slightly more legible
  Bartłomiej Dach · 2022-10-25 20:15:19 +02:00
  974f22dd97
• Fix invalid flashlight size calculation

  This regressed in #20714. One usage of `getSizeFor(0)` was replaced by
  `adjustSize(GetSize())`, but another usage of `getSizeFor(Combo.Value)`
  was replaced by `adjustSize(Combo.Value)`, which is not correct, since
  `adjustSize()` is expecting to receive a combo-based size, rather than a
  combo value directly.

  Bartłomiej Dach · 2022-10-25 20:03:22 +02:00
  e3bc1126d7
• Add failing test case
  Bartłomiej Dach · 2022-10-25 20:02:28 +02:00
  93e9b4a2c5
• Merge pull request #20345 from mk56-spn/Freeze_frame_implementation

  Add "Freeze Frame" mod

  Dean Herbert · 2022-10-26 01:28:23 +09:00
  521fbd2ea3
• Fix tests
  ekrctb · 2022-10-25 19:48:33 +09:00
  0b8b322322
• Fix hold note disappear instantly
  ekrctb · 2022-10-25 19:16:23 +09:00
  92ab39f5c2
• Harden and simplify logic to avoid weird issues
  Dean Herbert · 2022-10-25 18:57:15 +09:00
  cf3bf41b49
• Merge pull request #20914 from peppy/allow-distance-grid-snap

  Allow both distance snap and grid snap to be applied at the same time

  Dan Balasescu · 2022-10-25 16:04:11 +09:00
  5a537f13b5
• Merge pull request #20916 from peppy/sample-documentation

  Rename some pieces and better document `SampleBankInfo`

  Dan Balasescu · 2022-10-25 15:59:19 +09:00
  cb9fc78255
• Remove Incompatibility with HD
  D.Headley · 2022-10-25 08:48:45 +02:00
  f4aae9138b
• Rename some pieces and better document SampleBankInfo
  Dean Herbert · 2022-10-25 14:55:33 +09:00
  da93849b80
• Update tests in line with new behaviour
  Dean Herbert · 2022-10-25 14:32:08 +09:00
  a9755295e4
• Allow both distance snap and grid snap to be applied at the same time
  Dean Herbert · 2022-10-25 14:09:22 +09:00
  02a3f8c17f
• Add early return of carousel group has no items
  Dean Herbert · 2022-10-25 13:34:22 +09:00
  22ea9a8ab4
• Fix typon in comment
  Dean Herbert · 2022-10-25 13:27:26 +09:00
  279ef556e3
• Change approach circles to all appear at the same time, but don't adjust AR
  Dean Herbert · 2022-10-25 13:26:32 +09:00
  588fc750cd
• Add test scene for "Freeze Frame" mod
  Dean Herbert · 2022-10-25 13:25:38 +09:00
  3d72ff28c3
• Rewrite implementation to avoid duplicated LINQ returns
  Dean Herbert · 2022-10-25 12:48:17 +09:00
  2456a18bc1
• Add top level test coverage of editor shortcuts
  Dean Herbert · 2022-10-25 12:03:46 +09:00
  8e4f5381e3
• Add test coverage of BeatDivisorControl key bindings
  Dean Herbert · 2022-10-25 11:51:31 +09:00
  1b42f5ec6e
• Rename to "clone" instead of "duplicate"
  Dean Herbert · 2022-10-25 11:43:23 +09:00
  4d4f6e25ba
• Fix duplicate working incorrectly if there is no selection currently made
  Dean Herbert · 2022-10-25 11:42:12 +09:00
  1e579e06f8
• Add test coverage of clone operations
  Dean Herbert · 2022-10-25 11:38:58 +09:00
  da74690ec9
• Merge pull request #20810 from peppy/scoring-test-scene

  Add test scene as environment to test changes to score algorithms

  Dan Balasescu · 2022-10-25 11:19:00 +09:00
  f6f30eec0b
• Move test to improve diff readability
  Endrik Tombak · 2022-10-24 22:55:09 +03:00
  b95091fbb0
• Write new tests
  Endrik Tombak · 2022-10-24 22:50:56 +03:00
  9def12c60b
• Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection

  
   Conflicts:
  
  	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs

  Endrik Tombak · 2022-10-24 21:40:48 +03:00
  5a118cfdc3
• Merge pull request #20904 from peppy/fix-tournament-seeding-editor-crash

  Fix crash when exiting seeding editor too soon

  Bartłomiej Dach · 2022-10-24 19:25:20 +02:00
  6ac7518df4
• Merge branch 'master' into fix-tournament-seeding-editor-crash
  Bartłomiej Dach · 2022-10-24 18:50:49 +02:00
  3f6b8ec38c
• Merge pull request #19048 from ggliv/directoryselector-hidden-toggle

  Add hidden item toggle to directory/file selectors

  Dean Herbert · 2022-10-24 16:28:47 +09:00
  e3e88d0d50
• Fix crash when exiting seeding editor too soon

  Closes https://github.com/ppy/osu/issues/20783.

  Dean Herbert · 2022-10-24 16:08:50 +09:00
  14704fd07c
• Fix incorrect maxBaseScore accounting due to silly oversight
  Dean Herbert · 2022-10-24 15:54:09 +09:00
  f08270f6b0