Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
...
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Dan Balasescu
6ff1dec7b2
Add tests
2024-12-03 15:45:58 +09:00
Dean Herbert
ce4aac4184
Merge pull request #30917 from bdach/fix-incorrect-taiko-legacy-combo
...
Fix strong drum rolls being counted for double the combo in legacy scoring attributes
2024-12-02 20:08:49 -08:00
Tim Schumacher
e920cfa187
Move rate-changing TODO to a common place in CalculateRateWithMods
2024-12-02 23:49:51 +01:00
Dean Herbert
ce8e4120b7
Merge pull request #30947 from bdach/undesirable-deselect-on-control-click
...
Do not deselect objects when control-clicking without hitting anything
2024-12-02 07:17:27 -08:00
Bartłomiej Dach
b505ecc7ba
Do not deselect objects when control-clicking without hitting anything
...
As per feedback in
https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284 .
2024-12-02 13:51:43 +01:00
Bartłomiej Dach
b14dde937d
Add failing test case
2024-12-02 13:51:41 +01:00
Bartłomiej Dach
6c0ccc5ebe
Merge pull request #30863 from frenzibyte/improve-back-button-display
...
Delay back button appearance when performing a quick restart
2024-12-02 11:49:45 +01:00
Bartłomiej Dach
52b8753a12
Merge pull request #30749 from Sheppsu/multi-spectator-settings-sidebar
...
Add player settings to multi spectator screen
2024-12-02 11:34:57 +01:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
...
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Dean Herbert
23522b02d8
Use local instead of field for local only usage
2024-12-01 19:53:57 +09:00
Dean Herbert
6afe083ec9
Fix settings showing up during gameplay
2024-12-01 18:44:26 +09:00
Dean Herbert
ddac71628d
Merge branch 'master' into multi-spectator-settings-sidebar
2024-12-01 18:33:46 +09:00
Tim Schumacher
164b809c89
Document ready button enable state with some comments
2024-11-30 23:02:22 +01:00
Salman Alshamrani
1d610a0f1b
Merge pull request #30928 from peppy/stop-logging-backwards-seek
...
Stop loudly logging backwards seek bug to sentry
2024-11-30 16:35:35 -05:00
Tim Schumacher
f4e155bfa6
Account for rate changing mods when disabling the "Ready" button
2024-11-30 16:01:32 +01:00
Dean Herbert
1e2e364cd3
Stop loudly logging backwards seek bug to sentry
...
Several users have reported stutters when this happens. It's potentially
from the error report overhead. We now know that this is a BASS level
issue anyway, so having this logging is not helpful.
2024-11-30 21:01:22 +09:00
Bartłomiej Dach
e92aa36f47
Merge pull request #30918 from peppy/expose-more-migration-helper-methods
...
Expose more migration helper methods
2024-11-29 14:55:45 +01:00
Dean Herbert
f56b2b9aef
Merge pull request #30793 from bdach/close-playlists
...
Add ability to close playlists within grace period after creation
2024-11-29 22:37:32 +09:00
Dean Herbert
a719693d10
Fix one remaining method call
2024-11-29 21:21:05 +09:00
Dean Herbert
0e1b62ef85
Expose more migration helper methods
...
For use in https://github.com/ppy/osu-queue-score-statistics/pull/305 .
Some of these might look a bit odd, but I personally still prefer having
them all in one central location.
2024-11-29 21:10:30 +09:00
Dean Herbert
58efed4ebe
Merge pull request #30915 from bdach/extension-checks
...
Centralise supported file extensions to one helper class
2024-11-29 20:55:28 +09:00
Bartłomiej Dach
3cfa455369
Fix strong drum rolls being counted for double the combo in legacy scoring attributes
2024-11-29 10:54:32 +01:00
Bartłomiej Dach
5f092811cb
Use helper in one more place
2024-11-29 09:22:29 +01:00
Bartłomiej Dach
5a9127dfc6
Accidentally a word
2024-11-29 08:46:08 +01:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
...
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837 .
2024-11-29 08:42:45 +01:00
Salman Alshamrani
b71bccc42d
Merge pull request #30914 from peppy/dev-footer-pass
...
Simplify the dev footer display
2024-11-29 02:14:30 -05:00
Dean Herbert
b697ddc6db
Simplify the dev footer display
2024-11-29 15:32:35 +09:00
Dean Herbert
ca32720cbd
Merge pull request #30904 from frenzibyte/save-android
...
Work around Android CI workflow errors
2024-11-29 14:54:52 +09:00
Dean Herbert
276c37bcf7
Update framework
2024-11-29 13:47:56 +09:00
Dean Herbert
a67f7ea3fb
Merge branch 'master' into save-android
2024-11-29 13:46:53 +09:00
Salman Alshamrani
f664e97496
Merge pull request #30906 from Hiviexd/daily-challenge-tier-thresholds
...
Adjust daily challenge tier thresholds to match expectations
2024-11-28 18:36:31 -05:00
Salman Alshamrani
51bcde67aa
Remove no longer required comment
2024-11-28 17:55:15 -05:00
Salman Alshamrani
078d62fe09
Fix weird default in test scene
2024-11-28 17:54:03 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds
2024-11-28 17:46:55 -05:00
Salman Alshamrani
932afcde01
Make editor make sense
2024-11-28 17:43:32 -05:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
6ed21229b7
update test
2024-11-28 12:49:48 +01:00
Hiviexd
66093872e8
Adjust daily challenge tier thresholds to match expectations
2024-11-28 12:49:30 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
...
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Bartłomiej Dach
d218c19799
Merge pull request #30852 from frenzibyte/fix-daily-challenge-leaderboard
...
Fix daily challenge results screen fetching scores beginning from the user's highest
2024-11-28 10:21:52 +01:00
Dean Herbert
c26c84ba45
Add test coverage governing new behaviour
2024-11-28 18:03:19 +09:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
...
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885 .
We could also only null this on application, but this feels worse
because
- It would require local handling (potentially complex) in
`BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
potentially make future usage not possible due to being nulled in only
a very specific scenario.
One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
