5235 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Dan Balasescu	91f2cf8cc3	Use more descriptive HitObject names for debugger displays	2024-06-13 15:18:39 +09:00
Bartłomiej Dach	10af642342	Split mania difficulty section implementation off completely from base ... - "Circle size" / key count needs completely different handling. - Approach rate does not exist in mania.	2024-06-11 11:30:20 +02:00
Salman Ahmed	6f729be573	Merge branch 'master' into LeaderBoardScore_clean	2024-06-07 22:42:49 +03:00
Dean Herbert	091104764e	Fix AssemblyRulesetStore not marking rulesets as available	2024-06-02 17:33:06 +09:00
Dean Herbert	4162d0babe	Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix ... Fix for nearly straight sliders causing a crash	2024-05-31 20:00:47 +09:00
Aurelian	9111da81d2	Updated comments	2024-05-31 08:20:19 +02:00
Bartłomiej Dach	a6c776dac8	Use hopefully safer implementation of anchoring judgements to objects	2024-05-29 11:11:43 +02:00
Aurelian	542809a748	Reduced subpoints limit to be a more practical value	2024-05-29 09:39:46 +02:00
Aurelian	6c4def1c09	Added check for infinite subpoints for PerfectCurve	2024-05-27 20:32:18 +02:00
Dean Herbert	740a3377fa	Merge branch 'master' into LeaderBoardScore_clean	2024-05-27 17:18:41 +09:00
Dean Herbert	11c3d11db9	Fix cinema mod not hiding playfield skin layer	2024-05-27 14:52:28 +09:00
Salman Ahmed	5955378004	Replace "X mods" text with a pill indicator	2024-05-25 16:11:24 +03:00
Aurelian	b2c4e0e951	Reworked linear line check, and optimized scaled flat slider test	2024-05-24 14:05:56 +02:00
Aurelian	fff52be59a	Addressed code quality issues	2024-05-24 09:30:24 +02:00
Aurelian	d948e0fc5c	Nearly straight sliders are treated as linear	2024-05-24 08:26:17 +02:00
Dean Herbert	d0b1ebff5a	Revert "Temporary rollback of framework / SDL3" ... This reverts commit d7d569cf4e.	2024-05-22 16:29:39 +08:00
Dean Herbert	d7d569cf4e	Temporary rollback of framework / SDL3	2024-05-21 14:36:16 +08:00
Dean Herbert	a3960bf715	Add inline comment explaining LifetimeEnd set for future visitors	2024-05-15 14:17:28 +08:00
Dean Herbert	cfb2c8272b	Set a rudimentary lifetime end to improve seek performance in scrolling rulesets	2024-05-14 05:02:08 +08:00
Dean Herbert	a780abb0b4	Merge pull request #27912 from bdach/pre-mod-multiplier-score ... Store total score without mod multipliers to local database and to replays, and send it on score submission	2024-05-10 22:46:34 +08:00
Dan Balasescu	3b8b56cbcb	Apply required changes after framework masking updates	2024-05-09 20:18:53 +09:00
Bartłomiej Dach	c9414da5d4	Merge branch 'master' into pre-mod-multiplier-score	2024-05-08 13:39:44 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Bartłomiej Dach	fe9e6168fe	Merge pull request #28050 from peppy/delay-resume-visibility ... Tweak resume overlay to allow better visibility of hit objects underneath	2024-05-01 15:49:31 +02:00
Dean Herbert	87e814e201	Fix incorrect xmldoc and adjust colour provider to match Player	2024-05-01 20:30:36 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Bartłomiej Dach	cbbf2dd158	Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue	2024-04-23 18:58:40 +02:00
Bartłomiej Dach	787e60f706	Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity	2024-04-23 18:57:14 +02:00
Bartłomiej Dach	1f010c4bfd	Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter ... Fix gameplay PP counter not matching results screen	2024-04-23 08:43:49 +02:00
Bartłomiej Dach	70a5288a68	Do not attempt to pass files that don't look like audio to BASS	2024-04-22 10:45:09 +02:00
Bartłomiej Dach	78f97d0ec7	Merge branch 'master' into verify-check-incorrect-audio-formats	2024-04-22 10:34:14 +02:00
Bartłomiej Dach	ceeb9b0819	Use explicit reference equality check	2024-04-22 10:27:30 +02:00
Bartłomiej Dach	1bcf835d22	Remove redundant array type specification	2024-04-22 10:25:46 +02:00
Arthur Araujo	49563f4e5b	Use bitwise to check hitsound formats	2024-04-22 04:44:38 -03:00
Arthur Araujo	92b85beff6	Remove ChannelType from messages	2024-04-19 08:01:23 -03:00
Arthur Araujo	68e86b5105	Remove unsued import and add a blankline before yield break;	2024-04-19 07:39:31 -03:00
Arthur Araujo	eac9dededf	Use periods instead of semicolons ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-19 07:20:59 -03:00
Arthur Araujo	ac03856ebd	Fix test methods names	2024-04-17 08:22:05 -03:00
Arthur Araujo	8d94f8d995	Remove BassFlags.Prescan and free the decodeStream	2024-04-17 08:14:19 -03:00
Bartłomiej Dach	e0178802b8	Populate TotalScoreWithoutMods on scores set locally	2024-04-17 08:52:47 +02:00
Arthur Araujo	c32d99250f	Deal with corrupt audio files ... This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.	2024-04-16 06:53:55 -03:00
Arthur Araujo	9ef27104ce	Add checks for audio formats	2024-04-16 06:15:21 -03:00
Dan Balasescu	343b3ba0e6	Don't re-filter unless mods may change the filter	2024-04-15 21:07:36 +09:00
Dan Balasescu	e9b319f4c6	Ensure all remaining objects are added in the last iteration	2024-04-12 00:11:54 +09:00
Dan Balasescu	19cc847be6	Implement a less failure-prone method	2024-04-11 23:40:40 +09:00
Dan Balasescu	f5555b9fa4	Also add potentially missed intermediate parents	2024-04-11 16:53:08 +09:00
Bartłomiej Dach	518addf323	Merge branch 'master' into fix-catmull-bulbs	2024-04-10 11:25:02 +02:00
Dan Balasescu	fefcd17db9	Fix gameplay PP counter not matching results screen	2024-04-08 22:34:11 +09:00
Bartłomiej Dach	cb82fb0487	Merge branch 'master' into mania-key-count-mod-query	2024-04-03 09:29:32 +02:00