48760 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	104256a054	Add test coverage	2022-02-02 15:18:44 +09:00
Dean Herbert	e7d72f1823	Revert recent changes	2022-02-02 15:18:44 +09:00
Dean Herbert	0c5da9370a	Fix rulesets potentially being marked Available even when methods are missing ... Came up when running the game after the recent breaking changes (https://github.com/ppy/osu/pull/16722), where two template rulesets I had loaded were erroring on startup but still being marked as available, allowing them to crash the game on attempting to initiate relpay logic. These cases are already handled for first-time ruleset loading via the `GetTypes()` enumeration in `RulesetStore.addRuleset`, but when consistency checking already present rulesets the only runtime validation being done was `ruleset.CreateInstance()`, which does not handle missing types or methods.	2022-02-02 14:52:01 +09:00
Jamie Taylor	6e60e68b80	Change from click to mousedown+mouseup and only play when cursor is visible	2022-02-02 14:44:06 +09:00
Dean Herbert	a2affefb0a	Avoid checking gameplay clock time in Update method	2022-02-02 14:33:17 +09:00
Dean Herbert	c7a192cc5f	Only handle LeftButton and RightButton actions ... There are definitely going to be other actions used in the future, which would immediately cause this mod to fail. Limiting handling to left/right buttons only is the correct way forward.	2022-02-02 14:04:12 +09:00
Dean Herbert	fed63abd83	Sanitise interceptor logic to now require two separate check paths	2022-02-02 14:02:48 +09:00
Dean Herbert	0036d0e26d	Move alternate mod to "conversion" category	2022-02-02 13:58:13 +09:00
Dean Herbert	6d962e7925	Merge pull request #16726 from dekrain/leaderboard-score-tooltip ... Add basic tooltip for leaderboard scores	2022-02-02 13:56:45 +09:00
Dean Herbert	4b646709c1	Merge pull request #16658 from Spooghetti420/no-long-notes-mod ... Add "Hold Off" mod (no long notes)	2022-02-02 13:35:44 +09:00
Dean Herbert	ddc8094a75	Update description	2022-02-02 13:34:23 +09:00
Dean Herbert	d065e32ca1	Fix crash due to MatchLeaderboardScores not having populated rulesets	2022-02-02 13:23:49 +09:00
Dean Herbert	35b7653290	Revert mod flow changes and add visual test coverage showing an overflow case	2022-02-02 09:13:19 +09:00
Dean Herbert	6033c89e7b	Merge pull request #16734 from bdach/war-on-unused-params ... Fix several cases of unused constructor and method parameters	2022-02-02 07:40:58 +09:00
Bartłomiej Dach	3674ed15ce	Remove unused game host parameter ... No longer used since eeccf836ec.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	b978010b48	Remove unused allowMissing parameter in audio file check test ... No longer used since 7f95400f46.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	7cdf63c654	Remove unused FindProvider() methods ... No longer needed since 39f99bf785.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	e4028b8fc1	Remove index ctor param from ColumnHitObjectArea ... No longer used since 5692cecaa4.	2022-02-01 21:49:52 +01:00
Bartłomiej Dach	e042f29ee3	Remove skin ctor param from LegacyCatchComboCounter ... No longer used since 004798d61d.	2022-02-01 21:49:52 +01:00
Bartłomiej Dach	75101b1105	Remove unused ruleset ctor params from test beatmap model managers ... No longer used since 00e3af3366.	2022-02-01 21:49:41 +01:00
Bartłomiej Dach	994fb966b6	Remove Host ctor param from SkinModelManager ... No longer used since 29d074bdb8.	2022-02-01 21:37:19 +01:00
Bartłomiej Dach	07d09b3520	Remove unused parameter from createGameplayComponents() ... No longer used since 136843c8e4.	2022-02-01 21:35:41 +01:00
Bartłomiej Dach	a94702b3ae	Remove unused parameters in LegacyComboCounter ... No longer used since 9bb8a43bce.	2022-02-01 21:35:41 +01:00
Bartłomiej Dach	1fa2bf5d69	Remove unused parameter from createColourBars() ... No longer used since b61aa660c6.	2022-02-01 21:35:40 +01:00
Bartłomiej Dach	c6a65ccfed	Remove unused parameter from createContent() ... No longer used since 513e470b52.	2022-02-01 21:35:40 +01:00
Bartłomiej Dach	16e0cc6a2b	Remove IIpcHost param from ScoreManager ... No longer used since 3e3b9bc963.	2022-02-01 21:35:40 +01:00
Bartłomiej Dach	a378e78ced	Fix RealmLive unnecessarily passing ID around ... Appears to have never been needed. When the `retrieveFromID` method was created in 81b5717ae7, it didn't use the `id` parameter for anything either.	2022-02-01 21:35:12 +01:00
Bartłomiej Dach	3d7af805a3	Fix BeatmapMetadata not using its user param correctly	2022-02-01 21:16:28 +01:00
dekrain	eee020f8e4	Cleanup tooltip layout ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-02-01 20:26:52 +01:00
Spooghetti420	b75c08c9ab	Improve beat length logic ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-02-01 13:36:36 +00:00
Dean Herbert	2c0c44a950	Merge pull request #16722 from smoogipoo/spectator-consistency-frames ... Implement spectator consistency frames	2022-02-01 17:28:13 +09:00
Dean Herbert	15479ae046	Add test coverage of no header doing nothing	2022-02-01 16:55:28 +09:00
Dean Herbert	0f83f77d2b	Add xmldoc for new ResetFromReplayFrame method	2022-02-01 16:52:53 +09:00
Dean Herbert	f87920cd83	Remove unnecessary GridContainer and list mods verticall to give more space	2022-02-01 16:43:26 +09:00
Dean Herbert	8eace12fe3	Synchronise (roughly) backgrounds of all custom tooltips	2022-02-01 16:35:25 +09:00
Dean Herbert	3ca2c90684	Add test scores in BeatmapLeaderboard test scene with more mods	2022-02-01 16:35:25 +09:00
Dean Herbert	fdb52a8fd7	Remove gap in tooltip display between statistics	2022-02-01 16:35:25 +09:00
Dean Herbert	855135c51e	Fix potential nullref during display due to incorrect equality check	2022-02-01 16:13:27 +09:00
Dean Herbert	e1b57c4bf6	Fix inspections	2022-02-01 16:07:57 +09:00
dekrain	d7b939277e	Code quality improvements	2022-02-01 07:10:00 +01:00
dekrain	fd287e06f2	Add missing license header	2022-02-01 06:51:00 +01:00
dekrain	c2b775c0a3	Minor alignment adjustments	2022-02-01 06:45:59 +01:00
Dan Balasescu	0641264a11	Merge branch 'master' into spectator-consistency-frames	2022-02-01 14:35:30 +09:00
dekrain	db973fb348	Add basic tooltip for leaderboard scores	2022-02-01 06:28:18 +01:00
Dean Herbert	aa492270dd	Ignore FodyWeavers.xml files in subdirectories ... These are created when building specific projects rather than the main solution (typically iOS / android) and of no use to us.	2022-02-01 13:30:28 +09:00
Dean Herbert	5a6d57efb7	Update fastlane and dependencies	2022-02-01 12:43:35 +09:00
Dan Balasescu	c421d8d3cd	Merge pull request #16719 from peppy/mania-column-touch ... Add basic touch input support for osu!mania	2022-02-01 12:26:29 +09:00
Dan Balasescu	c50577e25f	Apply suggestion from review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-02-01 10:48:41 +09:00
Bartłomiej Dach	9227211a44	Privatise shouldAlternate	2022-01-31 22:56:27 +01:00
Dean Herbert	2f88efd3c3	Pass column in rather than accessing parent	2022-02-01 00:53:56 +09:00