osu-lazer

Fix custom tooltip formats no longer displaying in settings

Closes #36793.

Dean Herbert · 2026-03-03 12:59:23 +09:00

ee9f8d5e92

Fix revert to default button not resizing correctly after changing languages

Closes #36519.

Dean Herbert · 2026-02-03 18:17:53 +09:00

b8b6327624

Use enum for background states

Dean Herbert · 2026-01-27 18:58:03 +09:00

fa22d1f202

Standardise hover sounds for form elements

Closes #36444.

Dean Herbert · 2026-01-27 17:06:14 +09:00

dba17b1fa6

Standardise animations

Dean Herbert · 2026-01-27 17:06:13 +09:00

42dc73d849

Various metrics and visual tweaks

Dean Herbert · 2026-01-27 17:06:13 +09:00

6983227240

Standardise background across form controls

Dean Herbert · 2026-01-27 17:06:11 +09:00

c88f10ca1b

Work around flaky TestSceneFirstRunSetupOverlay tests

See inline commentary. I don't really have any energy left to provide
anything else, other than maybe a demonstration of how this dies in
framework:

diff --git a/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
new file mode 100644
index 000000000..c74ce6636
--- /dev/null
+++ b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
@@ -0,0 +1,59 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using NUnit.Framework;
+using osu.Framework.Allocation;
+using osu.Framework.Graphics.UserInterface;
+using osu.Framework.Screens;
+
+namespace osu.Framework.Tests.Visual.UserInterface
+{
+    public partial class TestSceneScreenStackUnbindOnExit : FrameworkTestScene
+    {
+        [Cached]
+        private ScreenStack screenStack = new ScreenStack();
+
+        [Test]
+        public void TestScreenExitUnbindDoesNotInterruptLoadComplete()
+        {
+            AddStep("set up the scenario", () =>
+            {
+                Child = screenStack;
+                screenStack.Push(new Screen());
+                screenStack.Push(new BrokenScreen());
+            });
+            AddUntilStep("wait to get to target screen", () => screenStack.CurrentScreen, Is.InstanceOf<Screen>);
+        }
+
+        private partial class BrokenSlider : BasicSliderBar<float>
+        {
+            [Resolved]
+            private ScreenStack screenStack { get; set; } = null!;
+
+            protected override void LoadComplete()
+            {
+                // exiting the current screen provokes the behaviour of unbinding all bindables in the screen's subtree
+                screenStack.CurrentScreen.Exit();
+
+                // ...but the following calls should still take correct effect inside `SliderBar`
+                // (namely one consisting of propagating `{Min,Max}Value` into `currentNumberInstantaneous`)
+                // so that it doesn't have its internal invariants violated
+                CurrentNumber.MinValue = -10;
+                CurrentNumber.MaxValue = 10;
+
+                // this notably calls `Scheduler.AddOnce(updateValue)` inside, which will happen *in the imminent future, in the same frame as `LoadComplete()` here.
+                // if the above mutations of `{Min,Max}Value` don't correctly propagate inside the slider bar due to an overly eager unbind, this will cause a crash.
+                base.LoadComplete();
+            }
+        }
+
+        private partial class BrokenScreen : Screen
+        {
+            [BackgroundDependencyLoader]
+            private void load()
+            {
+                InternalChild = new BrokenSlider();
+            }
+        }
+    }
+}

I attempted to address what I perceive to be the root issue here which
is that `ScreenStack` is allowed to arbitrarily unbind bindables under
drawables which are by all means still in the scene graph. The attempt
consisted of scheduling the unbind until after children of the screen
stack, but that caused 150 game-side tests to fail, seemingly on
something relevant to bindable leases, so I give up.

Bartłomiej Dach · 2026-01-23 13:07:42 +01:00

b7559f93f2

Fix broken percentage formatting in form slider bars

closes https://github.com/ppy/osu/issues/36428

this one's my bad:
https://github.com/ppy/osu/pull/36195#discussion_r2698388405

Bartłomiej Dach · 2026-01-23 08:01:41 +01:00

225f4d8814

Add failing tests

Bartłomiej Dach · 2026-01-23 07:50:20 +01:00

d80934c344

Merge branch 'master' into new-settings/overlay

Dean Herbert · 2026-01-22 18:38:17 +09:00

42302c45ec

Improve input handling in percentage-based slider bars (#36195 )

Reported in
https://github.com/ppy/osu/pull/36193#issuecomment-3703406223.

Preview:


https://github.com/user-attachments/assets/ac2b86cf-ad92-496b-b3dd-19ad47753a9b

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Salman Alshamrani · 2026-01-17 16:39:28 +09:00

676b7a36da

Update editor slider controls to new design (#36346 )

(partially) Closes: #36233
Surpasses: #36244 

This PR meant to be one of the last steps that finally make editor use
the new forms. Initially it meant to only change one
SliderWithTextBoxInput in "Effects section" in timing screen, however
soon after it was obvious that there's many other places that still
using it. This currently won't affect
IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
example, since I think it needs more consideration.
Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
all, as it's going to be replaced with modern FormSliderBar

Comparison:
|master|this PR|
|:---:|:---:|
|<img width="510" height="316"
alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
/>|<img width="540" height="321"
alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
/>|
|<img width="694" height="639"
alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
/>|<img width="720" height="433" alt="изображение"
src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
/>|
|<img width="715" height="353"
alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
/>|<img width="710" height="296" alt="изображение"
src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
/>|
|<img width="717" height="374"
alt="534509478-80222623-7766-481d-8682-088276d415ee"
src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
/>|<img width="718" height="328" alt="изображение"
src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
/>|
|<img width="702" height="446"
alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
/>|<img width="722" height="386" alt="изображение"
src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
/>|

De4n · 2026-01-16 20:08:52 +09:00

e05b6f44b9

Fix double-clicking form slider bar not propagating default to other bindables when TransferValueOnCommit is true (#36354 )

- Addresses https://github.com/ppy/osu/pull/36346#discussion_r2692322683

The inner slider bar binds its `Current` to
`currentNumberInstantaneous`:


https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L225-L236

But the current bindable of the form component doesn't update because of
this.


https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L285-L293

Fixed it by just moving the `ResetToDefault` action up another level.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Joseph Madamba · 2026-01-16 19:48:36 +09:00

a8ada50549

Update game settings to use new form controls

Salman Alshamrani · 2026-01-14 02:15:10 -05:00

e548cd40dc

Fix sliders not playing samples on adjust

Should've been true by default, minor mistake from a previous PR.

Salman Alshamrani · 2026-01-14 02:12:28 -05:00

8a581f5a90

Support text wrapping in form controls

Salman Alshamrani · 2026-01-05 16:13:56 -05:00

08364a7b97

Expose constant for max decimal digits display

Salman Alshamrani · 2025-12-23 06:14:48 -05:00

fa32be37d6

Seal tooltip text overrides

Salman Alshamrani · 2025-12-23 06:11:05 -05:00

e4d7bc3896

Make sound playback consistent across all disabled controls

Salman Alshamrani · 2025-12-23 05:56:17 -05:00

cb32d2da3e

Add label and tooltip formatting to form sliders

Salman Alshamrani · 2025-12-23 05:56:17 -05:00

4ee7e6f787

Update "disabled" visual feedback of form controls

Salman Alshamrani · 2025-12-23 05:56:17 -05:00

a2872ee870

Merge branch 'master' into form-slider-bar-disabled

Dean Herbert · 2025-12-22 23:44:33 +09:00

dbcc7cc09d

Adjust colour of inactive slider bar

Dean Herbert · 2025-12-22 22:06:39 +09:00

0787345a84

Move disable to better place

Bartłomiej Dach · 2025-12-22 10:04:29 +01:00

df524d68fd

Fix disabled form slider bars being half-baked

In order of severity:

- You could actually click on the textbox portion of a disabled textbox,
  focus it, select text, input stuff, and commit, which would die
  on the spot.

- The slider part had no visual indication that it's not interactable
  anymore.

Bartłomiej Dach · 2025-12-19 12:17:46 +01:00

ecc51d4701

Remove Value from {Is,Set}ValueDefault

Salman Alshamrani · 2025-12-18 05:50:35 -05:00

f5bd888078

Expose common interface for form controls

Salman Alshamrani · 2025-12-18 05:15:01 -05:00

729cd722bd

Add double-click-nub-to-reset function to form slider bars

See https://github.com/ppy/osu/pull/35742#issuecomment-3561517030.

Bartłomiej Dach · 2025-11-24 10:32:42 +01:00

9d88c761d3

Use new sliders-with-text-input in editor toolboxes

Addresses https://github.com/ppy/osu/discussions/35732.

And yes, I renamed "perfect curve threshold" to "bias" so that the text
can fit. Sue me.

Bartłomiej Dach · 2025-11-19 13:22:20 +01:00

4b59a4657f

Fix editor setup screen sliders not having correct keyboard steps

Closes https://github.com/ppy/osu/issues/32691.

Fixes some extra cases of failure that aren't pointed out in the issue.

Dean Herbert · 2025-04-08 14:45:43 +09:00

f2088496c5

Fix recent editor textbox regressions

Salman Alshamrani · 2025-01-20 03:17:01 -05:00

2b5ea4e6e0

Adjust slider bar implementations to show focused state

Dean Herbert · 2024-10-24 19:46:20 +09:00

6dd1efa013

Replace FormSliderBar.Instantaneous with TransferValueOnCommit

Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.

Bartłomiej Dach · 2024-10-04 14:07:16 +02:00

86c3e3e987

Fix improper handling of decimal separator in "form" number boxes / sliders

Spotted in passing in
https://discord.com/channels/188630481301012481/1097318920991559880/1291693852981329981.

Bartłomiej Dach · 2024-10-04 13:12:25 +02:00

45a6a743a2

Adjust slider bar padding

https://discord.com/channels/188630481301012481/188630652340404224/1291374650256916482

Bartłomiej Dach · 2024-10-03 14:32:46 +02:00

2c0a7d4c18

Make animation slightly more snappy

Dean Herbert · 2024-09-19 19:06:46 +09:00

ca8402d980

Implement TabbableContentContainer for slider control

Bartłomiej Dach · 2024-09-18 11:32:55 +02:00

d506d8a150

Keep slider bar looking active when dragging outside of its bounds

Bartłomiej Dach · 2024-09-18 11:30:52 +02:00

093d9ab076

Add missing xmldoc

Bartłomiej Dach · 2024-09-18 11:25:23 +02:00

0bab755be3

Make slider bar instantaneous by default (and fix broken implementation)

Bartłomiej Dach · 2024-09-18 11:23:00 +02:00

95e26e6fd8

Implement "form" slider bar control

Bartłomiej Dach · 2024-09-17 11:40:57 +02:00

1b17231da4

42 Commits