68664 Commits

This Branch

This Branch

All Branches

• Ensure the "Change Difficulty" menu uses up-to-date difficulty names

  Closes https://github.com/ppy/osu/issues/29391.

  Dean Herbert · 2024-08-15 17:25:30 +09:00
  b5f615882f
• Fix mistake
  Dean Herbert · 2024-08-15 16:44:15 +09:00
  4b279ecaa8
• Update MultiplayerClient test output with new knowledge
  Dean Herbert · 2024-08-15 16:16:48 +09:00
  26da2c0637
• Merge pull request #29415 from Joehuu/difficulty-name-content

  Implement song select v2 difficulty name content component

  Dean Herbert · 2024-08-15 15:20:52 +09:00
  9dc496d6a7
• Merge pull request #29426 from peppy/fix-dot-misalign

  Fix some characters ('.', ',') being misaligned in legacy counters

  Dan Balasescu · 2024-08-15 14:19:53 +09:00
  70cfac0eb8
• Use zero baseline for legacy sprite text display
  Dean Herbert · 2024-08-15 13:07:42 +09:00
  054366b25d
• Merge pull request #29406 from peppy/fix-skin-change-crash

  Fix crash on changing skins when classic mod is enabled and game is rewound

  Dan Balasescu · 2024-08-15 01:04:32 +09:00
  8bfb5cedc4
• Merge pull request #29417 from peppy/remove-main-menu-challenge-tooltip

  Remove daily challenge tooltip from main menu

  Dan Balasescu · 2024-08-14 22:30:56 +09:00
  a6aa35a9b8
• Update remaining tests to use new base class (and tidy up V2 suffixes)
  Dean Herbert · 2024-08-14 21:09:28 +09:00
  e603888130
• Fix failing test setup
  Dean Herbert · 2024-08-14 21:01:35 +09:00
  1665d9a93e
• Remove daily challenge tooltip from main menu

  Now that we have a nice intro screen for the daily challenge, it's
  generally thought that we want to "spoil" the beatmap until the intro is
  shown.
  
  Also I was never a huge fan of having a tooltip on a main menu button..
  just feels a bit odd.

  Dean Herbert · 2024-08-14 20:45:27 +09:00
  28ab65243d
• Merge pull request #29414 from smoogipoo/fix-daily-challenge-2

  Add localisation for daily challenge day/week units

  Dean Herbert · 2024-08-14 18:45:12 +09:00
  58d9a4adba
• Use Content override instead
  Joseph Madamba · 2024-08-14 00:44:03 -07:00
  6f2bc7e6f1
• Inline single-frame layout issue comment instead
  Joseph Madamba · 2024-08-14 00:41:43 -07:00
  11bd0c9a61
• Move other V2 tests to new test namespace
  Dean Herbert · 2024-08-14 15:51:07 +09:00
  2174510544
• Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent
  Joseph Madamba · 2024-08-13 23:26:18 -07:00
  c24f1444f9
• Move resizing width and background logic to SongSelectComponentsTestScene
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  f8796e3192
• Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  2b41f71fd0
• Implement song select v2 difficulty name content component
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  625c6fc7eb
• Add base song select components test scene
  Joseph Madamba · 2024-08-13 23:26:17 -07:00
  46d41cb590
• Add localisation for daily challenge day/week units
  Dan Balasescu · 2024-08-14 15:10:55 +09:00
  f882ad4a53
• Merge pull request #29412 from peppy/file-io-test-failure
  Dan Balasescu · 2024-08-14 13:06:14 +09:00
  6840f4bca4
• Fix file access test failure by forcing retries

  See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.

  Dean Herbert · 2024-08-14 12:26:21 +09:00
  dd9705b660
• Update test debug output to test second scenario
  Dean Herbert · 2024-08-14 12:23:47 +09:00
  78ef436ea0
• Merge pull request #29403 from smoogipoo/fix-catch-missing-objects

  Fix fruit positions getting mangled when exploded from the plate

  Dean Herbert · 2024-08-14 00:59:56 +09:00
  1b29b9bbb8
• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Add log output when judgements aren't being pooled
  Dean Herbert · 2024-08-13 20:57:23 +09:00
  bb0c9e2497
• Never call prepareDrawables from unsafe context

  I can't mentally figure out *what* is causing the issue here, but in the
  case where `prepareDrawables` is called from
  `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
  things go very wrong.
  
  I think a smell test is enough for anyone to agree that the flow was
  very bad. Removing this call doesn't seem to cause any issues.
  
  `runAnimation` should always be called in `PrepareForUse` (both pooled
  and non-pooled scenarios) so things should still always be in a correct
  state.
  
  Closes #29398.

  Dean Herbert · 2024-08-13 20:57:20 +09:00
  d74ac57092
• Merge pull request #29404 from frenzibyte/fix-user-profile-ux

  Fix user profile overlay colour resetting when selecting another ruleset

  Dan Balasescu · 2024-08-13 20:00:57 +09:00
  3753f65139
• Remove unused property causing CI inspection

  I don't see this in my Rider locally. I suppose we can remove it, though
  it was intentionally added so that the struct mirrors the interface.

  Dan Balasescu · 2024-08-13 19:52:14 +09:00
  69c5e6a799
• Add test coverage
  Salman Ahmed · 2024-08-13 13:07:21 +03:00
  7acc1772cb
• Fix user profile overlay colour resetting when changing rulesets
  Salman Ahmed · 2024-08-13 13:03:31 +03:00
  c9b2a5bb9c
• Fix fruit positions getting mangled when exploded
  Dan Balasescu · 2024-08-13 18:42:09 +09:00
  fbfe3a4887
• Add failing test
  Dan Balasescu · 2024-08-13 18:34:28 +09:00
  93c1a27f22
• Merge pull request #29402 from peppy/fix-recommender-test

  Fix occasional test failures in `TestSceneBetmapRecommendations`

  Dan Balasescu · 2024-08-13 18:25:01 +09:00
  50601544b3
• Fix occasional test failures in TestSceneBetmapRecommendations

  The game was being constructed befor the API was setup, which could mean
  depending on test execution ordering and speed, the recommendations
  array would not be filled.
  
  Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
  
  See https://github.com/ppy/osu/runs/28689915929#r0s0.

  Dean Herbert · 2024-08-13 17:28:16 +09:00
  14a00621f8
• Merge pull request #29401 from CloneWith/patch/wiki-locale

  Automatically use in-game language for wiki pages

  Dan Balasescu · 2024-08-13 17:18:29 +09:00
  513a666847
• Fix another test

  The last two PRs didn't interact well together.

  Dan Balasescu · 2024-08-13 17:18:11 +09:00
  58354e3e68
• Revert "Make ManiaAction start at 1"

  This reverts commit 952a73b005.

  Dean Herbert · 2024-08-13 16:38:56 +09:00
  4f37643780
• Enable NRT while we're here
  Dan Balasescu · 2024-08-13 16:08:06 +09:00
  3f02869bcc
• Make ManiaAction start at 1
  Dean Herbert · 2024-08-13 15:51:33 +09:00
  952a73b005
• Merge pull request #29342 from cl8n/remove-mania-action-special

  Remove "Special" `ManiaAction`s for center columns

  Dan Balasescu · 2024-08-13 15:36:36 +09:00
  4b4f0ecf7d
• Merge pull request #29388 from cl8n/fix-mania-replay

  Fix error on parsing osu!mania replays with 18 or more keys

  Dan Balasescu · 2024-08-13 15:29:53 +09:00
  cd76f474d8
• Reload wiki page on language change
  CloneWith · 2024-08-13 13:34:11 +08:00
  ca91726190
• Use key offsets instead of cast
  Dan Balasescu · 2024-08-13 14:03:26 +09:00
  12a1889fac
• Merge github.com:ppy/osu into patch/wiki-locale
  CloneWith · 2024-08-13 11:51:14 +08:00
  64468bce6d
• Get in-game locale for wiki pages
  CloneWith · 2024-08-13 11:50:33 +08:00
  7cbb4ab6f1
• Merge pull request #29372 from ArijanJ/song-progress-optional-time

  Add option to hide song progress time/text

  Dean Herbert · 2024-08-13 00:57:15 +09:00
  16f6e26c2e
• Merge pull request #29394 from peppy/fix-song-select-context-menu-click

  Fix context menus sometimes not being clickable at song select

  Bartłomiej Dach · 2024-08-12 14:31:30 +02:00
  acc7757582
• Fix context menus sometimes not being clickable at song select

  Closes https://github.com/ppy/osu/issues/21602.

  Dean Herbert · 2024-08-12 20:31:20 +09:00
  b567ab2a39