76148 Commits

This Branch

This Branch

All Branches

• Fix missing disposal
  Bartłomiej Dach · 2025-12-31 13:03:36 +01:00
  affe295f50
• Manually fire editor save operations on skin change

  This is invariably a test fix but also a valid change to make in
  isolation.
  
  In short, the problem is thus: Now that the beatmap skin is hooked up to
  realm to receive notifications about changed files (which is required
  for correctly handling custom samples), tests started failing, because
  of the following sequence of events
  
  - Saving a brand new `.osu` to a beatmap set causes
    `RealmBackedResourceStore` to fire subscription callbacks because a
    new file was added to the set
  - This fires `RealmBackedResourceStore.CacheInvalidated`
  - Which fires `EditorBeatmapSkin.BeatmapSkinChanged`
  - Which would previously fire `EditorBeatmap.SaveState()` and as such
    mark the beatmap dirty / modified.
  
  In this scenario this is gratuitous. There's no need to be raising save
  states here, a new `.osu` was added to the set that is in a consistent
  saved state and nothing actually changed in the beatmap.
  
  However it does not appear sane to attempt to circumvent this with
  conditional guards or something, because in cases where files are
  added/removed from the set, *there isn't really any reason to take save
  states anyway*. The change handler only deals with the `.osu`, any
  modifications to any of the other files cannot be undone anyway.
  
  Therefore, only keep the state save to the one change to beatmap skin
  that *can* actually be sanely undone which is changing combo colours.

  Bartłomiej Dach · 2025-12-31 12:14:32 +01:00
  28a6d6211c
• Add way to add/remove custom beatmap samples to setup screen

  Among others, this features a scary-looking change wherein
  `WorkingBeatmap` now exposes a `RealmAccess` via
  `IStorageResourceProvider`. This is necessary to make
  `RealmBackedResourceStore` actually start firing callbacks when the
  edited beatmap's skin is modified by adding new samples to it.

  Bartłomiej Dach · 2025-12-31 12:14:28 +01:00
  334a54e6f7
• Merge pull request #36162 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2025-12-30 08:59:18 +01:00
  57cbe20c12
• Merge pull request #36113 from diquoks/localisation/settings

  Localise various strings in settings

  Bartłomiej Dach · 2025-12-30 07:35:22 +01:00
  646e6de5df
• Fix iOS compilation
  Dean Herbert · 2025-12-30 01:27:08 +09:00
  3c084c60aa
• Merge pull request #36161 from peppy/editor-no-smooth-seeking

  Change editor to not seek smoothly when performing distant seeks

  Bartłomiej Dach · 2025-12-29 12:43:45 +01:00
  2025.1229.0-tachyon 3b9b030aad
• Update framework
  Dean Herbert · 2025-12-29 20:18:18 +09:00
  d421678d34
• Move "Random" string to UserInterfaceStrings
  Denis Titovets · 2025-12-29 14:12:02 +03:00
  056d832371
• Merge pull request #36114 from diquoks/localisation/play-v2

  Localise various strings on `Play` screen (again)

  Bartłomiej Dach · 2025-12-29 11:57:33 +01:00
  4e83814d5a
• Merge pull request #36159 from peppy/fix-now-playing-overlay-weird

  Fix a couple of edge cases when interacting with the now playing overlay using keyboard control

  Bartłomiej Dach · 2025-12-29 10:22:43 +01:00
  6bf25d700c
• Merge pull request #36158 from peppy/reduce-audio-debounce-time

  Reduce audio seek debounce time downwards

  Bartłomiej Dach · 2025-12-29 10:08:50 +01:00
  5163b8f5f3
• Change editor to not seek smoothly when performing distant seeks

  This reverts to the way stable does things. Smooth seeking is nice and
  all, but slows things down and doesn't give the instant reponse that
  mappers are used to.
  
  This should fix some performance issues regarding seeking as it no
  longer tries to render large portions of the map during the seek
  operation.
  
  Note that I've also forced the summary timeline to always non-smooth
  seek. It was bugging out in weird ways when doing smooth seeks and I
  don't want to attempt to fix it.

  Dean Herbert · 2025-12-29 17:44:03 +09:00
  8347f83f9c
• End christmas
  Dean Herbert · 2025-12-29 16:07:14 +09:00
  f3fa1122c2
• Fix double seek when using keyboard with now playing overlay seek bar
  Dean Herbert · 2025-12-29 16:04:24 +09:00
  0f018988b5
• Fix now playing overlay responding to key events when seek bar is not visually focused
  Dean Herbert · 2025-12-29 16:04:08 +09:00
  4a60d7fe71
• Reduce audio seek debounce time downwards

  I found this way too high in the editor, not giving enough feedback when
  seeking.
  
  To recap, this was put in place to avoid glitchy sounding audio. Such
  glitchiness only occurs with *very* fast seeks. This is still well
  within sane range.

  Dean Herbert · 2025-12-29 16:03:20 +09:00
  69250b3260
• Merge pull request #36140 from nbvdkamp/add-fps-settings-keywords

  Add keywords to FPS related settings

  Dean Herbert · 2025-12-27 23:11:58 +09:00
  ef3338ba93
• Add keywords to FPS related settings
  Nathan van der Kamp · 2025-12-27 00:29:25 +01:00
  99b00ab72f
• Revert "Merge pull request #36102 from bdach/move-check-to-better-place"

  This reverts commit 2cb2167765, reversing
  changes made to 0bcb3c5839.

  Dean Herbert · 2025-12-26 22:36:16 +09:00
  56ef5eae14
• Merge pull request #36102 from bdach/move-check-to-better-place

  Perform online ID checks during import in more proper sequence

  Dean Herbert · 2025-12-26 22:35:02 +09:00
  2cb2167765
• Merge pull request #36103 from bdach/form-sample-set

  Implement form control for adding/removing custom samples in editor

  Dean Herbert · 2025-12-25 15:11:33 +09:00
  0bcb3c5839
• Merge pull request #36116 from frenzibyte/new-settings/form-visuals

  Prepare form controls for use in settings

  Dean Herbert · 2025-12-25 03:16:12 +09:00
  2acc2a84db
• Merge pull request #36118 from bdach/zip-magic
  Dean Herbert · 2025-12-25 02:29:18 +09:00
  64d16776be
• Merge pull request #36121 from smoogipoo/mp-fix-availability-tracker

  Fix potentially incorrect online play beatmap availability

  Dean Herbert · 2025-12-24 20:32:46 +09:00
  2d06c2b1a6
• Reduce code duplication

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-12-24 19:30:04 +09:00
  81f03957d8
• Fix tests
  Dan Balasescu · 2025-12-24 16:53:08 +09:00
  ecaf3e05d4
• Fix tournament screens not having colour provider cached
  Salman Alshamrani · 2025-12-24 02:22:59 -05:00
  2d85fe8133
• Fix potentially incorrect online play beatmap availability
  Dan Balasescu · 2025-12-24 15:08:37 +09:00
  0af07b97c5
• Adjust naming
  Dean Herbert · 2025-12-24 14:57:17 +09:00
  03f44705b3
• Update switch button visuals
  Salman Alshamrani · 2025-12-23 20:18:59 -05:00
  033a73e969
• Merge pull request #36101 from bdach/guest-difficulty-export

  Add explicit menu item for exporting guest difficulties from editor

  Dean Herbert · 2025-12-24 00:45:19 +09:00
  1340e18d93
• Fix offset not changing using current culture
  Denis Titovets · 2025-12-23 14:51:31 +03:00
  43e217120d
• Make edits based on reviews
  Denis Titovets · 2025-12-23 14:36:12 +03:00
  dc53198577
• Make setter protected to fix build error
  Salman Alshamrani · 2025-12-23 06:31:26 -05:00
  95cf050298
• Make edits based on reviews
  Denis Titovets · 2025-12-23 14:27:34 +03:00
  0bfff2bf88
• Expose constant for max decimal digits display
  Salman Alshamrani · 2025-12-23 06:14:48 -05:00
  fa32be37d6
• Seal tooltip text overrides
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  e4d7bc3896
• Add explanatory note
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  520baf6c50
• Revert unintended change
  Salman Alshamrani · 2025-12-23 06:11:05 -05:00
  a1d4d44151
• Fix tests not having colour providers
  Salman Alshamrani · 2025-12-23 05:58:57 -05:00
  a3a5b2ca92
• Make sound playback consistent across all disabled controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  cb32d2da3e
• Add label and tooltip formatting to form sliders
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  4ee7e6f787
• Add right margin to form dropdown chevron
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c2c1fa4d4c
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Update "disabled" visual feedback of form controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  a2872ee870
• Add extra form controls in test scene
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c6a8d9a150
• Merge pull request #36081 from bdach/esdfiopj

  Fix cursor scale affecting trail spacing

  Dean Herbert · 2025-12-23 19:48:34 +09:00
  6eec2b0ff8
• Merge pull request #36047 from bdach/reveal-other-difficulties-thing

  Add ability to view other beatmaps in set when difficulties are split apart

  Dean Herbert · 2025-12-23 19:43:47 +09:00
  0999e3f048
• Merge pull request #36056 from peppy/fix-stacking-woes

  Fix osu! stacking not matching stable in very specific edge cases

  Bartłomiej Dach · 2025-12-23 08:45:40 +01:00
  71386fe465