35 Commits

• Ensure online ID has a valid online value before preferring it
  Dean Herbert · 2025-04-23 18:21:17 +09:00
  1488a49dae
• Remove online ID equality TODO and add explanation as to why it's not required
  Dean Herbert · 2025-04-23 18:13:13 +09:00
  73773aa69a
• Maintain selection using OnlineID as a priority
  Dean Herbert · 2025-04-23 18:01:49 +09:00
  414150e9e0
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Add basic support for beatmap updates in BeatmapCarousel
  Dean Herbert · 2025-04-22 20:03:07 +09:00
  6f97667889
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Reduce spacing in new beatmap carousel
  Dean Herbert · 2025-03-25 17:21:35 +09:00
  31487545d0
• Use alternative method of offsetting X that conveys flow better
  Dean Herbert · 2025-03-04 19:40:31 +09:00
  21d35f9dae
• Add transition for selecting a beatmap
  Dean Herbert · 2025-03-04 18:09:58 +09:00
  1be3b990e7
• Add basic subclassing and implement beatmap-start flow
  Dean Herbert · 2025-03-04 17:44:48 +09:00
  f0d6641adf
• Rename classes for better discoverability / grouping
  Dean Herbert · 2025-02-12 19:34:42 +09:00
  554884710c
• Merge pull request #31823 from peppy/carousel-v2-optimisation-pass

  Refactor grouping to be much more efficient

  Bartłomiej Dach · 2025-02-07 10:44:53 +01:00
  a068d88b84
• Refactor grouping to be much more efficient
  Dean Herbert · 2025-02-07 16:35:20 +09:00
  9d979dc3f4
• Merge branch 'master' into carousel-v2-spacing
  Dean Herbert · 2025-02-07 14:34:59 +09:00
  1cf375e329
• Avoid double iteration when updating group states
  Dean Herbert · 2025-02-06 17:22:50 +09:00
  bff686f012
• Refactor selection and activation handling

  I had a bit of a struggle getting header traversal logic to work well.
  The constraints I had in place were a bit weird:
  
  - Group panels should toggle or potentially fall into the prev/next
    group
  - Set panels should just traverse around them
  
  The current method of using `CheckValidForGroupSelection` return type
  for traversal did not mesh with the above two cases. Just trust me on
  this one since it's quite hard to explain in words.
  
  After some re-thinking, I've gone with a simpler approach with one
  important change to UX: Now when group traversing with a beatmap set
  header currently keyboard focused, the first operation will be to reset
  keyboard selection to the selected beatmap, rather than traverse.
  
  I find this non-offensive – at most it means a user will need to press
  their group traversal key one extra time.
  
  I've also changed group headers to always toggle expansion when doing
  group traversal with them selected.
  
  To make all this work, the meaning of `Activation` has changed somewhat.
  It is now the primary path for carousel implementations to change
  selection of an item. It is what the `Drawable` panels call when they
  are clicked.
  
  Selection changes are not performed implicitly by `Carousel` – an
  implementation should decide when it actually wants to change the
  selection, usually in `HandleItemActivated`.
  
  Having less things mutating `CurrentSelection` is better in my eyes, as
  we see this variable as only being mutated internally when utmost
  required (ie the user has requested the change). With this change,
  `CurrentSelection` can no longer become of a non-`T` type (in the
  beatmap carousel implementation at least).
  
  This might pave a path forward for making `CurrentSelection` typed, but
  that comes with a few other concerns so I'll look at that as a
  follow-up.

  Dean Herbert · 2025-02-06 17:02:44 +09:00
  024fbde0fd
• Expose set grouping state
  Dean Herbert · 2025-02-06 14:30:15 +09:00
  88ad87a78e
• Add support for grouping by artist
  Dean Herbert · 2025-02-05 19:48:41 +09:00
  11de429621
• Support variable spacing between carousel items
  Salman Alshamrani · 2025-02-05 05:20:26 -05:00
  fc5832ce67
• Add tracking of expansion states for groups and sets
  Dean Herbert · 2025-02-04 17:51:51 +09:00
  58560f8acf
• Fix null handling when no items are populated but a selection is made
  Dean Herbert · 2025-02-03 02:39:45 +09:00
  6a18d18feb
• Fix backwards traversal of groupings and allow toggling groups without updating selection
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  d74939e6e9
• Improve selection flow using early exit and invalidation
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  764f799dcb
• Add initial difficulty grouping support
  Dean Herbert · 2025-02-03 02:24:27 +09:00
  d5dc55149d
• Split out beatmaps and set panels into two separate classes
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  175eb82ccf
• Move activation drawable flow portion to ICarouselPanel
  Dean Herbert · 2025-01-24 18:40:48 +09:00
  9366bfbf0d
• Simplify selection handling logic
  Dean Herbert · 2025-01-23 23:58:51 +09:00
  f4270ab3b9
• Add regions to BeatmapCarousel
  Dean Herbert · 2025-01-23 23:53:09 +09:00
  d5369d3508
• Add selection and activation flow
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  2f94456a06
• Only show loading when doing a user triggered filter
  Dean Herbert · 2025-01-23 15:51:54 +09:00
  d526835627
• Add loading overlay and refine filter flow
  Dean Herbert · 2025-01-14 20:23:53 +09:00
  900237c1ed
• Add animation and depth control
  Dean Herbert · 2025-01-14 20:12:09 +09:00
  cc8941a94a
• Add difficulty, artist and title sort examples

  Also:
  
  - Adds hinting at grouping and header status of items
  - Passes through criteria and prepare for grouping tests.
  - Makes `Filters` list `protected` because naming clash with `Filter()`
    on `BeatmapCarousel`.

  Dean Herbert · 2025-01-14 19:52:48 +09:00
  7e8a80a0e5
• Split out BeatmapCarousel classes and drop V2 suffix
  Dean Herbert · 2025-01-14 19:18:02 +09:00
  d97a3270a5