94 Commits

• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Stop loudly logging backwards seek bug to sentry

  Several users have reported stutters when this happens. It's potentially
  from the error report overhead. We now know that this is a BASS level
  issue anyway, so having this logging is not helpful.

  Dean Herbert · 2024-11-30 21:01:22 +09:00
  1e2e364cd3
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Apply required changes after framework masking updates
  Dan Balasescu · 2024-05-09 20:18:53 +09:00
  3b8b56cbcb
• Never set waitingOnFrames if a replay is not attached
  Dean Herbert · 2024-03-06 04:37:11 +08:00
  65ce4ca390
• Log backwards seeks to sentry
  Dean Herbert · 2024-03-01 12:40:05 +08:00
  19ed78eef5
• Add comprehensive log output to help figure out problematic clocks
  Dean Herbert · 2024-02-29 23:05:28 +08:00
  cc8b838bd4
• Add flag to allow backwards seeks in tests
  Dean Herbert · 2024-02-29 23:05:28 +08:00
  4184a5c1ef
• Add logging when workaround is hit
  Dean Herbert · 2024-02-29 18:27:50 +08:00
  3a780e2b67
• "Fix" tests
  Dean Herbert · 2024-02-29 18:21:44 +08:00
  3355764a68
• Disallow backwards seeks during frame stable operation when a replay is not attached
  Dean Herbert · 2024-02-29 14:15:32 +08:00
  76e8aee9cc
• Merge branch 'master' into frame-stable-catchup-zoom
  Bartłomiej Dach · 2024-01-22 10:37:06 +01:00
  77ef12ebb0
• Allow FrameStabilityContainer to continue updating while paused during replay playback
  Dean Herbert · 2024-01-18 20:13:28 +09:00
  e73910571f
• Remove redundant RequiresChildrenUpdate usage

  We are already manually calling `base.UpdateSubTree` when we need to.
  Changing this flag is doing nothing and just adds to the complexity of
  the implementation.

  Dean Herbert · 2024-01-18 20:13:28 +09:00
  2afa4c7e1c
• Change frame stable catch-up method to allow for much faster sync
  Dean Herbert · 2024-01-18 14:01:37 +09:00
  c362a93a36
• Update clocks in line with framework changes
  Dean Herbert · 2023-09-20 21:17:08 +09:00
  bf984388b3
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 19:08:42 +09:00
  2e98ab0a48
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into kps
  Dean Herbert · 2022-09-08 23:00:36 +09:00
  d4afc3629c
• Change FrameStableClock to inherit IGameplayClock
  Dean Herbert · 2022-09-08 18:24:18 +09:00
  6729bb3e1a
• Rename GameplayAdjustments -> AdjustmentsFromMods
  Dan Balasescu · 2022-09-08 17:14:06 +09:00
  b559d4ecdf
• Apply proposed changes to remove inheritance from MasterGameplayClockContainer
  Dean Herbert · 2022-09-07 17:49:05 +09:00
  75d0deef72
• Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  bc1212f4e6
• Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?
  Dean Herbert · 2022-09-05 23:38:22 +09:00
  44b456e216
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-23 17:36:06 +09:00
  ec61a94dc9
• Fix editor crashing on mobile releases
  Dean Herbert · 2022-08-22 15:57:24 +09:00
  19bba143ee
• Fix `GameplayClockContainer potentially resetting external seeks
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  2c6fd1ec6e
• Merge branch 'even-less-gameplay-clock' into even-nicer-frame-stability-clock
  Dean Herbert · 2022-08-15 20:22:30 +09:00
  43442dbf65
• Fix IsCatchingUp not being in correct state
  Dean Herbert · 2022-08-15 20:17:48 +09:00
  87760bbc06
• Seal FrameStabilityContainer

  No one should ever derive from this class. It is already too complex.

  Dean Herbert · 2022-08-15 19:31:02 +09:00
  1fc3d005c0
• Tidy up and document FrameStabilityContainer
  Dean Herbert · 2022-08-15 19:28:12 +09:00
  fff2b57905
• Fix incorrect handling of reference clocks when no parent IGameplayClock is available
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  9bc2e91de0
• Remove unnecessary setClock shenanigans
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  828b6f2c30
• Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  27569e2ed5
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Add non-null assertion to FrameStabilityContainer
  Dean Herbert · 2022-08-15 18:08:49 +09:00
  95c1b488a7
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Avoid changing frame stable clock direction if time hasn't changed between frames
  Bartłomiej Dach · 2021-10-11 21:39:48 +02:00
  56eae703fe
• Move initial state set inside updateClock
  Dean Herbert · 2020-10-30 20:39:25 +09:00
  b4e5311014
• Move clock logic back to inside updateClock method
  Dean Herbert · 2020-10-30 20:21:14 +09:00
  1bd461f229
• Fix direction and IsRunning not updating on first frame after becoming valid

  The parent clock will not unpause until WaitingForFrames becomes false,
  so I've moved the set of that before we start to propagate its values
  across. Doesn't fix any visible issue but should make propagation one
  game loop faster.

  Dean Herbert · 2020-10-30 15:26:23 +09:00
  0f997386ae
• Fix loop not exiting after first valid frame
  Dean Herbert · 2020-10-30 15:25:53 +09:00
  326fd03525
• Avoid running full updateClock loop when waiting on frames
  Dean Herbert · 2020-10-30 12:39:11 +09:00
  8e6c803900
• Merge branch 'master' into spectator-replay-watcher
  Dean Herbert · 2020-10-30 00:25:17 +09:00
  87be7d162b
• Fix aim time being mutated inside update loop
  Dean Herbert · 2020-10-29 18:11:50 +09:00
  335d150a13
• Move clock retrieval to new correct location
  Dean Herbert · 2020-10-29 15:28:39 +09:00
  2671d371da
• Avoid sourcing parent clock when in a paused state
  Dean Herbert · 2020-10-29 14:48:56 +09:00
  db2b00068f
• Move initial validity check out of loop for clarity
  Dean Herbert · 2020-10-29 14:25:47 +09:00
  d91456dc29