osu-lazer

Convert gameplay leaderboard to skinnable component

This PR converts the leaderboard into a full-fledged skinnable component
that can be manipulated by users at will.

Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
be fixed - although it's a very mixed bag, for several reasons:

- Because of taiko players' refusal to see reason^W^W^W^Winsistence on
  keeping stable behaviours related to aspect ratio treatment, I have to
  assume the worst case scenario, which means than on typical
  resolutions like 16:9 (or even worse, 4:3), the leaderboard will
  likely not occupy as much vertical space as it probably could.

- Additionally, there's the problem of where to put the spectator list.
  I settled on putting it to the right of the leaderboard, but that's
  kind of janky, because the leaderboard sometimes collapses and
  sometimes fully hides, leading to a very awkward space left behind. If
  we had the capability to anchor elements to other elements, maybe this
  could be resolved, but for now, I'm not sure what to do. I think if
  some users are bothered by it they can move it where they want it. Or
  delete it.

Bartłomiej Dach · 2025-04-24 13:10:30 +02:00

59b826c321

Minor fix to the description text

Shavixinio · 2025-04-22 19:49:34 +02:00

3b2382ceb0

Fix slider repeat arrows appearing too early in editor when hit markers are enabled

Closes https://github.com/ppy/osu/issues/32880

Broke in conjunction with https://github.com/ppy/osu/pull/32638 because
of transforms not being applied to `DrawableSliderRepeat` but its
individual pieces instead.

In cross-checking with stable (visual only) the early fade in of the
arrow should still apply, it just shouldn't be instantaneous as is
currently ends up being with how the code is structured.

Bartłomiej Dach · 2025-04-21 10:00:22 +02:00

78d9bd7fb4

Merge pull request #32772 from frenzibyte/beatmap-statistic-bars

Introduce numeric data in beatmap object count statistics

Bartłomiej Dach · 2025-04-14 13:32:31 +02:00

9e112bc16b

Don't include spinner types in note sums

Dean Herbert · 2025-04-14 19:21:36 +09:00

3d47a2b5b2

Rename new property to better explain visual-only usage

Dean Herbert · 2025-04-14 18:38:04 +09:00

f05a50f4e1

Combine "spinnable time" conditions

Dan Balasescu · 2025-04-14 17:45:15 +09:00

80d9f742da

Fix "spins per minute" shows up early #31173

Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.

Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

Rudi Herouard · 2025-04-13 23:35:44 +02:00

7cdbc2c20a

Introduce numeric value in beatmap hit count statistics

Salman Alshamrani · 2025-04-12 00:14:53 +09:00

85556e0c3e

Shorten beatmap hit statistics names

Salman Alshamrani · 2025-04-11 02:33:57 +09:00

1dbcbbde15

Merge pull request #32732 from peppy/vertex-selection-increase

Increase range of vertex selection in polygon generation popover

Bartłomiej Dach · 2025-04-08 09:07:49 +02:00

b1b8601105

Increase range of vertex selection in polygon generation popover

Addresses https://github.com/ppy/osu/discussions/32703.

Dean Herbert · 2025-04-08 15:26:41 +09:00

e990099cd9

Fix editor setup screen sliders not having correct keyboard steps

Closes https://github.com/ppy/osu/issues/32691.

Fixes some extra cases of failure that aren't pointed out in the issue.

Dean Herbert · 2025-04-08 14:45:43 +09:00

f2088496c5

Merge pull request #32638 from peppy/fix-slider-repeat-fade

Fix slider repeat arrow fade in length not matching expectations

Bartłomiej Dach · 2025-04-07 13:04:06 +02:00

c921a2362a

Add back clamping of animation durations on slider repeat runs

Dean Herbert · 2025-04-03 18:32:02 +09:00

6d1fc0e235

Fix argon reverse arrow animating weirdly after hit

Dean Herbert · 2025-04-03 17:41:13 +09:00

bb8a9c8345

Adjust again to be closer to stable

Dean Herbert · 2025-04-03 17:25:42 +09:00

4cd2e5ba25

Syncrhonise tranforms between arrow and circle pieces

Dean Herbert · 2025-04-03 15:49:15 +09:00

f9ceb59d70

Fix slider repeat arrow fade not matching expectations

Dean Herbert · 2025-03-31 17:15:25 +09:00

acc5790b74

Change SettingDescription to differentiate between settings and values

Salman Alshamrani · 2025-03-23 13:43:26 -04:00

6e635f124a

Move BeatmapVersion from BeatmapInfo to IBeatmap

Closes https://github.com/ppy/osu/issues/32420.

The failure cause here is that in editor the beatmap version for the
beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
probably a regression from https://github.com/ppy/osu/pull/32315, but
like... can we universally agree that calling that change "a regression"
in any capacity is dumb? Like what was that code *doing* playing dumb
reference games and copying stuff into an arbitrary instance that could
get or not get used later on? And now you have a 50/50 chance of
accessing the *correct* model's field, depending on whether you go via
`BeatmapInfo` or `Beatmap.BeatmapInfo`?

Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
and materialised" beatmap, fixes this issue.

I probably should have done this as part of
https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
for the better too because this change has rather large chances of
breaking stuff so maybe better to examine it in isolation (via diffcalc
runs or whatever).

For added humour points, you'd say that the field on `BeatmapInfo` was
not `[Ignore]`d, so this is a realm schema change, right? No. As far as
I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
a listed column` on `Beatmap` models.

I'm also not gonna get into the fact that I think `EditorBeatmap` doing
dumb games with juggling two `BeatmapInfo` references since
https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
have the mental capacity to hotfix this by going down that train of
thought.

Bartłomiej Dach · 2025-03-17 15:04:48 +01:00

91f3be5fea

Add explanation of why the logic is in such a bad place

Dean Herbert · 2025-03-12 16:56:16 +09:00

c2de43f677

Fix new combo being toggled when selection is made

Dean Herbert · 2025-03-12 16:52:51 +09:00

6a7a834151

Merge branch 'master' into editor-right-click-as-people-expect

Dean Herbert · 2025-03-12 14:51:28 +09:00

083979e299

Fix edge case allowing almost-zero-length sliders to be placed during distance snapping

Dean Herbert · 2025-03-11 16:17:44 +09:00

23891b1994

Allow grid spacing setting up to 256 pixels

Addresses https://github.com/ppy/osu/discussions/29713.

I think there's valid uses of this apart from just hiding (ie values
between 128 and 256) so let's just get this in.

Dean Herbert · 2025-03-10 14:45:36 +09:00

bbd2c33934

Fix precise movement popover crashing if selection bounding box exceeds playfield size

Closes https://github.com/ppy/osu/issues/32252.

Bartłomiej Dach · 2025-03-07 09:38:14 +01:00

6d22502739

Bump difficulty calculator versions in preparation for release

Dean Herbert · 2025-03-06 16:05:51 +09:00

bdd2808fb5

Merge pull request #32158 from bdach/scaling-crash

Fix possible crash when scaling objects in editor

Dean Herbert · 2025-03-04 13:40:41 +09:00

3fe92fb83c

Mark MathHelper.Clamp() as banned API

See previous commit for partial rationale.

There's an argument to be made about the `NaN`-spreading semantics being
desirable because at least something will loudly fail in that case, but
I'm not so sure about that these days. It feels like either way if
`NaN`s are produced, then things are outside of any control, and chances
are the game can probably continue without crashing. And, this move
reduces our dependence on osuTK, which has already been living on
borrowed time for years now and is only awaiting someone brave to go
excise it.

Bartłomiej Dach · 2025-02-28 13:48:22 +01:00

35b0ff80bb

Fix possible crash when scaling objects in editor

The specific fail case here is when `s.{X,Y}` is 0, and
`s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
`0 * Infinity` is `NaN`.

`MathHelper.Clamp()` is written the following way:

	https://github.com/ppy/osuTK/blob/af742f1afd01828efc7bc9fe77536b54aab8b419/src/osuTK/Math/MathHelper.cs#L284-L306

`Math.{Min,Max}` are both documented as reporting `NaN` when any of
their operands are `NaN`:

	https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
	https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)

which means that if a `NaN` happens to sneak into the bounds, it will
start spreading outwards in an uncontrolled manner, and likely crash
things.

In contrast, the standard library provided `Math.Clamp()` is written
like so:

	https://github.com/dotnet/runtime/blob/577c36cee56480dec4d4610b35605b5d5836888b/src/libraries/System.Private.CoreLib/src/System/Math.cs#L711-L729

With this implementation, if either bound is `NaN`, it will essentially
not be checked (because any and all comparisons involving `NaN` return
false). This prevents the spread of `NaN`s, all the way to positions
of hitobjects, and thus fixes the crash.

Bartłomiej Dach · 2025-02-28 13:34:00 +01:00

ffef6ae185

Fix sliders not being selectable if the body is hidden but the head is still visible

Closes https://github.com/ppy/osu/issues/31998.

Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
https://github.com/ppy/osu/pull/31923.

Oh input handling, how I love ya.

Bartłomiej Dach · 2025-02-27 15:00:29 +01:00

5b318edbfb

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-27 00:08:43 +09:00

87b6dddd11

Add back right-click-for-new-combo and right-click-delete when in compose mode

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird
that there's no way to check the current composition tool from a higher
level.

Also it was discussed IRL that there should be some kind of hinting that
existing notes will be deleted when they are hovered, but I'm not sure
how well this will work in normal mapping flows, since it will display
even in cases that users aren't intending to delete an object. Still
willing to explore this direction though (it's just non-trivial to
implement so I haven't yet).

Dean Herbert · 2025-02-26 17:52:33 +09:00

2738c1a807

Merge pull request #32077 from bdach/double-click-difficulty-slider-nub

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

Dean Herbert · 2025-02-25 21:08:46 +09:00

b3965f0dd0

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

- Closes https://github.com/ppy/osu/issues/31888
- Supersedes / closes https://github.com/ppy/osu/pull/32060

Bartłomiej Dach · 2025-02-25 07:40:55 +01:00

1f562ab47d

Fix "use current distance snap" button incorrectly factoring in last object with velocity

Closes https://github.com/ppy/osu/issues/32003.

Bartłomiej Dach · 2025-02-21 12:52:59 +01:00

de78518fea

Merge pull request #31923 from peppy/fix-editor-slider-selection

Fix selected sliders sometimes not being clickable in editor

Dan Balasescu · 2025-02-18 14:31:44 +09:00

cef1d02f3d

Merge pull request #31232 from Plextora/sudden-death-feat

Add "Fail when missing on a slider end" option in Sudden Death mod

Dean Herbert · 2025-02-18 14:25:46 +09:00

f5bdbb91d6

Fix selected sliders sometimes not being clickable in editor

Closes https://github.com/ppy/osu/issues/31918.
Regressed with
https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02
for obvious reasons.

Dean Herbert · 2025-02-18 13:41:30 +09:00

77e40140e5

Refactor slightly

Dean Herbert · 2025-02-18 13:04:38 +09:00

20dbe096e0

Fix nudge operations incurring FP error from coordinate space conversions

Closes https://github.com/ppy/osu/issues/31915.

Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.

To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.

Bartłomiej Dach · 2025-02-17 15:21:07 +01:00

f37a56c307

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-17 11:59:14 +09:00

ab88ccb081

Merge branch 'master' into sudden-death-feat

Plextora · 2025-02-16 19:43:55 -05:00

cb012123ab

Fix failed scores with no hits on beatmaps with ridiculous mod combinations showing hundreds of pp points awarded (#31741 )

See
https://discord.com/channels/188630481301012481/1097318920991559880/1334716356582572074.

On `master` this is actually worse and shows thousands of pp points, so
I guess `pp-dev` is a comparable improvement, but still flagrantly
wrong. The reason why `pp-dev` is better is the `speedDeviation == null`
guard at the start of `computeSpeedValue()` which turns off the rest of
the calculation, therefore not exposing the bug where
`relevantTotalDiff` can go negative. I still guarded it in this commit
just for safety's sake given it is clear it can do very wrong stuff.

Bartłomiej Dach · 2025-02-14 14:52:05 +00:00

4e66536ae8

Fix weird follow circle display when rewinding through sliders in editor

Closes https://github.com/ppy/osu/issues/31812.

Dean Herbert · 2025-02-12 16:33:23 +09:00

84b5ea3dbf

Avoid binding directly to DHO's bindable

Dean Herbert · 2025-02-12 16:28:14 +09:00

f97708e6b3

Rename ParentObject to DrawableObject

It's not a parent. The follow circle is directly part of the slider
itself.

Dean Herbert · 2025-02-12 16:14:12 +09:00

ffd8bd7bf4

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-10 18:07:07 +09:00

afdcf40d7e

Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735 )

* Calculate hit windows in performance calculator instead of databased difficulty attributes

* Apply mods to beatmap difficulty in osu! performance calculator

* Remove `GreatHitWindow` difficulty attribute for osu!mania

* Remove use of approach rate and overall difficulty attributes for osu!

* Remove use of hit window difficulty attributes in osu!taiko

* Remove use of approach rate attribute in osu!catch

* Remove unused attribute IDs

* Code quality

* Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

James Wilson · 2025-02-07 19:21:12 +09:00

9f90ebb2f7

6280 Commits