120 Commits

• Fix incorrect parsing of BSpline curve types
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  3d094f84ad
• Use static BEZIER instead of allocating new every time
  Bartłomiej Dach · 2023-11-20 13:35:07 +09:00
  80a3225bb2
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Replace sample bank fix with more correct fix

  stable does not treat unknown enum members as `None` / `Auto`, it treats
  them as `Normal`:
  
      switch (sampleSet)
      {
          case SampleSet.Normal:
          default:
              sample = 0;
              break;
          case SampleSet.None:
          case SampleSet.Soft:
              sample = 1;
              break;
          case SampleSet.Drum:
              sample = 2;
              break;
      }
  
      (from https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/Audio/AudioEngine.cs#L1158-L1171).

  Bartłomiej Dach · 2023-09-19 13:53:49 +02:00
  c4a0ca326e
• Default to none bank if invalid samplebank is specified
  sw1tchbl4d3 · 2023-09-13 12:44:00 +02:00
  5b2af7f264
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Fix weird optional usage in HitSampleInfo.With
  Dean Herbert · 2023-05-17 14:11:52 +09:00
  510ebe1f23
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• fix legacy parser incorrectly assigning sample info for sliders
  OliBomby · 2023-04-29 23:51:49 +02:00
  ffcc8e91b2
• Always add to additions soundbank in convertSoundType
  sw1tchbl4d3 · 2023-02-09 22:27:52 +01:00
  f0d11f44fc
• Rename some pieces and better document SampleBankInfo
  Dean Herbert · 2022-10-25 14:55:33 +09:00
  da93849b80
• Manual #nullable processing
  Dan Balasescu · 2022-06-17 16:38:35 +09:00
  fd9902e816
• Fix Catmull slider parsing with duplicate initial point
  Dan Balasescu · 2022-05-24 11:47:42 +09:00
  9259aa94f1
• Don't merge adjacent legacy Catmull segments
  Dan Balasescu · 2022-05-18 17:16:24 +09:00
  731f0960ec
• Add comment regarding equality check importance in LegacyHitSampleInfo
  Dean Herbert · 2022-03-23 20:18:44 +09:00
  c079a9cd32
• Revert "Remove IsLayered from LegacyHitSampleInfo comparison"

  This reverts commit 4523393208.

  Dean Herbert · 2022-03-23 20:15:17 +09:00
  997c091a8d
• Revert "Remove IsLayered from GetHasCode implementation"

  This reverts commit 16ee6b5fc7.

  Dean Herbert · 2022-03-23 20:15:13 +09:00
  2ea9e5245c
• Remove IsLayered from GetHasCode implementation
  Dean Herbert · 2022-03-14 18:12:04 +09:00
  16ee6b5fc7
• Remove IsLayered from LegacyHitSampleInfo comparison

  The equality of samples is generally used to compare the sample
  equality, not its full properties. For instance, we don't compare
  `Volume` in the base implementation.
  
  Having `IsLayered` here breaks actual usages of equality, ie. for
  pooling purposes.

  Dean Herbert · 2022-03-14 17:19:48 +09:00
  4523393208
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Merge pull request #15255 from goodtrailer/node-samples-ilist

  Change IHasRepeats.NodeSamples to IList from List

  Dean Herbert · 2021-10-28 14:24:26 +09:00
  5c7623e68e
• Merge branch 'master' into fix-skin-layout-editor-crash
  Dean Herbert · 2021-10-28 06:24:24 +09:00
  add39fbd4f
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Remove SkinConfiguration subclasses and allow configuration parsing for all skin types
  Dean Herbert · 2021-10-22 14:42:23 +09:00
  93482414d6
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Fix last control point starting new segment
  smoogipoo · 2021-04-05 17:49:36 +09:00
  4b29d0ebe2
• Update HasFlag usages to HasFlagFast
  smoogipoo · 2021-02-25 15:38:56 +09:00
  dff1d80f39
• Rename parameters
  smoogipoo · 2020-12-02 10:55:48 +09:00
  2150cf1c52
• Fix potentially incorrect override
  smoogipoo · 2020-12-02 10:54:26 +09:00
  e19ef9627a
• Volume should be 0 by default
  smoogipoo · 2020-12-01 18:14:14 +09:00
  2840405112
• Fix bad equality comparer implementations
  smoogipoo · 2020-12-01 18:13:53 +09:00
  6b4a6c12c8
• Remove unused method
  smoogipoo · 2020-12-01 17:02:45 +09:00
  4900589af4
• Implement equality comparers for HitSampleInfo
  smoogipoo · 2020-12-01 16:04:08 +09:00
  199710b941
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Use char overloads for string methods
  Berkan Diler · 2020-10-16 11:52:29 +02:00
  fe3a23750c
• More/better commenting
  smoogipoo · 2020-10-12 19:22:34 +09:00
  372761a46f
• Fix implicit segments not being constructed correctly
  smoogipoo · 2020-10-12 19:16:37 +09:00
  eb4ef157ca
• Fix multi-segment sliders not parsing correctly
  smoogipoo · 2020-10-12 18:04:28 +09:00
  48c0ae40ef
• Fix slider samples being overwritten by the last node
  smoogipoo · 2020-10-09 20:50:09 +09:00
  696e3d53af
• Merge GlobalSkinConfiguration settings into the LegacySetting enum
  Salman Ahmed · 2020-07-29 10:35:51 +03:00
  5439099b7c
• Mark normal-hitnormal sample as layered
  Bartłomiej Dach · 2020-06-22 20:08:29 +02:00
  c5049b51c5
• Fix incorrect xmldoc
  Dean Herbert · 2020-05-31 22:39:03 +09:00
  e688033967
• Move sett from EndTime to Duration
  Dean Herbert · 2020-05-27 12:37:44 +09:00
  b8e0a6f127
• Remove suffix hackery
  smoogipoo · 2020-04-14 21:33:32 +09:00
  44981431c5
• Improve logic for CSB transfer
  smoogipoo · 2020-04-14 21:05:07 +09:00
  6935221463
• Fix fallback for file hit samples
  smoogipoo · 2020-04-13 20:09:17 +09:00
  58a7313091