125 Commits

• style: remove usage of HIT_FLOURISH

  Unaware clueless usage

  tsrk · 2023-09-01 21:02:43 +02:00
  a4e146ad9b
• fix(AudioCheckUtils): use Path.GetExtension()

  To avoid filename escaping

  tsrk · 2023-09-01 20:56:54 +02:00
  2e2dcd99a6
• style: convert to using declaration for less nesting
  tsrk · 2023-09-01 20:54:02 +02:00
  5f00d3e2a4
• fix(AudioCheckUtils): add license header
  tsrk · 2023-08-29 23:27:15 +02:00
  5ecd5142d8
• fix: issue template typo in CheckDelayedHitsounds
  tsrk · 2023-08-29 20:15:33 +02:00
  b3d432b0d5
• style: move common audio utils to separate static class
  tsrk · 2023-08-29 20:10:35 +02:00
  c1a7ad09b4
• fix: use using statement for waveform auto-disposal
  tsrk · 2023-08-29 19:46:19 +02:00
  a7a64b57e9
• style: use HitSampleInfo.All properties
  tsrk · 2023-08-29 19:42:37 +02:00
  a04333c17b
• style(editor/checks): add issues for delays with no silence
  tsrk · 2023-08-25 11:46:09 +02:00
  29a46f5b36
• style: use more rigorous hitsound filtering
  tsrk · 2023-08-25 00:37:45 +02:00
  4c32e9a479
• revert: use old wording

  This makes more sense wrt to the complete silence thing.
  
  Refs: f7599c5b

  tsrk · 2023-08-24 23:52:41 +02:00
  50dbf564a5
• style: reword
  tsrk · 2023-08-24 23:41:56 +02:00
  f7599c5bc4
• style: typo
  tsrk · 2023-08-24 23:25:42 +02:00
  273593a0ee
• style(editor/checks): add type nullability for Stream
  tsrk · 2023-08-24 21:33:54 +02:00
  208e94e9be
• style(editor/checks): fix inconsistent argument names
  tsrk · 2023-08-24 21:31:28 +02:00
  df55a2f683
• feat(editor/checks): check for delayed hitsounds

  I really just borrowed the implementation from MapsetVerifier

  tsrk · 2023-08-24 21:05:40 +02:00
  a885bf6ebf
• Add helper method to get drain length (and rename some usages)
  Dean Herbert · 2023-07-25 16:58:41 +09:00
  9cfe9164fa
• Do not reimplement binary sort manually
  Bartłomiej Dach · 2023-07-22 17:12:21 +02:00
  699b66be42
• Change check to use binary search
  NiceAesth · 2023-07-20 00:32:35 +03:00
  fa29c25097
• Rename variables, fix check message formatting
  NiceAesth · 2023-07-17 20:48:53 +03:00
  ff529d9df7
• Add break length and bounds checks
  NiceAesth · 2023-07-16 23:03:21 +03:00
  3888471148
• Account for break time
  NiceAesth · 2023-07-11 13:40:19 +03:00
  1dae1d8f0a
• Add beatmap minimum length checks
  NiceAesth · 2023-07-10 17:29:49 +03:00
  9a2915f423
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Refactor IWorkingBeatmap.Background to GetBackground()
  Dean Herbert · 2023-06-08 16:19:32 +09:00
  a842f79ad4
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Fix typo in missing-preview-point message
  Dean Herbert · 2023-02-02 14:34:59 +09:00
  5b3d7a8f26
• Fix message not reading well
  Dean Herbert · 2023-02-02 14:33:41 +09:00
  c2cde8361a
• Remove multiple cases of excess braces
  Dean Herbert · 2023-02-02 14:28:21 +09:00
  3a861fd943
• Consistent with BeatmapsetVerifier
  cdwcgt · 2023-02-01 11:52:14 +08:00
  76296eb35a
• change IssueTemplatePreviewTimeConflict's text
  cdwcgt · 2023-01-23 15:26:28 +09:00
  5afb733fb2
• add check for preview time setting
  cdwcgt · 2023-01-19 01:08:37 +09:00
  e5eab72aeb
• Use empty string instead of null because issue template not accept null.
  andy840119 · 2022-10-30 16:31:07 +08:00
  a1a9238bd1
• File name should be nullable.
  andy840119 · 2022-10-30 16:29:54 +08:00
  505ec800da
• Remove nullable disable annotation in some checks class.
  andy840119 · 2022-10-30 16:28:49 +08:00
  db48a57fa7
• Remove nullable disable annotation in the issue and issue template-related class.
  andy840119 · 2022-10-30 16:25:15 +08:00
  24c27e62f6
• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Move StoragePath implementation to an extension method
  Dean Herbert · 2021-11-19 16:08:38 +09:00
  59e763467f
• Properly dispose of Stream in bg quality check
  Naxesss · 2021-11-10 05:06:11 +01:00
  b888185799
• Fix another case of incorrect null checking in editor verification processing
  Dean Herbert · 2021-11-04 15:18:10 +09:00
  e43d91ad5d
• Fix another couple of cases of incorrect string null/empty checking
  Dean Herbert · 2021-11-04 14:22:28 +09:00
  1e73b09e57
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Merge branch 'master' into file-sanity-checks
  Bartłomiej Dach · 2021-10-14 00:17:29 +02:00
  c7db286b94
• Refactor to use scoped using (and also correctly dispose TagLib portion)
  Dean Herbert · 2021-10-12 10:46:26 +09:00
  82f7f99f37
• Dispose of video resource later

  We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.

  Naxesss · 2021-10-12 00:40:39 +02:00
  f2f97602f2