8621 Commits

• Merge branch 'master' into fix-results-f-rank
  Bartłomiej Dach · 2024-02-05 13:05:37 +01:00
  ad69259eb8
• Use better test step name
  Bartłomiej Dach · 2024-02-05 13:05:28 +01:00
  989e46c791
• Merge pull request #26934 from bdach/which-mods-for-pp

  Display which mods grant pp

  Dean Herbert · 2024-02-04 19:15:11 +08:00
  c64d414d1b
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Add test coverage of full account creation flow
  Bartłomiej Dach · 2024-02-02 07:25:07 +01:00
  091618db1a
• Add unranked indicator to song select footer too
  Bartłomiej Dach · 2024-02-01 21:51:41 +01:00
  865f4d76ff
• Transform score multiplier display to also show ranked state
  Bartłomiej Dach · 2024-02-01 21:32:37 +01:00
  966093f7ce
• Add step for toggling skins in results screen test scene
  Salman Ahmed · 2024-02-01 16:08:48 +03:00
  6ab8960fdc
• Merge branch 'master' into fix-results-f-rank
  Salman Ahmed · 2024-02-01 15:29:07 +03:00
  35c3f5e250
• Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score

  Fix score processor no longer applying results when failing in multiplayer match

  Dean Herbert · 2024-01-29 19:51:31 +09:00
  a1fe5eedd5
• Merge pull request #25480 from peppy/2fa

  Add two factor authentication flow

  Dean Herbert · 2024-01-29 19:14:55 +09:00
  cbbe2f9dc0
• Fix more nullable inspections
  Bartłomiej Dach · 2024-01-29 08:44:27 +01:00
  a41ba7c381
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Move solution to multiplayer flow instead
  Salman Ahmed · 2024-01-28 00:42:04 +03:00
  64b61108ad
• Fix TestSceneFailJudgement asserts no longer being correct
  Salman Ahmed · 2024-01-27 23:23:32 +03:00
  5f68999893
• Rename GameplayState.HasFailed to properly clarify its meaning
  Salman Ahmed · 2024-01-27 23:23:10 +03:00
  ea641bb8d2
• Add failing test case
  Salman Ahmed · 2024-01-27 23:22:56 +03:00
  d38779f962
• Add visual and failing test cases
  Salman Ahmed · 2024-01-27 01:45:39 +03:00
  2ccd0e3692
• Add basic testing of failure flow
  Bartłomiej Dach · 2024-01-26 11:17:32 +01:00
  a2e69d37e8
• Merge branch 'decouple-notification-websocket-from-chat' into 2fa
  Bartłomiej Dach · 2024-01-25 14:51:42 +01:00
  3d3506b906
• Merge pull request #26689 from myQwil/divisor_cycle

  Prevent custom divisor ranges from halting divisor preset cycling

  Dean Herbert · 2024-01-25 20:46:16 +09:00
  baaf33d995
• Add test coverage of hidden scores on accuracy circle
  Dean Herbert · 2024-01-25 15:02:44 +09:00
  f22bfa350a
• Prevent custom divisor ranges from halting preset cycling

  A custom divisor like 24 or 32 will result in a range containing
  many divisors that are already in the `Common` and `Triplets` presets.
  When this happens, it can become impossible to cycle between presets,
  because the preset can only be changed if the new divisor isn't already
  contained within the current preset's range.

  Mike Will · 2024-01-24 18:31:39 -05:00
  9e1c242713
• Fix nullability inspection
  Bartłomiej Dach · 2024-01-24 22:01:59 +01:00
  2f8747776e
• Merge pull request #26630 from peppy/s-rank-change

  Change S rank to require no miss

  Dean Herbert · 2024-01-24 13:27:40 +09:00
  b272d34960
• Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor
  Bartłomiej Dach · 2024-01-23 18:04:41 +01:00
  0d7834af5f
• Fix account creation overlay test not clearing second auth factor
  Bartłomiej Dach · 2024-01-23 17:00:16 +01:00
  d7e957087e
• Fix login overlay test not clearing second auth factor
  Bartłomiej Dach · 2024-01-23 17:00:14 +01:00
  d0d09a8657
• Merge branch 'master' into 2fa
  Bartłomiej Dach · 2024-01-23 16:51:23 +01:00
  2cfaa1c103
• Implement per-axis triangles clamping
  Andrei Zavatski · 2024-01-23 04:54:27 +03:00
  da992ccc55
• Adjust results screen to handle S->A rank adjustment when misses are present
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  83f9118b22
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA

  Fix score submission test failures due to checking audio playback validity (again)

  Dean Herbert · 2024-01-22 20:07:51 +09:00
  2ab0be7606
• Fix score submission test failures due to checking audio playback validity (again)

  As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
  
  In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
  enabling of validation of playback rate to `SubmittingPlayer` context,
  then surely I can remove the local override in the test scene, right?"
  
  Reader: Apparently I did not notice that `FakeImportingPlayer :
  TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
  the local override in the test scene.
  
  You could probably attempt to conjure up some excuse about deep
  inheritance hierarchies here but nah. Really just a failure to read
  on my behalf as usual.

  Bartłomiej Dach · 2024-01-22 11:15:42 +01:00
  9b2740f8a4
• Merge branch 'master' into frame-stable-catchup-zoom
  Bartłomiej Dach · 2024-01-22 10:37:06 +01:00
  77ef12ebb0
• Merge pull request #26605 from peppy/simplify-gameplay-pause

  Simplify gameplay pause sequence

  Bartłomiej Dach · 2024-01-22 08:49:08 +01:00
  493d495992
• Merge branch 'master' into update-framework
  Dean Herbert · 2024-01-21 13:49:44 +09:00
  3b7a47aded
• Rename Masking to ClampToDrawable
  Andrei Zavatski · 2024-01-21 05:20:42 +03:00
  1393f52b2b
• Add failing test case
  Salman Ahmed · 2024-01-18 14:24:49 +03:00
  22cfc86050
• Remove test guarantee of audio time not advancing
  Dean Herbert · 2024-01-18 20:06:53 +09:00
  c4e9bcd140
• Update IPC usages

  Of note, I've disabled IPC on visual test runners as we generally don't
  use IPC in these cases. Having it set means that the game will not open
  while visual tests are open, which has been a complaint from devs in the
  past.

  Dean Herbert · 2024-01-18 19:45:36 +09:00
  82e7643df5
• Simplify gameplay pause sequence
  Dean Herbert · 2024-01-18 14:17:19 +09:00
  799c74cfe5
• Add a fake load to visual test to restore previous testing behaviour
  Dean Herbert · 2024-01-18 14:01:37 +09:00
  fb4efd992d
• Change frame stable catch-up method to allow for much faster sync
  Dean Herbert · 2024-01-18 14:01:37 +09:00
  c362a93a36
• Merge pull request #26585 from frenzibyte/fix-editor-ux

  Fix timing point changes not applying after selecting another one

  Dean Herbert · 2024-01-17 19:53:35 +09:00
  6a8a45bb13
• Rename test method slightly
  Dean Herbert · 2024-01-17 19:53:23 +09:00
  1af5d1434c
• Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods

  Add guard against submitting score with invalid mod instances

  Bartłomiej Dach · 2024-01-17 11:39:32 +01:00
  5cb17bcacf
• Merge pull request #26340 from stanriders/user-rank-card

  Add user card with global/country ranks to login overlay

  Dean Herbert · 2024-01-17 17:22:33 +09:00
  ee18123fc2
• Fix android build CI failing

  No idea why this is only in android, but okay.

  Salman Ahmed · 2024-01-17 08:53:28 +03:00
  05729706eb
• Merge branch 'master' into drag-volume-controls
  Salman Ahmed · 2024-01-17 08:37:34 +03:00
  23e5167cb5