Salman Ahmed
846fd73ac9
Fix notification toast tray potentially hiding some notifications
2024-07-10 16:15:02 +03:00
Salman Ahmed
8ca8648a09
Add failing test case
2024-07-10 16:14:12 +03:00
Bartłomiej Dach
fa749d317e
Enable NRT on ManiaHitObjectComposer
2024-07-10 15:12:03 +02:00
Salman Ahmed
7d667ac46b
Fix confirm exit dialog overflowing from too many ongoing operations
2024-07-10 16:06:53 +03:00
Bartłomiej Dach
c8a64c5950
Remove setup screen controls that do nothing useful
...
Before I go with a hammer to redesign these, I want to remove stuff that
does nothing first.
Hard-breaks API to allow rulesets to specify an enumerable of custom
sections rather than two specific weird ones.
For specific rulesets:
- osu!:
- Stack leniency slider merged into difficulty section.
- osu!taiko:
- Approach rate and circle size sliders removed.
- Colours section removed.
- osu!catch:
- No functional changes.
- osu!mania:
- Special style toggle merged into difficulty section.
- Colours section removed.
2024-07-10 14:53:16 +02:00
Salman Ahmed
ce93455aa8
Extend behaviour to sample edit popover
2024-07-10 15:16:10 +03:00
Salman Ahmed
94f51c92e0
Select all text when focusing a number box
2024-07-10 15:16:10 +03:00
Bartłomiej Dach
d879527329
Merge pull request #28803 from peppy/fix-break-overlay-visuals
...
Fix break overlay progress bar becoming a pancake near end of break
2024-07-10 13:31:09 +02:00
Bartłomiej Dach
d9e285395d
Merge pull request #28802 from peppy/fix-download-progress-bar-visuals
...
Fix beatmap card progress bar becoming pancake when starting
2024-07-10 13:25:02 +02:00
Dean Herbert
b6741ee4ea
Fix back-to-front exit blocking conditionals
2024-07-10 20:00:34 +09:00
Dean Herbert
75344f9c5c
Fix break overlay progress bar becoming a pancake near end of break
2024-07-10 19:28:37 +09:00
Dean Herbert
6cee0210c3
Fix(?) xmldoc
2024-07-10 19:22:49 +09:00
Dean Herbert
1381b3c0c5
Merge pull request #28801 from bdach/break-generation-caching
...
Improve performance of automatic break regeneration
2024-07-10 19:21:16 +09:00
Dean Herbert
2ba1ebe410
Fix beatmap card progress bar becoming pancake when starting
2024-07-10 19:19:49 +09:00
Bartłomiej Dach
b881c25b17
Pool summary timeline break visualisations to reduce allocations
2024-07-10 11:42:28 +02:00
Bartłomiej Dach
343090e3b1
Do not regenerate breaks unless meaningful change to object start/end times is detected
...
Tangentially found when profiling https://github.com/ppy/osu/pull/28792 .
For reproduction, import https://osu.ppy.sh/beatmapsets/972#osu/9007 ,
move any object on the playfield, and observe a half-second freeze
when ending the drag.
2024-07-10 11:42:25 +02:00
Dean Herbert
704e7e843f
More xmldoc across new methods and classes
2024-07-10 18:34:48 +09:00
Dean Herbert
106d558147
Add test coverage of difficulty being retained
2024-07-10 18:34:47 +09:00
Dean Herbert
aa16c72e06
Add test coverage of external editing
2024-07-10 18:34:47 +09:00
Dean Herbert
72091b43df
Simplify editor navigation tests
2024-07-10 18:34:47 +09:00
Dean Herbert
3beca64cc5
Attempt to stay on correct difficulty
2024-07-10 18:34:46 +09:00
Dean Herbert
27ab54882b
Add loading segments and tidy things up
2024-07-10 18:34:46 +09:00
Dean Herbert
74aa05fa6e
Improve UX and styling of external edit screen
2024-07-10 18:34:45 +09:00
Dean Herbert
118162c631
Add sub screen to limit user interactions
2024-07-10 18:34:45 +09:00
Dean Herbert
d3c66e2404
Add basic flow for mounting beatmaps for external editing
2024-07-10 18:29:51 +09:00
Salman Ahmed
337f05f9a4
Fix loading (but not showing) a sheared overlay hiding displayed footer content
...
Identified by tests. See https://github.com/ppy/osu/actions/runs/9869382635/job/27253010485 & https://github.com/ppy/osu/actions/runs/9869382635/job/27253009622 .
This change also prevents the initial `PopOut` call in overlays from calling `clearActiveOverlayContainer`, since it's not in the update thread and it's never meant to be called at that point anyway (it's supposed to be accompanied by a previous `PopIn` call adding the footer content).
2024-07-10 11:56:35 +03:00
Salman Ahmed
f0a7a3f856
Add failing test case for edge case
2024-07-10 11:51:49 +03:00
Salman Ahmed
002679ebb0
Ask for VisibilityContainer explicitly
2024-07-10 11:14:22 +03:00
Bartłomiej Dach
95783bd6c2
Merge pull request #28789 from peppy/fix-deletes-reappearing
...
Fix deleted beatmap sets potentially reappearing due to pending update requests
2024-07-10 09:14:10 +02:00
Dean Herbert
9a88281ab0
Merge branch 'master' into footer-v2-integration
2024-07-10 15:33:05 +09:00
Dean Herbert
4fe3f39d22
Merge pull request #28682 from frenzibyte/footer-v2-overlay-content
...
Add implementation for `ScreenFooter` to house footer content of sheared overlays
2024-07-10 15:08:00 +09:00
Dean Herbert
cd9973b6f9
Merge pull request #28740 from bdach/daily-challenge/better-results
...
Improve results displays in daily challenge screen
2024-07-10 14:17:21 +09:00
Dean Herbert
9c1dcbcdda
Merge pull request #28796 from Joehuu/fix-preview-persisting-after-leaving
...
Fix preview track persisting to play after entering multi/playlists gameplay
2024-07-10 14:07:49 +09:00
Dean Herbert
f281019358
Rename method to match provided argument
2024-07-10 14:00:15 +09:00
Dean Herbert
4e1240c349
Migrate ShearedOverlayContainer to NRT
2024-07-10 13:54:27 +09:00
Joseph Madamba
8c81ba3357
Fix preview track persisting to play after leaving multi/playlists room
2024-07-09 14:36:24 -07:00
Bartłomiej Dach
9cc0e0137b
Snap to stack in osu! composer when dragging to any of the items on it
...
Previously it would be required to drag to the starting position of the
stack which feels weird.
2024-07-09 13:58:58 +02:00
Bartłomiej Dach
ec9040798f
Run stacking when performing movement in osu! composer
...
Closes https://github.com/ppy/osu/issues/28635 .
2024-07-09 13:52:36 +02:00
Dean Herbert
123d3d2ff8
Add similar special case for insert after removal
2024-07-09 20:44:55 +09:00
Dean Herbert
0e2e44a2f5
Add failing test case showing editor save then delete failure
2024-07-09 20:41:22 +09:00
Salman Ahmed
ed1f3a1eb4
Merge branch 'master' into footer-v2-integration
2024-07-09 13:48:40 +03:00
Salman Ahmed
b17af86491
Merge branch 'master' into footer-v2-overlay-content
2024-07-09 13:41:44 +03:00
Bartłomiej Dach
ca4c0aa7e2
Remove unused using
2024-07-09 10:57:21 +02:00
Bartłomiej Dach
13c8370823
Merge pull request #28786 from Joehuu/sort-direction-caret-transition
...
Add caret transition to beatmap listing sort tab items
2024-07-09 10:52:11 +02:00
Dean Herbert
920c0e4d25
Fix deleted beatmap sets potentially reappearing due to pending update requests
2024-07-09 17:08:26 +09:00
Dean Herbert
63b4327978
Ensure beatmap set is always detached when updating
...
Slight performance improvement by doing the detach as early as possible.
2024-07-09 17:08:25 +09:00
Bartłomiej Dach
877ade3053
Merge pull request #28787 from peppy/adjust-editor-fades
...
Adjust editor transparent tweens to be less "flashy"
2024-07-09 10:08:14 +02:00
Dan Balasescu
e734cdfee5
Merge pull request #28785 from peppy/fix-realm-callbacks
...
Ensure realm subscriptions always fire initial callback with null `ChangeSet`
2024-07-09 16:52:38 +09:00
Bartłomiej Dach
5d5dd0de00
Redesign bottom timeline pieces to match stable better
2024-07-09 09:25:22 +02:00
Bartłomiej Dach
29b8948609
Slim down bottom timeline
...
This removes the BPM display, which is commonly cited to have
no functional purpose by users, and reduces the height of the bottom bar
in exchange for more space for the playfield.
2024-07-09 09:25:22 +02:00
