383 Commits

• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix combo starting at 0 when spectating
  Dan Balasescu · 2022-06-06 17:56:25 +09:00
  6351f652a2
• Rename member
  Dan Balasescu · 2022-06-02 16:35:50 +09:00
  a638392e81
• Throw exception on access before ApplyBeatmap()
  Dan Balasescu · 2022-06-02 16:34:45 +09:00
  055845d4f5
• Use ScoreInfo overload in more places
  Dan Balasescu · 2022-06-02 11:01:46 +09:00
  e551e48697
• Refactor to reduce nested conditions
  Dan Balasescu · 2022-06-01 09:54:47 +09:00
  425390e13b
• Apply code reviews
  Dan Balasescu · 2022-06-01 09:54:47 +09:00
  50c3dfca31
• Expose MaximumScoringValues for user consumption
  Dan Balasescu · 2022-05-31 19:49:37 +09:00
  1e0ee1b214
• Rename field + rewrite xmldoc a bit
  Dan Balasescu · 2022-05-31 19:40:07 +09:00
  93240073a6
• Add overloads to + document + expose ExtractScoringValues
  Dan Balasescu · 2022-05-31 19:40:07 +09:00
  28d8799e11
• Fix unintentional truncation
  Dan Balasescu · 2022-05-31 19:40:07 +09:00
  d6d56ee22d
• Reset minimal scoring values from frames
  Dan Balasescu · 2022-05-31 19:40:07 +09:00
  44ca350822
• Fix incorrect value
  Dan Balasescu · 2022-05-31 19:40:07 +09:00
  20988be6bb
• Use new ComputeScore() overload in more cases
  Dan Balasescu · 2022-05-31 19:40:02 +09:00
  6ccdb61853
• Add method to compute score from ScoringValues
  Dan Balasescu · 2022-05-31 19:39:53 +09:00
  2289812801
• Remove getBonusScore()
  Dan Balasescu · 2022-05-31 19:39:42 +09:00
  a809a19eec
• Extract score statistics directly into ScoringValues
  Dan Balasescu · 2022-05-31 19:39:42 +09:00
  d0e3e50ca7
• Move raw ScoreProcessor values into ScoringValues struct
  Dan Balasescu · 2022-05-31 19:39:38 +09:00
  af0f934e1a
• Remove Ruleset parameter from ResetFromReplayFrame()
  Dan Balasescu · 2022-05-31 17:16:23 +09:00
  132c94c1b5
• Adjust minimum health targets to match osu-stable
  Dan Balasescu · 2022-05-17 19:24:51 +09:00
  5ad9692467
• Rename method to better reflect what it's doing
  Salman Ahmed · 2022-04-27 00:03:48 +03:00
  cccc9d7d39
• Fix HealthProcessor fail conditions not handling multiple invocations
  Salman Ahmed · 2022-04-26 23:27:03 +03:00
  31f64b1381
• Change score accuracy grading logic to be inclusive
  Salman Ahmed · 2022-04-26 04:55:27 +03:00
  7d32490198
• Simplify IncreasesCombo/BreaksCombo helper method implementation
  Salman Ahmed · 2022-03-18 17:18:42 +03:00
  8078a8c1f8
• Update ScoreProcessor to use new defined helper methods
  Salman Ahmed · 2022-03-18 15:22:53 +03:00
  5ec2d86c09
• Separate increase/break combo helper methods from AffectsCombo
  Salman Ahmed · 2022-03-18 15:22:01 +03:00
  fc576b1369
• Add safeguards around incorrect ruleset sources
  Dan Balasescu · 2022-03-15 09:20:32 +09:00
  3a6d254d1f
• Apply review suggestions
  Dan Balasescu · 2022-03-14 17:10:37 +09:00
  028750936c
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Nullable annotate classes
  Dan Balasescu · 2022-03-14 15:38:00 +09:00
  9cc7f70872
• Merge branch 'master' into scoreprocessor-rework
  Dan Balasescu · 2022-03-10 16:14:28 +09:00
  cf91353009
• Add per-ruleset score multipliers for classic scoring
  Dan Balasescu · 2022-03-10 10:26:09 +09:00
  c36badab4b
• Safeguard method against invalid invocation
  Dan Balasescu · 2022-03-08 22:30:44 +09:00
  6fd8b4d891
• Rework GetScore() method signatures + implementations

  Rename legacy-facing overload to mention as much

  Dan Balasescu · 2022-03-08 22:30:44 +09:00
  f1c40bd9ed
• Calculate classic score using total basic hitobject count
  Dan Balasescu · 2022-03-08 21:49:41 +09:00
  a8e99f1a95
• Remove GetStandardisedScore() proxy method
  Dan Balasescu · 2022-03-08 21:49:41 +09:00
  5b6b8d1fa9
• Add GetScore() overload with total hitobject count
  Dan Balasescu · 2022-03-08 21:49:41 +09:00
  6654977a7b
• Rename GetImmediateScore() as overload of GetScore()
  Dan Balasescu · 2022-03-08 21:49:40 +09:00
  2c382bd1d9
• Merge pull request #17157 from peppy/fix-statistics-json-serialisation

  Fix incorrect serialisation of submitted scores

  Dan Balasescu · 2022-03-08 20:20:31 +09:00
  a352a140bc
• Add IsBasic() and IsTick() extensions on HitResult
  Dan Balasescu · 2022-03-08 18:19:12 +09:00
  a172fc6cb8
• Add EnumMember naming to HitResult to allow for correct json serialisation
  Dean Herbert · 2022-03-08 17:58:37 +09:00
  589a40ca2d
• Fix CalculateAverageHitError throwing if there are zero HitEvents
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  7215f3f66b
• Add missing xmldoc
  Dean Herbert · 2022-02-28 19:14:43 +09:00
  159db38f8a
• Show hit error on results screen

  Leading up to implementation of "local offset", this feels like a good
  thing to have visible first and foremost.

  Dean Herbert · 2022-02-28 19:11:06 +09:00
  a41e1c80f1
• Ensure to not multiply by 0
  Dan Balasescu · 2022-02-21 17:19:35 +09:00
  c466d6df94
• Scale classic score by hitobject count
  Dan Balasescu · 2022-02-21 13:31:03 +09:00
  c3b365cf6b
• Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier"

  This reverts commit 252b945d3b, reversing
  changes made to a1b39a96cf.

  Dean Herbert · 2022-02-17 13:26:12 +09:00
  7307e68e9c
• Remove mod multipliers from being applied to scores
  Dan Balasescu · 2022-02-16 16:27:27 +09:00
  5dd9771c5f
• Add xmldoc for new ResetFromReplayFrame method
  Dean Herbert · 2022-02-01 16:52:53 +09:00
  0f83f77d2b
• Apply suggestion from review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2022-02-01 10:48:41 +09:00
  c50577e25f