146 Commits

• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Use slider snapping more liberally to match user expectations

  Previously the slider path length would be snapped using the current
  beat snap setting on *every* change of the slider path. As it turns out
  this is unexpected behaviour in some situations (e.g. when reversing a
  path, which is expected to preserve the previous duration, even though
  the slider may be technically "unsnapped" at that point in time due to a
  different beat snap setting being selected afterwards).

  Bartłomiej Dach · 2022-01-07 16:02:04 +01:00
  c09f6ee052
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Move public method up and add xmldoc to second public method
  Dean Herbert · 2021-12-23 14:13:57 +09:00
  b0df787b1a
• Select newly created control point
  Bartłomiej Dach · 2021-12-22 10:33:07 +01:00
  6330fa5dc5
• Fix right click deselecting clicked path piece with control held
  Bartłomiej Dach · 2021-12-22 08:55:26 +01:00
  e22745397d
• Fix selections including head not correctly dragging if not started from head
  Bartłomiej Dach · 2021-12-21 12:35:48 +01:00
  e715bff535
• Fix selecting control points without control not deselecting other selected points
  Bartłomiej Dach · 2021-12-20 22:41:24 +01:00
  5ef4e23335
• Fix releasing mouse after drag deselecting dragged point
  Bartłomiej Dach · 2021-12-20 22:41:23 +01:00
  bf8c87e9b7
• Implement drag operation for multiple path control points
  Bartłomiej Dach · 2021-12-20 21:29:57 +01:00
  d2417beeac
• Change control point piece selection logic to allow dragging multiple
  Bartłomiej Dach · 2021-12-20 21:18:38 +01:00
  a9408485cc
• Move slider path point drag handling to visualiser
  Bartłomiej Dach · 2021-12-20 20:56:06 +01:00
  b0ca82e1e5
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix missed cases of incorrect .Value usage

  Changing from `Bindable` to `Nullable` comes with its issues...

  Dean Herbert · 2021-08-26 14:02:57 +09:00
  17f6efc6fe
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Adapt to PlatformAction type change
  ekrctb · 2021-07-21 16:12:53 +09:00
  1bac471b49
• Update usages of IHasTooltip in line with framework localisation changes
  Bartłomiej Dach · 2021-06-25 19:10:04 +02:00
  50c27d2635
• Create base implementations of the two most common TernaryStateMenuItems
  Dean Herbert · 2021-05-20 19:34:53 +09:00
  df5970fab4
• Revert "Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling"

  This reverts commit 54fe10c82a.

  Dean Herbert · 2021-05-08 23:33:03 +09:00
  01d732bb65
• Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling
  Dean Herbert · 2021-05-07 10:36:03 +09:00
  54fe10c82a
• Fix slider input handling potentially being offset after composer area resize

  Closes https://github.com/ppy/osu/issues/12671.

  Dean Herbert · 2021-05-06 17:19:19 +09:00
  39067e6926
• Handle control point drag revert
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  2949a6bbdc
• Split out common logic into private method and add inline comment for future visitors
  Dean Herbert · 2021-04-13 15:35:57 +09:00
  fbc6fb8fc5
• Don't update path type once immediately
  Naxess · 2021-04-12 19:18:22 +02:00
  d9e3276d0e
• Carry over the previous path type
  Naxess · 2021-04-09 11:04:00 +02:00
  f64b2095bf
• Correct 4+ point perfect curves to Bezier
  Naxess · 2021-04-08 12:33:43 +02:00
  9a675a2219
• Fix index out of range possibility
  Naxess · 2021-04-08 11:46:00 +02:00
  be4520fe33
• Improve UX of selecting PerfectCurve
  Naxess · 2021-04-08 09:06:28 +02:00
  0341023d13
• Add path type menu change method
  Naxess · 2021-04-08 09:05:35 +02:00
  725edfcbf3
• Simplify slider path bindings

  Adds a slight performance overhead, but solves the memory leak and makes the code much easier to follow.

  Naxess · 2021-04-08 03:21:56 +02:00
  d6490899e2
• Convert pathTypes to local variable

  Not entirely sure what holds the reference to pathTypes now (the binding to`slider.Path.ControlPoints` maybe?), but this does seem to work still.

  Naxess · 2021-04-08 01:43:06 +02:00
  d1d56c636a
• Track path type changes for PointsInSegment
  Naxess · 2021-04-07 17:19:12 +02:00
  b8ab1c7682
• Check current point instead of start point

  Since each control point will call this when the path updates, the previous would correct the start segment 3 times instead of just once.
  
  This fixes that.

  Naxess · 2021-03-31 20:25:46 +02:00
  5022a78e80
• Move updatePathTypes to PathControlPointPiece

  Here we produce a local bound copy of the path version, and bind it to update the path type.
  
  This way, if the path version updates (i.e. any control point changes type or position), we check that all control points have a well-defined path.
  
  Additionally, if the control point piece is disposed of, the GB should also swoop up the subscription because of the local bound copy.

  Naxess · 2021-03-31 20:09:56 +02:00
  75b8f2535f
• Move bounding box logic to framework
  Naxess · 2021-03-26 04:42:46 +01:00
  51f0477df4
• Remove determinant limit

  This has since been added into the framework through https://github.com/ppy/osu-framework/pull/4302

  Naxess · 2021-03-25 17:38:55 +01:00
  ce9130ca50
• Add bounding box limit
  Naxess · 2021-03-24 17:25:28 +01:00
  9df059b01d
• Increase exterior threshold
  Naxess · 2021-03-24 05:55:34 +01:00
  e0240ab9d9
• Move path type correction

  This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.

  Naxess · 2021-03-24 03:02:19 +01:00
  4ae3eaaac6
• Simplify path type maintenance when dragging
  Naxess · 2021-03-24 02:57:47 +01:00
  0bcd38e661
• Update PointsInSegment when adding/removing points

  There was a bug where if you created a slider, moved the last point, and then added a point such that it became a PerfectCurve, it would fail to recover after becoming a Bezier.
  
  This fixes that.

  Naxess · 2021-03-24 02:56:32 +01:00
  5ee280f941
• Maintain path type when dragging/placing
  Naxess · 2021-03-22 15:59:06 +01:00
  067178e537
• Add tooltips for slider path nodes which aren't inheriting
  Dean Herbert · 2021-03-19 16:58:08 +09:00
  27c38db14d
• Give each type of slider path type a unique colour to help visually distinguish them
  Dean Herbert · 2021-03-19 14:00:26 +09:00
  5f31304d05
• Adjust namespace
  ekrctb · 2020-12-04 20:21:53 +09:00
  245be2c5ed
• Merge pull request #11024 from peppy/fix-slider-point-drag-offset

  Fix slider control point dragging not correctly accounting for drag deadzone

  Dan Balasescu · 2020-12-02 11:10:06 +09:00
  be3fed3072
• Scale slider control point display in line with circle size
  Dean Herbert · 2020-12-01 14:17:36 +09:00
  b256c54619