73387 Commits

This Branch

This Branch

All Branches

• Simplify test
  Salman Alshamrani · 2025-05-21 23:53:25 +03:00
  a8dc954efd
• Fix test not working due to incorrect setup
  Dean Herbert · 2025-05-22 04:54:03 +09:00
  08c8b6f17a
• Show loading spinner underneath user tags during transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  135fc47766
• Add test for metadata wedge loading transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  c23abe818c
• Merge pull request #33200 from frenzibyte/fix-song-select-test

  Fix song select tests not loading footer buttons with dependencies

  Dean Herbert · 2025-05-21 00:40:30 +09:00
  23bd1e5d72
• Merge pull request #33207 from frenzibyte/ssv2-hook-mod-to-selected-beatmap

  SongSelectV2: Hook mod select overlay to selected beatmap

  Dean Herbert · 2025-05-21 00:38:36 +09:00
  c5ec25358d
• Merge pull request #33205 from frenzibyte/carousel-disable-status-animation

  Disable status pill animation on carousel panels

  Dean Herbert · 2025-05-21 00:37:49 +09:00
  420a49b812
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Merge pull request #33202 from frenzibyte/hidden-beatmap-difficulties

  Fix hidden beatmap difficulties not handled in new carousel

  Dean Herbert · 2025-05-21 00:33:36 +09:00
  875414a47a
• Fix solo results screen tests better

  See 12b09586c7.

  Bartłomiej Dach · 2025-05-20 12:10:07 +02:00
  6a56ed1d3b
• Merge pull request #33199 from pe1agio/iss32064

  Fix inconsistent display of rotation in tooltip when dragging selection box rotation handles

  Bartłomiej Dach · 2025-05-20 12:02:08 +02:00
  687c0e5cc0
• Fix solo results screen test failure

  As spotted in https://github.com/ppy/osu/pull/33191/checks?check_run_id=42460062656
  
  Seems like just a bog-standard race. Could be reproduced via
  
  diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  index d11e7db178..1a594fd21b 100644
  --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  @@ -45,6 +45,8 @@ protected override async Task<ScoreInfo[]> FetchScores()
               if (Score.BeatmapInfo!.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending)
                   return [];
  
  +            await Task.Delay(5000).ConfigureAwait(false);
  +
               var criteria = new LeaderboardCriteria(
                   Score.BeatmapInfo!,
                   Score.Ruleset,

  Bartłomiej Dach · 2025-05-20 11:09:18 +02:00
  12b09586c7
• Merge pull request #33194 from bdach/mania-hold-rewind

  Fix hold notes getting incorrectly missed after rewinding gameplay

  Dan Balasescu · 2025-05-20 16:48:26 +09:00
  17819ba592
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Merge pull request #33115 from bdach/fix-snapping-to-loading-grid

  Fix distance snap grid being used before it's ready for use

  Dan Balasescu · 2025-05-20 12:46:39 +09:00
  e97c757084
• Hook mod select overlay to selected beatmap
  Salman Alshamrani · 2025-05-20 01:14:42 +03:00
  fc436553a8
• Merge branch 'master' into iss32064
  Nuno Pelágio · 2025-05-19 21:17:23 +01:00
  7893b885c5
• Fix hidden beatmap difficulties not handled in new carousel
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  ce1da54af4
• Add failing test case
  Salman Alshamrani · 2025-05-19 22:02:41 +03:00
  cc3aeca5a7
• Fix ppy#32064: Fixed Formatting.
  Nuno Pelagio · 2025-05-19 20:00:24 +01:00
  dc86b77f80
• Fix song select tests not loading footer buttons with dependencies
  Salman Alshamrani · 2025-05-19 20:45:24 +03:00
  5333221e71
• Merge pull request #33192 from peppy/fix-multiplayer-position-display-two-player

  Fix multiplayer position display looking wrong when player count is low

  Bartłomiej Dach · 2025-05-19 13:04:22 +02:00
  9d438bac29
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add failing test case
  Bartłomiej Dach · 2025-05-19 11:38:42 +02:00
  3d4763bdb5
• Fix case where there's only one player causing NaN

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-05-19 18:25:41 +09:00
  962ec3dca0
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Merge pull request #33189 from peppy/fix-clock-animation

  Fix analog clock animation not animating when hand crosses zero

  Bartłomiej Dach · 2025-05-19 09:39:45 +02:00
  34e5c7ee42
• Merge pull request #33178 from peppy/fix-footer-button-thing

  Fix footer buttons not restoring when exiting an already displayed screen

  Bartłomiej Dach · 2025-05-19 09:02:07 +02:00
  5ae39819b6
• Merge pull request #33162 from smoogipoo/photon-release

  Add "Tachyon" (unstable) release stream

  Dean Herbert · 2025-05-19 15:27:35 +09:00
  c339977e98
• Fix analog clock animation not animating when hand crosses zero

  Pointed out in
  [discord](https://discord.com/channels/188630481301012481/188630652340404224/1373836064313180200).

  Dean Herbert · 2025-05-19 15:08:15 +09:00
  8aedfb81ff
• Set isFirstRun flag on all operating systems
  Dean Herbert · 2025-05-19 14:55:51 +09:00
  9ad57162b0
• Revert release stream to Lazer on reinstall
  Dean Herbert · 2025-05-19 14:55:50 +09:00
  9927f6248f
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Remove song select background scale for now

  Based on some negative feedback which I can agree with.

  Dean Herbert · 2025-05-18 16:00:10 +09:00
  159a09fdc5
• Add confirmation dialog before switching to unstable release stream
  Dean Herbert · 2025-05-18 03:57:53 +09:00
  b6ce627bc7
• Change release strem name to tachyon
  Dean Herbert · 2025-05-18 01:35:28 +09:00
  06b61ed5f5
• Merge pull request #33148 from bdach/emit-important-replay-frames-on-judgements

  Emit important replay frames on every judgement

  Dean Herbert · 2025-05-17 23:41:12 +09:00
  8c053e856f
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Merge pull request #33161 from bdach/replay-decode-float-woes

  Fix possible replay playback inaccuracy with very large lead-in time

  Dean Herbert · 2025-05-17 12:31:38 +09:00
  6346cff380
• Merge pull request #33142 from frenzibyte/ssv2-score-opens-results

  SongSelectV2: Open results screen when clicking leaderboard scores

  Bartłomiej Dach · 2025-05-16 14:10:07 +02:00
  fdd489992c
• Add "Photon" release stream
  Dan Balasescu · 2025-05-16 21:03:07 +09:00
  2c4666c896
• Merge branch 'master' into ssv2-score-opens-results
  Bartłomiej Dach · 2025-05-16 13:23:38 +02:00
  ea55fa2703
• Fix code quality
  Bartłomiej Dach · 2025-05-16 13:23:05 +02:00
  4992e4e5e1
• Merge pull request #33160 from peppy/carousel-animation-fixes

  Fix multiple inconsistencies in beatmap carousel animations

  Bartłomiej Dach · 2025-05-16 13:20:56 +02:00
  31fe6e4ec0
• Merge pull request #33159 from peppy/song-select-v2-mod-reset-right-click

  SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Bartłomiej Dach · 2025-05-16 13:13:46 +02:00
  8f5d97157c
• Fix possible replay playback inaccuracy with very large lead-in time

  Closes https://github.com/ppy/osu/issues/22086
  
  While this *is* a case of aspire-tier breakage, I hesitate to dismiss it
  as wontfix, because the fix is somewhat easy, and probably results in
  better accuracy across the board.
  
  The issue in question here manifests when there is a significant amount
  of lead-in time, like what the beatmap linked in the aforementioned
  issue (https://osu.ppy.sh/beatmapsets/948643#osu/1981090) does.
  
  Both stable and lazer record replay frames using absolute timestamps,
  *but* the legacy replay format after the first frame uses time *deltas*,
  i.e. amounts of time elapsed since the previous frame. This means that
  the decoding process of the replay has to reconstruct absolute timestamps
  by doing cumulative summation starting from the first frame.
  
  When the very first frame has a timestamp that is very large in
  magnitude (say, like the negative 2 billion that the beatmap in question
  uses), this will lead to error if the cumulative summation is using
  floating point numbers, because it will be adding a small magnitude
  frame delta to a large magnitude cumulative absolute time. Which means
  that sometimes adding the frame delta to the cumulative time *will not
  change the cumulative time*, leading to the loss of time and thus replay
  de-synchronisation.
  
  Knowing that the legacy replay format only deals in integral time
  values, however, this can be circumvented by just using a large enough
  integral number type for the cumulative time tracking instead. I think
  `long` in this case can be safely used "large enough" for our purposes:
  
  	> Console.WriteLine(long.MaxValue);
  	9223372036854775807
  
  	9 223 372 036 854 775 807 ms equals 292 277 024,6269277149 years

  Bartłomiej Dach · 2025-05-16 12:52:49 +02:00
  56e17dd7ba
• Add failing test case
  Bartłomiej Dach · 2025-05-16 12:45:47 +02:00
  8854db0264
• Use larger offset to ensure depth is still backmost even with DepthLayer is in use
  Dean Herbert · 2025-05-16 19:08:54 +09:00
  bfc23c98f1
• Add test coverage of opening score from song select v2
  Dean Herbert · 2025-05-16 18:35:38 +09:00
  c642d06576
• Rename new song select interface to be more generic and add score presentation to it
  Dean Herbert · 2025-05-16 18:22:42 +09:00
  bc35b58db6