1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 16:07:25 +08:00
Commit Graph

8856 Commits

Author SHA1 Message Date
Dean Herbert
85827f83eb Perform a reload on objects when Refreshing them
Previously, it was possible for an object to be "refreshed" with a stale cached state from the current thread's context.

This ensures a check against the database is performed as well.

Resolves #1562.
2017-11-23 17:04:39 +09:00
Dean Herbert
1824540325 Schedule calls to correct thread
These could be fired from an async worker thread (for instance, maintenance operations).
2017-11-23 17:02:54 +09:00
Dean Herbert
f3a84a01da Update framework 2017-11-23 16:20:50 +09:00
Dean Herbert
288c21dfec Move TestCase descriptions to attributes
Depends on https://github.com/ppy/osu-framework/pull/1186.
2017-11-23 16:09:32 +09:00
FreezyLemon
18b0b77f0a Added requested changes. Mainly changing lambdas to direct function references. 2017-11-22 21:41:50 +01:00
FreezyLemon
7d428875b8 Changed LoadWrapper back to DelayedLoadWrapper and fixed the implementation (dependent on framework change, delay now in ctor) 2017-11-22 15:46:04 +01:00
Dan Balasescu
37c0772537
Merge pull request #1565 from peppy/readme-update
Update readme to mention using visualtests always forever
2017-11-22 19:57:32 +09:00
Dean Herbert
0af3aea716 Update framework 2017-11-22 19:38:12 +09:00
Dean Herbert
dd4bf285ab
Merge branch 'master' into readme-update 2017-11-22 19:35:45 +09:00
Aergwyn
e5dfe4ff2e Make error more verbose when beatmap import fails (#1537)
Add name of beatmap set to error message if import fails
2017-11-22 19:35:25 +09:00
Dean Herbert
5efdb2f42d
Merge pull request #1554 from peppy/async-beatmap-panels
Load beatmap carousel panels asynchronously
2017-11-22 19:23:16 +09:00
Dean Herbert
517a9ec40f
Merge branch 'master' into async-beatmap-panels 2017-11-22 19:05:42 +09:00
Dean Herbert
095cc44661
Merge pull request #1563 from peppy/fix-playback-control
Improve PlaybackContainer (and rename to PlaybackControl)
2017-11-22 19:00:25 +09:00
Dean Herbert
95275cd2ef
Merge branch 'master' into fix-playback-control 2017-11-22 18:49:25 +09:00
Dan Balasescu
01a88eb959
Merge pull request #1556 from peppy/working-beatmap-async-2
Add async load methods for WorkingBeatmap properties
2017-11-22 18:45:02 +09:00
Dan Balasescu
c7a6c90249
Merge branch 'master' into working-beatmap-async-2 2017-11-22 18:32:47 +09:00
Dan Balasescu
4cbdd97ed3
Merge branch 'master' into fix-playback-control 2017-11-22 18:21:35 +09:00
Dan Balasescu
00df32b6de
Merge pull request #1564 from Brayzure/final-hitobject-fail-fix
Fix results screen displaying after failing on the last hitobject
2017-11-22 18:19:30 +09:00
Dan Balasescu
7de10a5877
Fix invalid cast from noun to verb 2017-11-22 18:14:40 +09:00
Dean Herbert
5646ba4b24 Fix incorrect issues link 2017-11-22 14:04:32 +09:00
Dean Herbert
36027f8700 Update readme to mention using visualtests always forever 2017-11-22 13:54:55 +09:00
Brayzure
782a739370 Fix Results Screen After Failing Last Note
Fixes a bug where if you failed on the last hitobject, the AllJudged event will have already been invoked.
2017-11-21 23:00:00 -05:00
Dean Herbert
757bb6911e Fix license header from wrong project 2017-11-22 12:06:31 +09:00
Dean Herbert
36d45f633d Reorder methods 2017-11-22 11:57:09 +09:00
Dean Herbert
e3c5a599b6 Tidy some regressions 2017-11-22 11:36:29 +09:00
Dean Herbert
27fb598352 Update colours to match design 2017-11-22 11:34:54 +09:00
Dean Herbert
0f8499c580 Rename to PlaybackControl and add a TestCase 2017-11-22 11:22:46 +09:00
Dean Herbert
ff5404e57f Remove need for AlwaysPresent
Also self-contains the tab options inside the tab control.
2017-11-22 11:21:48 +09:00
Dean Herbert
855acc9401 Fix leading space before percent sign 2017-11-22 11:17:10 +09:00
Dean Herbert
c06d6d0bbb Rename weird method 2017-11-22 10:59:31 +09:00
Dean Herbert
461c8e8be0 Clean up state change logic 2017-11-22 10:55:06 +09:00
Dean Herbert
63d366ea4b Bindables should be readonly 2017-11-22 10:54:33 +09:00
FreezyLemon
1d41e7cc8a Removed newline at end 2017-11-21 20:15:42 +01:00
FreezyLemon
bf0184c06d One more small style fix 2017-11-21 19:34:01 +01:00
FreezyLemon
2203a84300 Small fixes and style corrections 2017-11-21 19:16:44 +01:00
FreezyLemon
fd7ac9b6fc Switched to the new LoadWrapper class for asynchronous loading (LoadComponentAsync not used here since it's not possible to call that method on a component that has not finished loading, and we're in the constructor where it would be called) 2017-11-21 16:18:32 +01:00
FreezyLemon
870807c265 Switched over to the new LoadWrapper class for all delayed loading. 2017-11-21 16:17:33 +01:00
FreezyLemon
a033eb46d3 Changed to LoadComponentAsync call instead of adding an AsyncLoadWrapper instance. 2017-11-21 16:12:23 +01:00
Dean Herbert
33936b0939
Merge branch 'master' into async-beatmap-panels 2017-11-21 23:33:15 +09:00
Dean Herbert
7c65048ae5
Merge pull request #1557 from miterosan/Fix_osu_crashing_when_an_unknown_ruleset_is_selected_in_the_config
Fix osu crashing if a invalid gamerule is given in the game.ini
2017-11-21 23:31:39 +09:00
Miterosan
b3b1f2018e Fix osu crashing if a invalid gamerule is given in the game.ini 2017-11-21 15:13:00 +01:00
Dean Herbert
5e70b7a9f7 Add async load methods for WorkingBeatmap properties 2017-11-21 22:34:53 +09:00
Dean Herbert
2603219350 Load beatmap carousel panels asynchronously 2017-11-21 22:30:09 +09:00
Dean Herbert
a0488b8219
Merge pull request #1553 from peppy/async-beatmap-properties
Fix early access to beatmap in LogoVisualisation
2017-11-21 20:24:44 +09:00
smoogipoo
6686fe9ecd Merge remote-tracking branch 'origin/master' into performance-calculator 2017-11-21 19:55:28 +09:00
smoogipoo
f9ad4b6acb Make categoryDifficulties return doubles to improve decimal accuracy 2017-11-21 19:55:09 +09:00
smoogipoo
decee415dd Calculate real AR based on PreEmpt time 2017-11-21 19:54:08 +09:00
Dean Herbert
aff217cd03 Fix early access to beatmap in LogoVisualisation
Missed this one..
2017-11-21 19:47:12 +09:00
Dean Herbert
790957e97e
Merge pull request #1551 from peppy/fix-info-wedge
Fix beatmap info wedge not displaying
2017-11-21 19:21:00 +09:00
smoogipoo
0f8d4a455a Merge remote-tracking branch 'origin/master' into performance-calculator 2017-11-21 19:18:06 +09:00