1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-05 10:23:20 +08:00
Commit Graph

70590 Commits

Author SHA1 Message Date
Dean Herbert
a719693d10
Fix one remaining method call 2024-11-29 21:21:05 +09:00
Dean Herbert
0e1b62ef85
Expose more migration helper methods
For use in https://github.com/ppy/osu-queue-score-statistics/pull/305.

Some of these might look a bit odd, but I personally still prefer having
them all in one central location.
2024-11-29 21:10:30 +09:00
Dean Herbert
58efed4ebe
Merge pull request #30915 from bdach/extension-checks
Centralise supported file extensions to one helper class
2024-11-29 20:55:28 +09:00
Bartłomiej Dach
5f092811cb
Use helper in one more place 2024-11-29 09:22:29 +01:00
Bartłomiej Dach
5a9127dfc6
Accidentally a word 2024-11-29 08:46:08 +01:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.
2024-11-29 08:42:45 +01:00
Salman Alshamrani
b71bccc42d
Merge pull request #30914 from peppy/dev-footer-pass
Simplify the dev footer display
2024-11-29 02:14:30 -05:00
Dean Herbert
b697ddc6db
Simplify the dev footer display 2024-11-29 15:32:35 +09:00
Dean Herbert
ca32720cbd
Merge pull request #30904 from frenzibyte/save-android
Work around Android CI workflow errors
2024-11-29 14:54:52 +09:00
Dean Herbert
276c37bcf7
Update framework 2024-11-29 13:47:56 +09:00
Dean Herbert
a67f7ea3fb
Merge branch 'master' into save-android 2024-11-29 13:46:53 +09:00
Salman Alshamrani
f664e97496
Merge pull request #30906 from Hiviexd/daily-challenge-tier-thresholds
Adjust daily challenge tier thresholds to match expectations
2024-11-28 18:36:31 -05:00
Salman Alshamrani
51bcde67aa Remove no longer required comment 2024-11-28 17:55:15 -05:00
Salman Alshamrani
078d62fe09 Fix weird default in test scene 2024-11-28 17:54:03 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds 2024-11-28 17:46:55 -05:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
6ed21229b7 update test 2024-11-28 12:49:48 +01:00
Hiviexd
66093872e8 Adjust daily challenge tier thresholds to match expectations 2024-11-28 12:49:30 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Bartłomiej Dach
d218c19799
Merge pull request #30852 from frenzibyte/fix-daily-challenge-leaderboard
Fix daily challenge results screen fetching scores beginning from the user's highest
2024-11-28 10:21:52 +01:00
Dean Herbert
c26c84ba45
Add test coverage governing new behaviour 2024-11-28 18:03:19 +09:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885.

We could also only null this on application, but this feels worse
because

- It would require local handling (potentially complex) in
  `BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
  potentially make future usage not possible due to being nulled in only
a very specific scenario.

One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard 2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Bartłomiej Dach
4314f9c0a9
Remove unused accessors 2024-11-28 09:22:08 +01:00
Salman Alshamrani
19e396f878 Fix android workflow not installing .NET 8 version 2024-11-27 23:46:21 -05:00
Dean Herbert
e0fdcaf523
Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility
Fix discord "view beatmap" button being shown when editing and hide identifiable information is set
2024-11-28 13:29:09 +09:00
Salman Alshamrani
24c0799680 Move beatmap ID lookup to UesrActivity 2024-11-27 16:54:51 -05:00
HenintsoaSky
c3ac6d7fe5
Delete changes.patch
oops
2024-11-27 10:22:30 +03:00
Dean Herbert
4fcc76270a
Ensure events are unbound on disposal as a safety 2024-11-27 15:46:55 +09:00
Dean Herbert
5260a401d4
Use RealmLive in SaveFailedScoreButton
This also optimises the manager classes to better support `Live` usage
where the managed object is already in a good state (ie. doesn't require
re-fetching).
2024-11-27 15:25:42 +09:00
Salman Alshamrani
dfbccc2144 Knock some sense into the playlists results screen implementation
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
aa3d3a6344
Remove unnecessary local subscription in BeatmapCarousel
Not sure why I left this around during the refactor. This is 100%
handled by the `DetachedBeatmapStore`.

Removing this subscription reduces overheads by a huge amount for users
with large beatmap databases. My hypothesis is that subscriptions are
more expensive based on **the number of results matching**. This one
matches almost every beatmap so removing it is a large win.
2024-11-27 14:24:57 +09:00
HenintsoaSky
a477bb7bfe Renaming of 'StarFountainEnabled' 2024-11-27 07:38:33 +03:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363 Fix epic code failure
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
HenintsoaSky
16d8b11385 A toggle for star fountains 2024-11-27 00:53:22 +03:00
HenintsoaSky
80a66085a9 rename and remove again 2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f Rename of the setting 2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae Add option to disable star fountain in gameplay 2024-11-27 00:13:32 +03:00
Joseph Madamba
a1a63608dd
Merge pull request #30865 from ItsShamed/xxx-add-localisation-support-for-menu-tip
Add localisation support for menu tip
2024-11-26 12:54:17 -08:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-26 12:13:08 -08:00
Joseph Madamba
f04862ea74
Edit one more word not using british english 2024-11-26 12:11:29 -08:00
Bartłomiej Dach
359cb71dd9
Merge pull request #30884 from peppy/fix-spinner-legacy-new-order-
Fix classic skin spinner's middle pieces displaying in the wrong order
2024-11-26 14:57:42 +01:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dan Balasescu
bd1f978138
Empty commit to fix CI 2024-11-26 21:35:24 +09:00
Bartłomiej Dach
c69d36dc96
Remove leftover [Solo] attribute 2024-11-26 12:40:49 +01:00