osu-lazer

Merge pull request #35682 from bdach/nom-nom-tasty-exceptions

Dean Herbert · 2025-11-14 19:36:09 +09:00

a593a40429

Alleviate song select post-filter update thread hitches by caching a model-to-carousel-item mapping (#35628 )

Bartłomiej Dach · 2025-11-13 23:21:14 +09:00

b64abbf1f5

Improve loading time of collection grouping mode (#35693 )

Supersedes / closes https://github.com/ppy/osu/pull/35687.

Implements idea from
https://github.com/ppy/osu/pull/35687#issuecomment-3520613982, except
without the additional record, because there's no need for it.

Co-authored-by: WitherFlower <maxime.barniaudy@gmail.com>

Bartłomiej Dach · 2025-11-13 14:10:24 +09:00

4265e72180

Move realm collection writes off of update thread (#35681 )

Probably closes https://github.com/ppy/osu/issues/35650.

Realm slow, episode 23894. I can't reproduce freezes as big as the video
in the issue is showing but 'realm slow' is 99% the culprit, because
affected user's database is not small.

Bartłomiej Dach · 2025-11-11 20:29:39 +09:00

cb9d9734d6

Fix skin layout deserialisation eating exceptions without logging

Because I just wasted 30 minutes trying to debug why a skin provided by
a user in an issue thread was failing to deserialise, only to realise
halfway through that the deserialisation error I was seeing was *from
the fallback path and thus a complete red herring*.

Bartłomiej Dach · 2025-11-11 10:24:30 +01:00

5763b7dbe9

Update framework

Dean Herbert · 2025-11-11 18:00:15 +09:00

e1baa03622

Fix attempting to select beatmap which was just externally edited in song select crashing (#35676 )

Closes https://github.com/ppy/osu/issues/35651.

The reproduction steps provided in the issue are too complex even. In my
testing all you need to do is go into editor, replace the background via
external editing, and exit out to song select; you'll immediately see
loss of selection on the carousel, the set panel still using the old
background, and eventually a crash when you attempt to re-select any of
the difficulties of the edited set.

`HandleItemsChanged()` - an optimisation aiming to reduce the number
of redundant re-filters due to minor changes to realm models that aren't
visible to the user anyway - ignoring changes to `BeatmapInfo.ID` after
re-entering song select post-external edit meant that song select would
retain stale beatmap models that no longer existed in the realm
database, thus failing refetch attempts via `GetWorkingBeatmap()` or

	https://github.com/ppy/osu/blob/8f6f859c15bdfc9f10d5754c254fca7b9dd9bc9b/osu.Game/Screens/SelectV2/FooterButtonOptions.cs#L56-L57

Bartłomiej Dach · 2025-11-11 14:20:42 +09:00

4f783f8c41

Delay seeking the current track when dragging now playing overlay progress bar until commit (#35677 )

RFC. Written to address
https://osu.ppy.sh/community/forums/topics/2150023.

Few other things we might want to happen here:

- pause the track when starting the drag
- figure out what to do when a drag is held while the track changes in
  the background (which was impossible to happen before this)

but I want to see the reaction to this first.

Bartłomiej Dach · 2025-11-11 14:18:40 +09:00

4c72a60ee2

Add circular progress display to back-to-top button (#35625 )

* Show circular progress on ScrollBackButton of OverlayScrollContainer

* Adjust standardization of position progress

复予 · 2025-11-10 18:08:00 +09:00

013de9f85d

Fix legacy skin drum roll head circle being underneath ticks (#35647 )

Closes https://github.com/ppy/osu/issues/35321.

Bartłomiej Dach · 2025-11-10 15:43:59 +09:00

cd6c9405fe

Merge pull request #35643 from diquoks/localisation/wasapi

Localise `WASAPI` setting

Dean Herbert · 2025-11-09 02:16:37 +09:00

822cb9e2fb

Fix messages from blocked users being visible in public channels (#35645 )

* Add failing test coverage for blocking users not removing their messages from public channels

* Fix messages from blocked users being visible in public channels

Closes https://github.com/ppy/osu/issues/35633.

It appears that the expectation from web here is that messages from
blocked users should be excised client-side. Compare:

https://github.com/ppy/osu-web/blob/12dd504255bddc0cb37701c392c460222b6825db/resources/js/chat/conversation-view.tsx#L104

This implementation won't *restore* the messages after a block and
unblock, but I kind of... don't care if I'm honest with you? Making that
happen will result in a bunch of complications for no reason, so I'm
fine waiting for anyone to complain about it.

Bartłomiej Dach · 2025-11-07 23:12:12 +09:00

680614fbee

Merge pull request #35435 from nekodex/matchmaking-jumpy-jump

Add SFX for 'jumping' in quick play

Dean Herbert · 2025-11-07 22:23:35 +09:00

cb8ddc706f

Localise WASAPI setting

Denis Titovets · 2025-11-07 14:46:40 +03:00

04d2ce150a

Merge pull request #35638 from smoogipoo/qp-beatmap-panel-mods

Display mods in quick play beatmap cards

Bartłomiej Dach · 2025-11-07 12:34:41 +01:00

eaffb89b4c

Merge branch 'master' into qp-beatmap-panel-mods

Bartłomiej Dach · 2025-11-07 11:13:54 +01:00

650a61539b

Merge pull request #35637 from smoogipoo/qp-random-selection

Add support for selecting a "random" quick play item

Bartłomiej Dach · 2025-11-07 11:13:31 +01:00

75bc934aa5

Adjust guard to be based on current stage

Dan Balasescu · 2025-11-07 18:35:46 +09:00

8d80e2bd2c

Display mods in quick play beatmap cards

Dan Balasescu · 2025-11-07 17:59:02 +09:00

34a3b1ba78

Implement random beatmap card

Dan Balasescu · 2025-11-07 15:30:07 +09:00

b354fa4472

Fix selected item callback being lost

Dan Balasescu · 2025-11-07 15:30:06 +09:00

1fbe1bd6c9

Fix retro skin changing when creating copy for skin editor (#35630 )

RFC, lowest effort solution for https://github.com/ppy/osu/issues/34979.

The `SkinImporter` conditional *is* hella ugly, but anything less ugly
will require taking a hammer to structures. Maybe passing version via
the import flow, maybe even trying to make the `EnsureMutableSkin()`
flow somehow attempt to read the `skin.ini` that's in resources. No
idea.

Properties from `skin.ini` that were defaults or that lazer can't
(won't ever?) understand snipped.

Bartłomiej Dach · 2025-11-07 12:01:11 +09:00

3c215f6574

Document -1 as a special "random" playlist item

Dan Balasescu · 2025-11-07 00:23:58 +09:00

8c28d26130

Fix incorrect handling of user verification failure response (#35629 )

`VerificationFailureResponse.RequiredSessionVerificationMethod` not
being nullable means that if it was missing in the verification
response, it would not be `null` but default to `TimedOneTimePassword`
instead, therefore showing TOTP-related error messages to users that
never enabled it rather than the user-facing message they were supposed
to.

Most easily tested on a local full-stack environment with

```diff
diff --git a/app/Libraries/SessionVerification/MailState.php b/app/Libraries/SessionVerification/MailState.php
index 305a2794ec0..3c2d15f335b 100644
--- a/app/Libraries/SessionVerification/MailState.php
+++ b/app/Libraries/SessionVerification/MailState.php
@@ -14,7 +14,7 @@ use Carbon\CarbonImmutable;

 class MailState
 {
-    private const KEY_VALID_DURATION = 600;
+    private const KEY_VALID_DURATION = 10;

     public readonly CarbonImmutable $expiresAt;
     public readonly string $key;
```

applied so that you don't have to wait 10 minutes to trigger the
failure.

Bartłomiej Dach · 2025-11-06 23:21:26 +09:00

2025.1107.0 933fbd274d

Fix timing of beatmap break overlay (#35566 )

Issue was bisected to [this commit](https://github.com/ppy/osu/pull/29616/commits/6f1664f0a60fc08995d737e40272b61742fbe580)

This change in the commit outlined is what caused the issue:
```diff
BreakOverlay = new BreakOverlay(working.Beatmap.BeatmapInfo.LetterboxInBreaks, ScoreProcessor)
{
  Clock = DrawableRuleset.FrameStableClock,
  ProcessCustomClock = false,
- Breaks = working.Beatmap.Breaks
+ BreakTracker = breakTracker,
},
```

`BreakTracker` always initializes breaks as `new Period(b.StartTime, b.EndTime - BreakOverlay.BREAK_FADE_DURATION);` leaving room at the end to account for the fade before resuming gameplay.

Because of this, changing the `BreakOverlay` to use a `BreakTracker` instead of the original beatmap breaks caused each break to be  `BREAK_FADE_DURATION` shorter than it was originally - which in this case is 325ms - leading to the discrepancy between the background fadeout and the overlay fadeout.

Since the current behavior is 'correct', aligning the overlay with the rest of the beatmap such as background fadeout, I changed the timing to account for the shorter duration instead of revert the overlay initialization.

Giovanni D. · 2025-11-06 14:01:00 +01:00

55ae7e8bb8

Adjust global rank colour tiers

See https://github.com/ppy/osu-web/pull/12522.

Bartłomiej Dach · 2025-11-06 13:14:25 +01:00

4a22ef88ce

Merge branch 'master' into matchmaking-jumpy-jump

Bartłomiej Dach · 2025-11-06 13:06:16 +01:00

43ca046f9b

Fix pressing Enter on song select with IME active advancing to gameplay instead of confirming choice (#35619 )

Closes https://github.com/ppy/osu/issues/35568.

Bartłomiej Dach · 2025-11-06 16:06:52 +09:00

dbefba57ce

Update resources

Dean Herbert · 2025-11-05 22:47:21 +09:00

20904de276

Merge pull request #35611 from stanriders/clamp-notification-avatar

Clamp notification avatar width

Bartłomiej Dach · 2025-11-05 10:42:10 +01:00

fb2fe65a77

Merge pull request #35606 from smoogipoo/qp-history-link

Add history footer button to quick play rooms

Bartłomiej Dach · 2025-11-05 10:22:36 +01:00

4662c5d678

Merge pull request #35542 from smoogipoo/mp-vote-to-skip

Implement vote-to-skip in multiplayer

Bartłomiej Dach · 2025-11-05 10:06:59 +01:00

2025.1105.0 243cd9c073

Merge branch 'master' into mp-vote-to-skip

Dan Balasescu · 2025-11-05 16:53:44 +09:00

e8db35a5c9

Correctly link to room history

Dan Balasescu · 2025-11-05 16:42:32 +09:00

d98cb9ca45

Clamp notification avatar width

StanR · 2025-11-04 21:27:07 +05:00

a7e4aa8b12

Merge pull request #35575 from smoogipoo/qp-player-download-progress

Add download progress bars to quick play users

Bartłomiej Dach · 2025-11-04 14:54:03 +01:00

0f54608cee

Apply one more missed rename

Bartłomiej Dach · 2025-11-04 12:56:03 +01:00

f8331e0b28

Merge branch 'master' into qp-player-download-progress

Bartłomiej Dach · 2025-11-04 12:52:01 +01:00

6ff2a6225d

Bring back size spec in a better way

Bartłomiej Dach · 2025-11-04 12:51:53 +01:00

a8020dea7c

Apply suggestions from review

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dan Balasescu · 2025-11-04 11:37:12 +09:00

88dd458394

Add download progress bars to quick play users

Dan Balasescu · 2025-11-04 11:37:12 +09:00

23cb7f3b23

Add test

Dan Balasescu · 2025-11-04 11:37:07 +09:00

7da051b144

Attempt to clean up chat size definition

Dan Balasescu · 2025-11-04 11:29:51 +09:00

78f639d760

Add history footer button to quick play rooms

Dan Balasescu · 2025-11-04 11:28:08 +09:00

4ea03d0e07

Fix missing disposal

Dan Balasescu · 2025-11-04 11:09:02 +09:00

4d706b12ac

Also update text when users leave

Dan Balasescu · 2025-11-04 11:09:02 +09:00

c44f701abe

Bypass vote for auto-skip

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dan Balasescu · 2025-11-04 11:08:57 +09:00

4c81d661aa

Suffix introp methods with "Intro"

Dan Balasescu · 2025-11-04 11:05:41 +09:00

f4049c7ec1

Add tiered colours for global rank (#35597 )

* Add new API property backing for tiered rank

* Slightly refactor `ProfileValueDisplay` for direct access to things that will need direct access

* Extract separate component for global rank display

* Add tiered colours for global rank

Bartłomiej Dach · 2025-11-04 10:47:33 +09:00

645d27bb32

Fix signalr connector connection failure logging eating exception stack trace (#35598 )

As seen in
https://discord.com/channels/188630481301012481/1097318920991559880/1434899538123952128,
wherein precisely zero useful detail can be gleaned (and nothing is
reported to sentry either).

Bartłomiej Dach · 2025-11-04 09:46:09 +09:00

73f1849365

75760 Commits