1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-27 14:50:45 +08:00

Fix skin layout deserialisation eating exceptions without logging

Because I just wasted 30 minutes trying to debug why a skin provided by
a user in an issue thread was failing to deserialise, only to realise
halfway through that the deserialisation error I was seeing was *from
the fallback path and thus a complete red herring*.
This commit is contained in:
Bartłomiej Dach
2025-11-11 10:24:11 +01:00
Unverified
parent 4f783f8c41
commit 5763b7dbe9
+2 -1
View File
@@ -228,8 +228,9 @@ namespace osu.Game.Skinning
// First attempt to deserialise using the new SkinLayoutInfo format
layout = JsonConvert.DeserializeObject<SkinLayoutInfo>(jsonContent);
}
catch
catch (Exception ex)
{
Logger.Log($"Deserialising skin layout to {nameof(SkinLayoutInfo)} failed. Falling back to {nameof(SerialisedDrawableInfo)}[].\nDetails: {ex}");
}
// If deserialisation using SkinLayoutInfo fails, attempt to deserialise using the old naked list.