73194 Commits

This Branch

This Branch

All Branches

• Update star difficulty panel group with recent design changes
  Salman Alshamrani · 2025-05-09 12:52:12 +09:00
  a4ea052bad
• Merge pull request #33040 from frenzibyte/song-select-empty-placeholder

  Add "no results" placeholder to new song select

  Dean Herbert · 2025-05-09 11:49:07 +09:00
  7311196708
• Update no results placeholder design to feel better alongside new song select
  Dean Herbert · 2025-05-09 02:16:56 +09:00
  f3de345d47
• Merge pull request #33058 from frenzibyte/group-panel-collision

  Fix group panel overlapping with other panels

  Dean Herbert · 2025-05-08 18:07:12 +09:00
  bb9e4a5af7
• Add test coverage
  Salman Alshamrani · 2025-05-08 17:48:00 +09:00
  cdf70aa66b
• Add "no results" placeholder
  Salman Alshamrani · 2025-05-08 17:48:00 +09:00
  386100c718
• Add slightly more spacing for groups
  Dean Herbert · 2025-05-08 17:23:28 +09:00
  c2693dd6a2
• Merge pull request #33061 from frenzibyte/fix-filtering-test-scene

  Fix song select filtering test scene reading from local database

  Dean Herbert · 2025-05-08 17:22:09 +09:00
  9a76797039
• Fix group panel overlapping with other panels
  Salman Alshamrani · 2025-05-08 17:11:34 +09:00
  25c26f6f21
• Add input gap test coverage for group + beatmapset + beatmap panels combination

  Fix gap tests not passing on certain aspect ratios
  
  Flooooating poiiinnts

  Salman Alshamrani · 2025-05-08 17:11:33 +09:00
  c4794b2de3
• Merge pull request #33065 from bdach/tag-localisations

  Use localised strings for user/mapper tags on beatmap set overlay

  Dean Herbert · 2025-05-08 16:55:15 +09:00
  9002db8a2a
• Merge pull request #33063 from bdach/discard-distance-snap-result-oob

  Discard distance snapping result if it results in objects being placed out of playfield bounds

  Dean Herbert · 2025-05-08 16:54:47 +09:00
  69b148461c
• Use localised strings for user/mapper tags on beatmap set overlay
  Bartłomiej Dach · 2025-05-08 08:19:55 +02:00
  eca9389f40
• Merge pull request #33059 from bdach/submission-logging-fixes

  Improve logging and errors around beatmap submission process

  Dan Balasescu · 2025-05-08 13:54:49 +09:00
  045fd474f8
• Merge pull request #33062 from bdach/fix-wrong-combo

  Fix gameplay leaderboard score reading off wrong combo property

  Dan Balasescu · 2025-05-08 13:53:09 +09:00
  afff59926a
• Merge pull request #30731 from Hiviexd/taiko-mod-simplified-rhythm
  Dean Herbert · 2025-05-08 10:37:06 +09:00
  f52eab2d22
• Discard distance snapping result if it results in objects being placed out of playfield bounds

  Mainly an issue with "limit distance snap to current time". Reported in
  https://discord.com/channels/90072389919997952/1259818301517725707/1369037235797753999.
  
  This slightly changes behaviour of distance snap when the mouse is near
  the edges of the screen (will turn off snap rather than clamp to edge as
  previously), but I think that's probably fine.

  Bartłomiej Dach · 2025-05-07 14:23:35 +02:00
  9c40344c9e
• Fix gameplay leaderboard score reading off wrong combo property

  Closes https://github.com/ppy/osu/issues/33006.
  
  Broke in c231571f06.
  
  The fact that this mistake can be made at all is... something, but it
  was made.

  Bartłomiej Dach · 2025-05-07 13:50:11 +02:00
  8af687f751
• Fix song select filtering test scene reading from local database
  Salman Alshamrani · 2025-05-07 14:28:26 +03:00
  6c7fc4249f
• Improve logging around import-as-update flow

  - It was logging success before actually succeeding.
  - It appears in practice that this code can somehow actually nullref.
    Unfortunately logs provided in that instance were not enough to
    pinpoint what (because of lack of line numbers). I'm hoping that by
    logging as error, and therefore to sentry, we can actually retrieve
    this information so that there's no need to work blind.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  588c171978
• Use better error messaging in case of beatmap ID mismatch

  Should maybe give users a better idea of what's wrong.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  ad586cb5dd
• Merge pull request #33039 from frenzibyte/song-select-filter-support

  Hook up filter control with beatmap carousel

  Dean Herbert · 2025-05-07 19:28:24 +09:00
  724176458f
• Fix edge case of last pattern not being processed correctly
  Dean Herbert · 2025-05-07 19:26:00 +09:00
  b89669e56d
• Remove unnecessary dependencies for now
  Dean Herbert · 2025-05-07 18:59:49 +09:00
  d2622c8aed
• Add test coverage of Search method
  Dean Herbert · 2025-05-07 18:52:24 +09:00
  1e05223a81
• Merge pull request #33054 from frenzibyte/fix-group-panel-count-pills

  Fix group pill count moving with panel selection state

  Dean Herbert · 2025-05-07 18:39:01 +09:00
  ffaebce9a0
• Fix group pill count moving with panel selection state
  Salman Alshamrani · 2025-05-07 12:01:44 +03:00
  f0ab6dc869
• Fix return type git somehow didn't notice
  Dean Herbert · 2025-05-07 17:46:12 +09:00
  ecc0c94521
• Merge pull request #33046 from frenzibyte/carousel-filtering

  Add filtering support in carousel v2

  Dean Herbert · 2025-05-07 17:42:33 +09:00
  d286a27da2
• Merge pull request #32971 from bdach/open-playlist-link

  Add support for opening multiplayer / playlist room links directly

  Dean Herbert · 2025-05-07 17:31:41 +09:00
  66f77701a9
• Merge pull request #33049 from peppy/carousel-manifest-filters

  Ensure carousel filters are manifested to lists at each step

  Bartłomiej Dach · 2025-05-07 10:20:25 +02:00
  cf9acc97a3
• Change ICarouselFilter interface return type rather than manual ToList

  I was hung up on keeping `IEnumerable` but there doesn't seem to be a
  good reason to do so.

  Dean Herbert · 2025-05-07 16:40:23 +09:00
  ebd6776898
• Allow falling back to opening multiplayer room history in browser if it's ended
  Bartłomiej Dach · 2025-05-07 09:40:10 +02:00
  9b3812210c
• Merge branch 'master' into open-playlist-link
  Bartłomiej Dach · 2025-05-07 09:31:58 +02:00
  810346ab34
• Ensure BeatmapItemsCount is stable during filter operations
  Dean Herbert · 2025-05-07 16:29:11 +09:00
  7789f4dbb0
• Add SortAndGroupBy method to simplify usages
  Salman Alshamrani · 2025-05-07 10:28:09 +03:00
  8775731c24
• Expose matched beatmaps count from BeatmapCarousel
  Salman Alshamrani · 2025-05-07 10:22:20 +03:00
  1c6e998c95
• Merge pull request #33050 from bdach/ignore-weird-test

  Ignore "image proxying" test scene

  Dean Herbert · 2025-05-07 16:21:28 +09:00
  370f26f75f
• Ignore "image proxying" test scene

  Because it just failed thrice
  (https://github.com/ppy/osu/runs/41775675413#r0) and to me it seems like
  a profoundly bad idea.
  
  I considered having it retry like the framework precedent of this
  (https://github.com/ppy/osu-framework/blob/dd2b701ed84c687ff71f5c50338d3b325159ee45/osu.Framework.Tests/IO/TestWebRequest.cs#L69)
  before I noticed that it was also hitting hardcoded production endpoints
  at which point I decided it was just too weird to live.

  Bartłomiej Dach · 2025-05-07 09:15:15 +02:00
  1f2fba6e23
• Merge pull request #33047 from peppy/song-select-transition-update

  Adjust song select beatmap background transition to better support transparent backgrounds

  Bartłomiej Dach · 2025-05-07 09:08:53 +02:00
  9fb4ca7a95
• Adjust matching filter's code to conform to other filter implementations
  Dean Herbert · 2025-05-07 16:01:30 +09:00
  5d04cc045d
• Ensure carousel filters are manifested to lists at each step

  The original `IEnumerable` flow prioritised slight performance gains,
  but a filter's implementation could actually make this detrimental to
  overall performance.
  
  I noticed in passing that there were already potentially multiple
  enumerations, via `updateYPositions` and the final `ToList` call. Rather
  than faffing around, let's keep things simple and require lists.
  
  In benchmarking, the difference is (currently) negiligible. Slight
  improvement if anything.

  Dean Herbert · 2025-05-07 15:55:20 +09:00
  cc0c21a216
• Merge pull request #33045 from peppy/cache-supporter-status

  Fix startup "welcome" sound sometimes not loading from skin for supporters

  Bartłomiej Dach · 2025-05-07 08:49:11 +02:00
  79c4426725
• Merge pull request #33044 from peppy/argon-slider-body-transparency

  Add minimal slider body transparency to "Argon" skins

  Bartłomiej Dach · 2025-05-07 08:47:21 +02:00
  9389e63d49
• Add test coverage for song select filtering
  Salman Alshamrani · 2025-05-07 09:17:54 +03:00
  d34e040b4e
• Improve count check test assertions
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  725187245a
• Add test coverage for filtering
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  90abd11ca5
• Add carousel filter for matching items against criteria (i.e. actually filter)
  Salman Alshamrani · 2025-05-07 09:09:40 +03:00
  a3aa4c7ba5
• Adjust song select beatmap background transition to better support transparent backgrounds

  The new background now briefly fades in. The reason we didn't do this to
  date is that there could be a perceived decrease in brightness as the old
  and new background transition through opacity.
  
  But a quick fade in, it doesn't seem to cause any visual artifacting.
  
  I've also added a scale effect because it felt quite nice. Willing to
  pull that if anyone has an issue with it, but it's a step in the
  direction of "adding more motion to song select", which is still an area
  I see lacking greatly – even compared to stable.

  Dean Herbert · 2025-05-07 14:59:29 +09:00
  34119aab8e
• Show loading layer if filtering actually takes long
  Salman Alshamrani · 2025-05-07 08:44:30 +03:00
  7918f6e7a1