1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-17 05:43:22 +08:00
Commit Graph

69984 Commits

Author SHA1 Message Date
StanR
0bad5e4684 Move slider-related ratio multiplier out of the delta switch block, add nerf for ratios with delta difference fractions that are too big, adjust consts 2024-09-19 04:38:01 +05:00
Joseph Madamba
c185acdbae Use GetLocalisedBindableString() instead 2024-09-18 11:16:25 -07:00
Bartłomiej Dach
7f52ae8837
Fix code quality inspection 2024-09-18 15:30:56 +02:00
Bartłomiej Dach
f6195c5515
Add to existing selection when dragging with control pressed
Closes https://github.com/ppy/osu/issues/29023.
2024-09-18 15:18:13 +02:00
Bartłomiej Dach
2d3b027f85
Add test case covering desired behaviour 2024-09-18 15:18:13 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
RFC. Closes https://github.com/ppy/osu/issues/18169.

Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.

There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.

In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Bartłomiej Dach
cf9f8c7f66
Merge pull request #29916 from peppy/fix-song-select-crash-selection-after-loading
Fix occasional song select crash when entering gameplay
2024-09-18 11:44:59 +02:00
Bartłomiej Dach
d506d8a150
Implement TabbableContentContainer for slider control 2024-09-18 11:32:55 +02:00
Bartłomiej Dach
093d9ab076
Keep slider bar looking active when dragging outside of its bounds 2024-09-18 11:30:52 +02:00
Bartłomiej Dach
0bab755be3
Add missing xmldoc 2024-09-18 11:25:23 +02:00
Bartłomiej Dach
95e26e6fd8
Make slider bar instantaneous by default (and fix broken implementation) 2024-09-18 11:23:00 +02:00
Dean Herbert
ac507a3ba5
Remove unused parameter in applyActiveCriteria 2024-09-18 17:22:09 +09:00
Dean Herbert
743d509241
Also ensure filter is applied when returning to song select 2024-09-18 17:22:08 +09:00
Bartłomiej Dach
ba9143e597
Merge pull request #29912 from peppy/remove-dropdown-opacity
Remove opacity from old style dropdown menus
2024-09-18 09:48:11 +02:00
Dean Herbert
c192a6a1d5
Fix song select crashes due to attempting to clear selection after load has already begun 2024-09-18 16:12:34 +09:00
Dean Herbert
aae98e6906
Add failing test showing crash at song select on selection edge case 2024-09-18 16:12:34 +09:00
Dean Herbert
8f49876fe7
Re-sync judgement counter display after replay frame reset 2024-09-18 15:28:11 +09:00
Dean Herbert
c46e9cbce3
Tidy up JudgementCounter classes 2024-09-18 15:28:10 +09:00
Dean Herbert
2d993645af
Add test coverage of judgements not being synced when resuming a replay 2024-09-18 15:28:10 +09:00
Joseph Madamba
fd6b3b6b36 Fix searching by clicking title/artist in beatmap overlay not following original language setting 2024-09-17 22:34:06 -07:00
Dean Herbert
76c5e743d7
Remove opacity from old style dropdown menus
These aren't used in many places, but we've since moved away from
opacity in UI elements like this, so let's just nuke it here for
legibility.

Addresses https://github.com/ppy/osu/discussions/29906.
2024-09-18 13:49:27 +09:00
Bartłomiej Dach
20b1d76269
Ensure selection is preserved when moving selection between columns
Closes https://github.com/ppy/osu/issues/29793.

I believe that the sequence of events that makes this happens is as
follows:

- User selects a range of objects. Some of those objects are off-screen,
  and thus would be presumed to be not alive - except the blueprint
  container forces them to remain alive, because they're part of the
  selection.

- User moves the selection to another column, which is implemented by
  temporarily removing the objects from the playfield, changing their
  column, and re-adding them.

  This sort of pattern is supposed to kick off the
  `HitObjectUsageTransferred` flow in `HitObjectUsageEventBuffer` - and
  it does... for objects that are *currently visible on screen* and thus
  would be alive regardless of `SetKeepAlive()`. However, this does not
  hold for objects that are off-screen - nothing ensures they are kept
  alive again after re-adding, and thus they inadvertently become dead.

- Thus, this doesn't kick off the `BlueprintContainer` flows associated
  with transferring objects to another column, and instead fires the
  removal flows, which ensure that the off-screen objects that were
  being moved are instead deselected.

I tried a few other options but found no better resolution than this -
calling `SetKeepAlive()` directly would require making it public, which
seems like a bad idea. There's really no good way to generically handle
this either, because it is the ruleset that decides that its way of
implementing this operation will be a removal and re-add of objects,
so...
2024-09-17 13:18:18 +02:00
Bartłomiej Dach
e0f92bab6a
Add test case covering failure 2024-09-17 13:07:52 +02:00
Bartłomiej Dach
1b17231da4
Implement "form" slider bar control 2024-09-17 11:40:57 +02:00
Bartłomiej Dach
ea94f903c1
Merge pull request #29894 from peppy/fix-fruit-rotation
Fix osu!catch fruit rotation being applied too late
2024-09-17 10:26:21 +02:00
Dean Herbert
f8fff4074d
Fix rotation not being updated correctly on start time change 2024-09-17 16:18:29 +09:00
Dean Herbert
c1c0d49bfe
Add comments and fix bananas stopping still if not caught 2024-09-17 16:15:45 +09:00
Dean Herbert
a1fa132ddb
Merge pull request #29893 from bdach/slider-end-drag-marker-broken-by-stacking
Fix slider end drag marker being in incorrect position for stacked sliders
2024-09-17 16:03:38 +09:00
Dean Herbert
3f4422429d
*Also* fix droplets 2024-09-17 15:38:51 +09:00
Dean Herbert
2ccdad41e7
Also fix banana showers 2024-09-17 15:31:00 +09:00
Bartłomiej Dach
67a7f608f1
Fix slider end drag marker being in incorrect position for stacked sliders
Closes https://github.com/ppy/osu/issues/29884.
2024-09-17 08:23:46 +02:00
Bartłomiej Dach
3e63fe399f
Enable NRT in test scene 2024-09-17 08:22:37 +02:00
Bartłomiej Dach
a99dbfa768
Add failing test step demonstrating incorrect end drag marker position 2024-09-17 08:21:58 +02:00
Dean Herbert
785a725507
Fix osu!catch fruit rotation being applied too late 2024-09-17 15:12:02 +09:00
Dean Herbert
d34e8ea69e
Update framework 2024-09-16 16:15:09 +09:00
StanR
c9ce7d29e6 Adjust multipliers 2024-09-16 01:04:46 +05:00
StanR
bee18b03e7 Reduce history max overall instead of using clock rate 2024-09-16 00:49:36 +05:00
StanR
145731bdef More balancing 2024-09-15 02:48:41 +05:00
StanR
863a74f980 Balancing 2024-09-15 02:08:37 +05:00
StanR
738d4bcb80 Reduce ratio if we're starting island counting after a slider 2024-09-15 01:49:52 +05:00
StanR
db626f168a Refactor 2024-09-15 01:12:41 +05:00
StanR
5e8174faa8 Reduce ratio for island size 1 2024-09-14 22:03:01 +05:00
OliBomby
30096c1c71 clean up code 2024-09-14 17:26:04 +02:00
Olivier Schipper
f7503ee2c8
Merge pull request #107 from kongehund/master
Rewrite GetConvexHull using the clean room method
2024-09-14 17:05:33 +02:00
kongehund
385eb5eed5 Rewrite GetConvexHull 2024-09-14 16:32:51 +02:00
Dean Herbert
18ab4ee929
Merge pull request #29812 from smallketchup82/add-beatmap-icon
Add beatmap icon to windows beatmap files
2024-09-14 10:14:30 +09:00
Dean Herbert
eb102479f4
Use beatmap icon for .osr and .osk for now 2024-09-14 02:47:19 +09:00
Dean Herbert
1204136af8
Update icon file with new design 2024-09-14 02:46:19 +09:00
Dean Herbert
5ea7061d5a
Merge pull request #29712 from bdach/editor/setup-screen-checkbox
Implement "form" check box control
2024-09-14 02:26:59 +09:00
Dean Herbert
369c913272
Merge pull request #29862 from bdach/backpopulate-rank-submission-dates
Backpopulate missing ranked/submitted dates using new local metadata cache
2024-09-14 02:20:22 +09:00