1181 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	303cc62ee7	Transfer flags indicating if settings were changed	2021-01-06 22:46:46 +01:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
Dean Herbert	b81dbfc192	Move shared implementation to a named function	2020-12-14 13:56:46 +09:00
ekrctb	5b5e883904	Remove EffectiveXBindable (setting Value was not handled) ... And use orthogonal `OriginalXBindable` and `XOffsetBindable`.	2020-12-14 13:39:07 +09:00
ekrctb	0ad256a762	Fix comment	2020-12-14 13:18:32 +09:00
ekrctb	d96399ea42	Revert "Remove X setter from CatchHitObject" ... This reverts commit 7cbbd74d	2020-12-14 13:18:14 +09:00
ekrctb	7cbbd74df2	Remove X setter from CatchHitObject	2020-12-14 11:38:07 +09:00
ekrctb	f621d977fc	Add some more doc comment	2020-12-14 11:32:34 +09:00
ekrctb	36529bdd1b	Use OriginalX for CatchHitObject.X instead of EffectiveX ... And explicitly implement IHasXPosition interface to prevent use of the X property. It should be preferred for beatmap conversion purpose.	2020-12-14 11:26:05 +09:00
ekrctb	089f3bebf5	Add doc comments to catch hit object X properties	2020-12-14 11:15:49 +09:00
ekrctb	cd2db59900	XBindable -> EffectiveXBindable in catch DHO	2020-12-14 11:05:26 +09:00
ekrctb	96f3e0dad8	Replace CatchHitObject.X usage to EffectiveX and OriginalX	2020-12-14 11:03:14 +09:00
ekrctb	c1f3f1c231	Obsolete X getter	2020-12-14 11:03:10 +09:00
ekrctb	8da502da44	Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX	2020-12-14 11:03:03 +09:00
Dean Herbert	c0d20d8ce4	Add some spacing to interface class	2020-12-11 16:43:00 +09:00
ekrctb	2634c6b8d9	Combine DisplayRadius and Scale to DisplaySize	2020-12-10 20:43:01 +09:00
ekrctb	e097b6e61c	Add ScalingContainer back ... Don't want to set DHO.Scale or DHO.Rotation because because DHO may be transformed by mods. DHO.Size is also assigned for drawable visualizer	2020-12-10 19:42:01 +09:00
ekrctb	a8e2f35b62	Remove unneeded check of caught object removal ... The logic was public but now it is private so the condition is ensured by the caller	2020-12-09 10:50:35 +09:00
ekrctb	775c4bad97	Remove unneeded lifetime assignment	2020-12-09 10:47:04 +09:00
ekrctb	da2f3d4473	Move classes to separate files	2020-12-09 10:40:42 +09:00
ekrctb	b52e279702	Reword exception message	2020-12-09 10:38:11 +09:00
ekrctb	86445e7c23	Remove unnecessary copy	2020-12-09 10:36:54 +09:00
ekrctb	c8b0934573	Rename caughtFruitContainer -> caughtObjectContainer	2020-12-09 10:35:36 +09:00
ekrctb	ccca7e0b25	more specific type droppedObjectContainer	2020-12-09 10:35:01 +09:00
ekrctb	df9de7a8dd	Remove null check that is not required anymore	2020-12-09 10:28:42 +09:00
ekrctb	b80204642e	Revert rename error	2020-12-09 10:25:35 +09:00
ekrctb	1212ffd24f	Rename to CopyStateFrom, and add comment	2020-12-08 23:35:24 +09:00
ekrctb	5ca98b0033	Add doc comments a bit	2020-12-08 23:11:22 +09:00
ekrctb	1f36bbecd1	Fix dropped objects not removed on revert result	2020-12-08 23:07:30 +09:00
ekrctb	749d5380ca	Pool caught objects and dropped objects	2020-12-08 22:38:10 +09:00
ekrctb	a32dac00dd	Introduce IHasCatchObjectState implemented by DHO and CaughtObject	2020-12-08 21:29:26 +09:00
ekrctb	c301223d8c	Make object on the catcher plate separate CaughtObject class	2020-12-08 21:11:40 +09:00
ekrctb	94a59ac3b2	Make catch hit lighting logic not dependent on caught object	2020-12-08 20:41:26 +09:00
ekrctb	004c705aa9	Remove ScaleContainer and flatten the Drawable tree of catch DHO	2020-12-08 20:37:08 +09:00
ekrctb	56721a6fa9	Compute object position in stack via a pure function	2020-12-08 20:36:59 +09:00
Dan Balasescu	0739f09930	Merge pull request #11110 from ekrctb/fruit-piece-in-place ... Implement in-place update of catch DrawableHitObject	2020-12-08 18:36:20 +09:00
Dan Balasescu	c3241f163d	Merge pull request #11126 from ekrctb/fix-catcher-trail-sprite-pooled ... Clear all transforms of catcher trail sprite before returned to pool	2020-12-08 17:59:23 +09:00
Dan Balasescu	1757b9c3e7	Merge branch 'master' into fruit-piece-in-place	2020-12-08 17:42:34 +09:00
ekrctb	22a5df6309	Clear all transforms of catcher trail sprite before returned to pool	2020-12-08 17:31:00 +09:00
ekrctb	4d5c242d35	Use virtual property instead of a field for optional pieces	2020-12-08 17:15:40 +09:00
ekrctb	603cecb2eb	Make CatchHitObjectPiece abstract class	2020-12-08 17:02:57 +09:00
ekrctb	17d48c82f6	Use switch statement instead of an array	2020-12-08 16:59:06 +09:00
ekrctb	02571ec7ae	Remove hit explosion on revert result	2020-12-08 15:43:17 +09:00
ekrctb	1a66d8f2bc	Remove caught objects on revert result	2020-12-08 15:24:39 +09:00
ekrctb	100b365c98	Restore hyper dash state on revert judgement result	2020-12-08 15:21:47 +09:00
ekrctb	cb76a2d7b5	Restore catcher state on revert judgement result	2020-12-08 15:03:03 +09:00
ekrctb	0213f77b4b	Move catcher state changing logic to OnNewResult method	2020-12-08 14:28:30 +09:00
ekrctb	4da6717d0e	Rename things in PulpFormation	2020-12-08 10:33:18 +09:00
ekrctb	3cbdaf5960	Make resolved properties protected	2020-12-08 10:30:23 +09:00
ekrctb	b2e5658d23	Merge branch 'master' into fruit-piece-in-place	2020-12-07 18:57:42 +09:00