75623 Commits

This Branch

This Branch

All Branches

• Update framework
  Dean Herbert · 2025-10-25 19:41:28 +09:00
  9ca47fc53a
• Update AudioDevicesSettings.cs

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2025-10-25 17:35:48 +09:00
  79a76ce587
• Add settings toggle for experimental BASS initialisation mode
  Dean Herbert · 2025-10-25 13:46:49 +09:00
  72fa1553c3
• Merge pull request #35432 from smoogipoo/improve-qp-chat

  Several improvements to quick play chat input

  Dean Herbert · 2025-10-25 00:50:11 +09:00
  2025.1025.0-tachyon 954061b00b
• Merge pull request #35422 from bdach/favourites-grouping

  Implement grouping by favourites

  Dean Herbert · 2025-10-24 23:24:48 +09:00
  b74962af92
• Add very simple countdown timer for quick play stages (#35433)
  Dean Herbert · 2025-10-24 23:07:04 +09:00
  1af462b692
• Merge branch 'master' into favourites-grouping
  Dean Herbert · 2025-10-24 22:39:14 +09:00
  763739e877
• Fix tests
  Dan Balasescu · 2025-10-24 22:23:05 +09:00
  f96be84c57
• Fix partially offscreen quick play chat context menu
  Dan Balasescu · 2025-10-24 21:45:56 +09:00
  613c208362
• Move context menu from channel to chat overlay
  Dan Balasescu · 2025-10-24 21:45:56 +09:00
  a3c78de710
• Move quick play chat entirely to screen footer
  Dan Balasescu · 2025-10-24 21:45:56 +09:00
  e240817087
• Merge pull request #35429 from bdach/scrolling-song-select-wedge-text

  Scroll song select title wedge text if it overflows

  Dean Herbert · 2025-10-24 21:40:03 +09:00
  ddb844f81b
• Merge pull request #35431 from bdach/instant-scroll-carousel-post-filter

  SongSelectV2: Scroll to selection instantly after a filter

  Dean Herbert · 2025-10-24 21:27:25 +09:00
  b6f4175939
• SongSelectV2: Scroll to selection instantly after a filter

  Closes https://github.com/ppy/osu/issues/33379.
  
  Pretty sure this matches song select V1. The two call sites where the
  old one does instant scrolls are:
  
  	https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L672
  
  which happens just after a filter, and
  
  	https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L683
  
  which is a bit more difficult to pin down, but generally appears to
  happen on changes to the visible items, which on `SongSelectV2` triggers
  a re-filter anyway.

  Bartłomiej Dach · 2025-10-24 13:24:47 +02:00
  819da1bc38
• Fix code quality
  Bartłomiej Dach · 2025-10-24 12:11:38 +02:00
  33e42d2809
• Fix marquee container not updating scrolling state if its content changes size

  This is actually possible in current usages if you e.g. toggle "use
  original metadata" on/off which will change the width of the underlying
  sprite texts. Or by setting window size. Pick your poison.

  Bartłomiej Dach · 2025-10-24 11:08:01 +02:00
  1a49d030a0
• Scroll song select title wedge text if it overflows

  Instead of truncating.
  
  Addresses https://github.com/ppy/osu/discussions/35404.
  
  The one "tiny" problem is that the "click to search" functionality of
  these texts is maybe a bit worse now, because the clickable target is
  now the full width of the wedge rather than autosized to the text.
  Salvaging this is *maybe* possible, but *definitely* annoying, so I'd
  rather not frontload it.

  Bartłomiej Dach · 2025-10-24 11:07:06 +02:00
  03adae4417
• Merge pull request #35428 from bdach/star-rating-grouping-limit

  Use single group for beatmaps of 15 stars and above

  Dean Herbert · 2025-10-24 18:00:57 +09:00
  5a38e1537b
• Merge pull request #35426 from bdach/collection-grouping-order

  Fix song select collection group order not matching other collection lists when certain characters are used

  Dean Herbert · 2025-10-24 17:53:28 +09:00
  6ac8e59a11
• Use single group for beatmaps of above 15 stars

  Addresses https://github.com/ppy/osu/discussions/35201.

  Bartłomiej Dach · 2025-10-24 10:23:36 +02:00
  a816977208
• Assert expected behaviour in test
  Bartłomiej Dach · 2025-10-24 10:23:36 +02:00
  f0bfb4becc
• Merge pull request #35420 from smoogipoo/qp-handle-beatmap-present

  Disable presenting beatmaps during quick play

  Dean Herbert · 2025-10-24 16:59:45 +09:00
  ec6ffb3403
• Fix song select collection group order not matching other collection lists when certain characters are used

  Addresses https://github.com/ppy/osu/discussions/35391.
  
  See inline commentary for explanation.

  Bartłomiej Dach · 2025-10-24 09:51:34 +02:00
  6ded2e3de7
• Merge pull request #35395 from bdach/culture-info-is-the-bane-of-my-existence

  Allow `NumberFormattingExtensions.ToStandardFormattedString()` to accept culture

  Dean Herbert · 2025-10-24 16:46:37 +09:00
  6c7eafde1a
• Implement grouping by favourites

  - Closes https://github.com/ppy/osu/issues/34494.
  - Supersedes / closes https://github.com/ppy/osu/pull/34744.

  Bartłomiej Dach · 2025-10-24 08:46:34 +02:00
  14d0982b6c
• Change BeatmapCarouselFilterGrouping constructor params to required init properties
  Bartłomiej Dach · 2025-10-24 08:42:45 +02:00
  29787360ba
• Refetch list of user favourites on every change to favourites

  Is this lazy? Sure it is. Friends and blocks do the same thing, though,
  and I'm not overthinking this any more than I already have.
  
  Being smarter here would likely mean being more invasive with respect to
  listening in on all outgoing API requests and silently updating
  favourites on that basis. Which is "smart" but also complicated.

  Bartłomiej Dach · 2025-10-24 08:41:52 +02:00
  6b56a0611b
• Add favourite beatmap set tracking to LocalUserInfo
  Bartłomiej Dach · 2025-10-24 08:40:50 +02:00
  0f1bf35bd9
• Implement request & response for fetching logged in user's favourite beatmap sets
  Bartłomiej Dach · 2025-10-24 08:36:13 +02:00
  b600860540
• Always use current culture in ToStandardFormattedString()
  Bartłomiej Dach · 2025-10-24 08:26:01 +02:00
  ae7ba034a7
• Merge pull request #35398 from bdach/song-select-working-beatmap-pressure

  Attempt to improve performance of beatmap carousel when not grouped by sets

  Dean Herbert · 2025-10-24 15:22:41 +09:00
  0cb521798d
• Disable presenting beatmaps during matchmaking
  Dan Balasescu · 2025-10-24 15:15:46 +09:00
  1ee24521b8
• Merge branch 'master' into song-select-working-beatmap-pressure
  Dean Herbert · 2025-10-24 14:36:59 +09:00
  efe7d92096
• Merge pull request #35400 from bdach/leaderboard-sometimes-incorrectly-partial

  Fix solo leaderboard sometimes not showing user position while it technically could

  Dean Herbert · 2025-10-24 14:36:14 +09:00
  4f478db056
• Merge pull request #35415 from bdach/local-user-state-refactor

  Extract all pieces of local user-related state to `APIAccess` subcomponent

  Dean Herbert · 2025-10-24 14:32:43 +09:00
  646cb71b77
• Merge pull request #35393 from smoogipoo/fix-qp-availability

  Make quick play redownload locally modified beatmaps

  Dean Herbert · 2025-10-24 14:28:03 +09:00
  ce3e3d17fa
• Merge branch 'master' into fix-qp-availability
  Dean Herbert · 2025-10-24 14:27:45 +09:00
  d062c99666
• Use more legible collection initialisation
  Dean Herbert · 2025-10-24 14:22:10 +09:00
  803737c947
• Merge pull request #35399 from smoogipoo/qp-view-beatmap

  Fix quick play "view beatmap" not showing beatmap overlay

  Dean Herbert · 2025-10-24 14:21:49 +09:00
  44a427f4e5
• Merge pull request #35397 from smoogipoo/qp-match-ended-counter

  Fix round counter showing on match end

  Dean Herbert · 2025-10-24 14:17:09 +09:00
  85ab0d621c
• Merge pull request #35401 from bdach/custom-sample-set-model-support

  Adjust gameplay sample models to support custom sample sets

  Dean Herbert · 2025-10-23 18:36:17 +09:00
  1591d49143
• Merge pull request #35367 from smoogipoo/qp-idle-track

  Preview next song in quick play

  Dean Herbert · 2025-10-23 18:23:20 +09:00
  b9de7ba196
• Fix blocks not being correctly cleared on logout

  See, this refactor is where omissions like this that normally would pass
  unnoticed stop passing unnoticed.

  Bartłomiej Dach · 2025-10-23 10:54:52 +02:00
  dfa8d4fe7c
• Extract all pieces of local user-related state to APIAccess subcomponent

  Something I've asked to be done for a long time. Relevant because I've
  complained about this on every addition of a new piece of user-local
  state: friends, blocks, and now favourite beatmaps.
  
  It's just so messy managing all this inside `APIAccess` next to
  everything else, IMO.

  Bartłomiej Dach · 2025-10-23 10:53:58 +02:00
  5eda9a0fd7
• Fix solo leaderboard sometimes not showing user position while it technically could

  The "partial" leaderboard logic in `SoloGameplayLeaderboardProvider`
  always assumed the online fetch would request 50 scores, which is no
  longer the case after https://github.com/ppy/osu/pull/33100.

  Bartłomiej Dach · 2025-10-23 08:53:29 +02:00
  ca8fc81a7e
• Fix taiko sample models not passing everything forward as they should
  Bartłomiej Dach · 2025-10-23 08:48:39 +02:00
  82bcbb53dd
• Don't block input on mouse down
  Dan Balasescu · 2025-10-22 22:22:44 +09:00
  9a089315b8
• Adjust test to cover better
  Bartłomiej Dach · 2025-10-22 14:58:13 +02:00
  baea05a0a1
• Adjust gameplay sample models to support custom sample sets

  This is a set of model changes which is supposed to facilitate support
  for custom sample sets to the beatmap editor that is on par with stable.
  
  It is the minimal set of changes. Because of this, it can probably be
  considered "ugly" or however else you want to put it - but before you
  say that, I want to try and pre-empt that criticism by explaining where
  the problems lie.
  
  Problem #1: duality in sample models
  ---
  
  There is currently a weird duality of what a `HitObject`'s samples will
  be.
  
  - If an object has just been placed in the editor, and not saved /
    decoded yet, it will use `HitSampleInfo`.
  
  - If an object has already been encoded to the beatmap at least once, it
    will use `ConvertHitObjectParser.LegacyHitSampleInfo`.
  
  As long as that state of affairs remains, `HitSampleInfo` must be able
  to represent anything that `LegacyHitSampleInfo` can, if feature parity
  is to be achieved.
  
  Problem 2: The 0 & 1 sample banks
  ---
  
  Custom sample banks of 2 and above are a pretty clean affair. They map to
  a suffix on the sample filename, and said samples are allowed to be
  looked up from the beatmap skin. `Suffix` already exists in
  `HitSampleInfo`.
  
  However, the 1 custom sample bank is evil. It uses *non-suffixed*
  samples, *allows lookups from the beatmap skins*, contrary to no bank /
  bank 0, which *also* uses non-suffixed samples, but *doesn't* allow them
  to be looked up from the beatmap skin.
  
  This is why `HitSampleInfo.UseBeatmapSamples` has been called to
  existence - without it there is no way to represent the ability of using
  or not using the beatmap skin assets.
  
  As has been stated previously in discussions about this feature, it's
  both a *mapping* and a *skinning* concern.
  
  There are many things you could do about either of these problems, but I
  am pretty sure tackling either one is going to take *many* more lines of
  code than this commit does. Which is why this is the starting point of
  negotiation.

  Bartłomiej Dach · 2025-10-22 14:58:08 +02:00
  c361e6d3c2
• Add test coverage of expected behaviour of sample suffix
  Bartłomiej Dach · 2025-10-22 14:30:47 +02:00
  a4a2e4e639