359 Commits

• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Resolve warnings in tests
  Dan Balasescu · 2025-06-13 22:36:32 +09:00
  4f5c9f9713
• Rewrite UpdateManager to handle cancellations
  Dan Balasescu · 2025-06-13 20:34:31 +09:00
  addd10f4c6
• Fix code quality
  Bartłomiej Dach · 2025-06-13 10:06:44 +02:00
  dc38c190df
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Floor star rating to 2 decimal places rather than rounding

  Rounding semi-regularly confuses users who aim for star rating pass / FC
  medals and then feel they have been cheated out of a medal because they
  passed an "X-star beatmap", but the actual star rating of the beatmap is
  slightly under X.
  
  The latest instance of this can be found at
  https://osu.ppy.sh/community/forums/topics/2091333?n=2. The relevant
  beatmap there is https://osu.ppy.sh/beatmapsets/2162554#osu/4746232,
  whose raw star rating is 6.9976070253117344.
  
  The other direction would be to fix the star rating medals instead, but
  I think this is more reasonable given we already do similar things to
  accuracy displays.

  Bartłomiej Dach · 2025-06-13 09:11:06 +02:00
  4fd2a488b7
• Expand tests to perform a second check

  To ensure it doesn't get stuck in a state where new checks aren't
  performed.

  Dan Balasescu · 2025-06-11 16:47:05 +09:00
  359e3ac8a5
• Partial classes
  Dan Balasescu · 2025-06-11 16:43:32 +09:00
  981cf62c23
• Add tests
  Dan Balasescu · 2025-06-11 16:37:31 +09:00
  41d4d55f22
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Split out methods so retrieving the room is not a callback function
  Dean Herbert · 2025-03-04 19:19:53 +09:00
  918315aa65
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Fix broken test
  Dan Balasescu · 2025-03-04 14:14:42 +09:00
  b73a872b94
• Merge pull request #31637 from smoogipoo/room-management-lio

  Create, join, and part multiplayer rooms only via the multiplayer server

  Dean Herbert · 2025-03-04 13:13:55 +09:00
  58a671decb
• Add failing test
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  963df165df
• Remove SelectedRoom abstraction from OnlinePlayTestScene
  Dan Balasescu · 2025-02-12 22:55:19 +09:00
  205d6ecffb
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-11 21:19:32 +09:00
  38cd4fa56a
• Add fail cases to unstable rate incremental testing
  Dean Herbert · 2025-01-29 17:10:05 +09:00
  6c4b4166ac
• Adjust + fix tests
  Dan Balasescu · 2025-01-23 16:27:38 +09:00
  9a623257f5
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Merge branch 'master' into multiplayer-remove-cmc-and-composite
  Dean Herbert · 2024-11-20 17:24:55 +09:00
  6fba6de4dc
• Add missing source query filter in song select
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  465cc716d3
• Add failing source filter query test
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  7c94973d4a
• Add basic searching by source test
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  c2b08beae8
• Make RoomID non-bindable

  Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.

  Dan Balasescu · 2024-11-13 16:28:54 +09:00
  99762da7b8
• Fix test compile failures
  Bartłomiej Dach · 2024-10-21 13:57:34 +02:00
  1e03bd11a3
• Fix code quality and formatting issues
  WitherFlower · 2024-10-10 17:41:29 +02:00
  6b532824b1
• Add slash and dot as valid separators in dates.
  WitherFlower · 2024-10-08 14:13:27 +02:00
  b58576f31b
• Add tests for ranked and submitted date filtering
  WitherFlower · 2024-10-08 13:46:39 +02:00
  f8e43fd8d3
• Add 'yes'/'no' acronyms to the played= filter
  Dan Balasescu · 2024-09-06 18:04:39 +09:00
  6913d75792
• Add test + adjust existing ones with new semantics
  Dan Balasescu · 2024-08-29 20:59:27 +09:00
  97adac2e0a
• move timing point binary search back inline
  OliBomby · 2024-08-21 01:50:52 +02:00
  8d72ec8bd6
• Updated the tests according to new logic

  and fixed one minor CI code quality thing

  Givikap120 · 2024-06-18 15:48:21 +03:00
  1ddfc8f011
• Merge pull request #27808 from smoogipoo/fix-incorrect-pp-counter

  Fix gameplay PP counter not matching results screen

  Bartłomiej Dach · 2024-04-23 08:43:49 +02:00
  1f010c4bfd
• Don't re-filter unless mods may change the filter
  Dan Balasescu · 2024-04-15 21:07:36 +09:00
  343b3ba0e6
• Ensure all remaining objects are added in the last iteration
  Dan Balasescu · 2024-04-12 00:11:54 +09:00
  e9b319f4c6
• Implement a less failure-prone method
  Dan Balasescu · 2024-04-11 23:40:40 +09:00
  19cc847be6
• Add test
  Dan Balasescu · 2024-04-11 17:56:34 +09:00
  bf63ba3f82
• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Update tests to match new expected behaviour

  Co-authored-by: Vlad Frangu <me@vladfrangu.dev>

  Bartłomiej Dach · 2024-03-26 12:19:55 +01:00
  c24eb066dc
• Use HashSet instead of SortedSet

  No need for it to be sorted.

  Bartłomiej Dach · 2024-03-19 18:26:58 +01:00
  feaf59e15f
• chore: requested changes
  Vlad Frangu · 2024-03-18 15:30:43 +02:00
  d0678bfbee
• feat: Support filtering for multiple statuses
  Vlad Frangu · 2024-03-16 21:32:55 +02:00
  0a6960296e
• Add flag to allow backwards seeks in tests
  Dean Herbert · 2024-02-29 23:05:28 +08:00
  4184a5c1ef
• Fix test failure on leap years
  Detze · 2024-02-29 07:36:35 +01:00
  caad89a4dd
• Improve test coverage
  Bartłomiej Dach · 2024-02-14 16:19:32 +01:00
  f7bea00564
• Rename test
  Bartłomiej Dach · 2024-02-14 15:59:07 +01:00
  f1d69abdc8