Dan Balasescu
976c6c4f25
Merge pull request #28235 from tsunyoku/optimise-rhythm-evaluator-loop-logic
...
Reduce `Previous` calls in `RhythmEvaluator` by optimising loop logic
2024-05-20 20:31:46 +09:00
Dan Balasescu
dedc2d2aa0
Merge pull request #28230 from tsunyoku/remove-extra-rhythm-previous-calls
...
Remove unneeded `Previous` calls from `RhythmEvaluator`
2024-05-20 04:37:14 +09:00
James Wilson
f31928875b
Reduce Previous calls in RhythmEvaluator by optimising loop logic
2024-05-19 16:26:51 +01:00
James Wilson
609268786f
remove unneeded extra Previous calls from RhythmEvaluator
2024-05-19 13:29:49 +01:00
Dean Herbert
5e1f6964d1
Merge pull request #28213 from bdach/fix-realm-migration-fail
...
Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded
2024-05-19 15:55:36 +08:00
Bartłomiej Dach
be642c8c42
Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded
...
Closes https://github.com/ppy/osu/issues/28209 .
Yes this means that such scores will have a zero total score without
mods in DB and thus might up getting their total recalculated to zero
when we try a mod multiplier rebalance (unless we skip scores with zero
completely I suppose). I also don't really care about that right now.
2024-05-19 09:43:33 +02:00
Dean Herbert
9fcd3b562a
Merge pull request #28201 from frenzibyte/fix-settings-padding
...
Fix checkboxes looking misaligned when placed next to a slider bar
2024-05-19 10:36:54 +08:00
Dean Herbert
9c559d91f1
Merge pull request #28205 from EVAST9919/control-point-nesting
...
Reduce container nesting inside `PathControlPointPiece`
2024-05-19 08:37:57 +08:00
Andrei Zavatski
614cbdf0a4
Reduce container nesting in PathControlPointPiece
2024-05-18 22:51:58 +03:00
Dean Herbert
7b847ad815
Merge pull request #28182 from frenzibyte/footer-v2-renamings
...
Rename and move new footer classes to appropriate places
2024-05-18 22:14:45 +08:00
Salman Ahmed
a912e56ca9
Fix checkboxes applying extra padding
2024-05-18 11:06:29 +03:00
Dan Balasescu
9532725eb7
Merge pull request #28198 from frenzibyte/remove-warnaserror-from-local-builds
...
Remove `TreatWarningsAsErrors` flags from local builds for developer convenience
2024-05-18 13:40:11 +09:00
Salman Ahmed
2027d481ee
Remove TreatWarningsAsErrors flags from local builds for developer convenience
2024-05-18 06:38:25 +03:00
Bartłomiej Dach
badda23dde
Merge pull request #28191 from bdach/fix-mismatching-localisation-xmldoc
...
Fix xmldoc mismatches in localisation files
2024-05-17 09:22:55 +02:00
Bartłomiej Dach
e604a99053
Merge branch 'master' into fix-mismatching-localisation-xmldoc
2024-05-17 08:47:14 +02:00
Dan Balasescu
2f9d74286d
Bump once more
2024-05-17 11:15:17 +09:00
Dan Balasescu
06d6df95de
Merge pull request #28190 from bdach/fix-duped-translation-keys
...
Fix duplicated localisation key in `DeleteConfirmationContentStrings`
2024-05-17 11:03:15 +09:00
Dan Balasescu
a2e67ee699
Merge pull request #28193 from bdach/what-is-discord-doing
...
Fix discord arbitrarily refusing to work on "too short" strings
2024-05-17 11:01:36 +09:00
Bartłomiej Dach
a3dfd99f7d
Fix discord arbitrarily refusing to work on "too short" strings
...
Closes https://github.com/ppy/osu/issues/28192 .
2024-05-16 18:24:51 +02:00
Bartłomiej Dach
f2f03f08cb
Fix xmldoc mismatches in localisation files
...
This is enforced by the localisation analyser after
https://github.com/ppy/osu-localisation-analyser/pull/62 , but it appears
the analyser was never actually bumped game-side after that change and
I'm not super sure why, as there does not appear to be a reason to _not_
do that. So this commit does it.
2024-05-16 17:39:27 +02:00
Bartłomiej Dach
5dd64a7c86
Fix duplicated localisation key in DeleteConfiormationContentStrings
...
Noticed via `osu-resources` build warnings.
There are also a few other warnings about
https://github.com/ppy/osu/pull/27472 . Seems something in crowdin
innards may still be exporting those strings even though they have been
fixed already. Not sure how to address that.
Probably need these to be detected via static analysis at this point
since it's happened again. Might look into the feasibility of making
that happen.
2024-05-16 14:49:56 +02:00
Dean Herbert
f9fd1b957f
Merge pull request #28186 from bdach/revert-wide-columns-on-mobile
2024-05-16 19:15:35 +08:00
Bartłomiej Dach
97de73b99c
Do not change mania column width on mobile platforms
...
- Closes https://github.com/ppy/osu/issues/25852
- Reverts https://github.com/ppy/osu/pull/25336 /
https://github.com/ppy/osu/pull/25777
With the columns not being directly touchable anymore after
https://github.com/ppy/osu/pull/28173 I see very little point to this
continuing to exist.
2024-05-16 08:21:52 +02:00
Salman Ahmed
21f5d891bb
Rename and move footer classes to appropriate places
2024-05-16 04:41:16 +03:00
Dean Herbert
a3960bf715
Add inline comment explaining LifetimeEnd set for future visitors
2024-05-15 14:17:28 +08:00
Bartłomiej Dach
d52dffefbc
Merge pull request #28173 from peppy/mania-touch-input-revised
...
Add more usable osu!mania touch input system
2024-05-14 19:28:48 +02:00
Bartłomiej Dach
7c1640e124
Merge pull request #28170 from peppy/fix-catch-dho-performance
...
Set a rudimentary lifetime end to improve seek performance in scrolling rulesets
2024-05-14 19:27:40 +02:00
Bartłomiej Dach
3d190f7e88
Remove redundant cast
2024-05-14 18:41:15 +02:00
Bartłomiej Dach
dae1686e7b
Merge pull request #28174 from peppy/load-while-logo-drag
...
Continue loading even when osu! logo is being dragged at loading screen
2024-05-14 18:39:03 +02:00
Dean Herbert
cff865b556
Continue loading even when osu! logo is being dragged at loading screen
...
Closes https://github.com/ppy/osu/issues/28130 .
2024-05-14 23:54:07 +08:00
Dean Herbert
c31b503f2a
Merge pull request #28171 from bdach/present-score-different-hashes
...
Use hash rather than online ID as primary lookup key when presenting score
2024-05-14 23:39:54 +08:00
Dean Herbert
d74be8b920
Merge pull request #28172 from bdach/nrt-results-classes
...
Apply NRT to results-related components
2024-05-14 23:01:24 +08:00
Dean Herbert
f781dc3300
Remove touch mod addition to mania
...
Feels a bit pointless? I dunno.
2024-05-14 22:38:31 +08:00
Dean Herbert
636e200471
Update tests in line with new structure
2024-05-14 22:34:05 +08:00
Dean Herbert
5c9a90cb40
Tidy class and change to be a VisibilityContainer similar to taiko implementation
2024-05-14 22:34:05 +08:00
Dean Herbert
390557634a
Rename touch area class to match existing usage (see taiko)
2024-05-14 22:34:05 +08:00
Dean Herbert
12e98fe55d
Move out of playfield so touch overlay is not affected by playfield position
2024-05-14 22:34:05 +08:00
Bartłomiej Dach
ee9144c3bd
Apply NRT to results statistics displays
2024-05-14 15:21:12 +02:00
Bartłomiej Dach
414f023817
Apply NRT to RankText
2024-05-14 15:21:05 +02:00
Bartłomiej Dach
b937b94bd2
Apply NRT to RankBadge
2024-05-14 15:20:56 +02:00
Bartłomiej Dach
ced1c79490
Apply NRT to AccuracyCircle
2024-05-14 15:20:47 +02:00
Bartłomiej Dach
e7721b073c
Apply NRT to ContractedPanelTopContent
2024-05-14 15:20:36 +02:00
Bartłomiej Dach
8e16b57d09
Apply NRT to SimpleStatisticTable
2024-05-14 15:20:26 +02:00
Bartłomiej Dach
237ae8b46a
Apply NRT to SimpleStatisticsItem
2024-05-14 15:20:17 +02:00
Bartłomiej Dach
2f2257f6ce
Apply NRT to PerformanceBreakdownChart
2024-05-14 15:20:07 +02:00
Bartłomiej Dach
77a7f475ee
Apply NRT to ScorePanel
2024-05-14 15:19:58 +02:00
Bartłomiej Dach
10a8e84046
Apply NRT to StatisticsPanel
2024-05-14 15:19:46 +02:00
Bartłomiej Dach
cb49147d1e
Apply NRT to ScorePanelList
2024-05-14 15:19:43 +02:00
Dan Balasescu
a761a7bced
Hook up touch device mod
2024-05-14 19:14:58 +08:00
Dan Balasescu
e3f2e1ba08
Add opacity setting
2024-05-14 19:14:50 +08:00
