45041 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into wiki-article
  Bartłomiej Dach · 2021-06-09 16:24:45 +02:00
  7fe878299f
• Update framework
  Dean Herbert · 2021-06-09 20:29:06 +09:00
  f113c095ce
• Merge pull request #13405 from ekrctb/fix-circle-piece-2

  Fix circle piece animation sometimes not playing when a replay is rewound (again)

  Dean Herbert · 2021-06-09 19:48:59 +09:00
  ca02e8e5d3
• Merge pull request #13381 from smoogipoo/improve-hit-error-judgements

  Improve hit error judgement displays

  Dean Herbert · 2021-06-09 19:40:17 +09:00
  b02b8ae2bc
• Fix wrong naming scheme for applause samples
  Dean Herbert · 2021-06-09 19:35:05 +09:00
  31b46afa71
• Simplify tick calculation/playback method
  Dean Herbert · 2021-06-09 19:31:53 +09:00
  7d86dafd4f
• Add back another missing space...
  Dean Herbert · 2021-06-09 19:27:43 +09:00
  c8947daee3
• Move consts closer to usage
  Dean Herbert · 2021-06-09 19:24:35 +09:00
  57bc34f224
• Move forgotten private function down more
  Dean Herbert · 2021-06-09 19:15:55 +09:00
  cb4f366651
• Move tick rate initialisation to earlier
  Dean Herbert · 2021-06-09 19:09:00 +09:00
  81cecac90b
• Simplify sample construction logic and move private functions down
  Dean Herbert · 2021-06-09 19:06:37 +09:00
  499aba95c0
• Merge branch 'master' of https://github.com/ppy/osu into auto-restart
  PercyDan54 · 2021-06-09 18:05:47 +08:00
  510fc93d76
• Add back missing space in csproj
  Dean Herbert · 2021-06-09 19:01:05 +09:00
  489a5a3c1d
• Rename variable back to withFlair to match parent class
  Dean Herbert · 2021-06-09 18:55:29 +09:00
  21a63efd78
• Remove unnecessary skin lookup logic
  Dean Herbert · 2021-06-09 18:55:29 +09:00
  330bb7cb45
• Add fallback lookup support for DefaultSkin
  Dean Herbert · 2021-06-09 18:51:42 +09:00
  0cf7c56e7e
• Merge branch 'master' into results-screen-sfx
  Dean Herbert · 2021-06-09 18:00:11 +09:00
  8fda04c2d9
• Fix SourceChanged not being correctly forwarded through LegacySkinTransformer
  Dean Herbert · 2021-06-09 17:56:07 +09:00
  2438c20d63
• Remove redundant string interpolation
  Dean Herbert · 2021-06-09 17:34:47 +09:00
  47eeab34e1
• Add a simple fade to the results screen

  Stops it from immediately disappearing.

  Dean Herbert · 2021-06-09 17:19:37 +09:00
  a65b76bdbf
• Fix results screen changing applied colour to background on exit

  The general rule is that screens should only apply colours and the likes
  on enter / resume, and leave the outwards transition to whatever screen
  is coming next.

  Dean Herbert · 2021-06-09 17:18:55 +09:00
  7b0c5e9d32
• Ensure PlayerLoader restores the background colour to its own value on resume
  Dean Herbert · 2021-06-09 17:17:39 +09:00
  258d05d1e0
• Add safety to ensure background is correct tint when entering gameplay
  Dean Herbert · 2021-06-09 17:07:28 +09:00
  a7ef0173e9
• Remove useless ClearTransforms

  The transforms are cleared by DHO before `ApplyCustomUpdateState` is invoked.

  ekrctb · 2021-06-09 16:50:13 +09:00
  5418e895ae
• Merge pull request #13402 from peppy/mania-key-lookup-fix

  Use candidate skin for mania skin key lookup rather than `this`

  Dan Balasescu · 2021-06-09 16:35:55 +09:00
  50eb58ecd3
• Merge pull request #13393 from bdach/fix-skin-background-regression

  Bring back skin background source

  Dean Herbert · 2021-06-09 16:34:57 +09:00
  17ad214e0e
• Fix inspectcode issues
  Bartłomiej Dach · 2021-06-09 09:21:02 +02:00
  020c63017e
• Fix FindProvider calls on SkinProvidingContainer not considering disable flags

  Closes #13394.

  Dean Herbert · 2021-06-09 16:19:04 +09:00
  448e4e7ee5
• Add failing test coverage for beatmap skin disable
  Dean Herbert · 2021-06-09 16:19:04 +09:00
  38fc9347be
• Fix circle piece animation is sometimes not playing when a replay is rewound
  ekrctb · 2021-06-09 16:14:55 +09:00
  610cdaea98
• Check skin version for legacy catcher sprite
  ekrctb · 2021-06-09 15:47:23 +09:00
  e5deecf459
• Merge branch 'master' into fix-skin-background-regression
  Bartłomiej Dach · 2021-06-09 08:09:21 +02:00
  023015f9a6
• Merge pull request #13400 from peppy/remove-obsoleted-drawable-judgement-methods

  Remove some obsoleted members

  Dan Balasescu · 2021-06-09 15:01:25 +09:00
  8a221f501d
• Use candidate skin for mania skin key lookup rather than this
  Dean Herbert · 2021-06-09 15:00:55 +09:00
  d248bbd4c8
• Ensure background rotation on default skins
  Bartłomiej Dach · 2021-06-09 07:59:47 +02:00
  a801a9a14d
• Add test coverage for default skin background cycling
  Bartłomiej Dach · 2021-06-09 07:48:16 +02:00
  5487012060
• Remove difficulty calculator exceptions

  I don't think there's any reason difficulty calculators shouldn't be
  able to calculate for autoplays.

  Dean Herbert · 2021-06-09 14:33:35 +09:00
  85abee5fc7
• Update ModAutoplay matching to use new UserPlayable flag instead
  Dean Herbert · 2021-06-09 14:32:48 +09:00
  b754c52392
• Fix incorrect method referenced in xmldco

  Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

  Dean Herbert · 2021-06-09 14:20:01 +09:00
  b8df3fff9e
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Add one missing obsoletion removal date
  Dean Herbert · 2021-06-09 14:11:50 +09:00
  62199a38a8
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Remove "Unranked" text from ModDisplay
  Dean Herbert · 2021-06-09 13:45:09 +09:00
  7774344f0e
• Reword "unranked" to "not ranked" on beatmap overlay

  This will be replaced anyway once we start to consume osu-web
  translation strings.

  Dean Herbert · 2021-06-09 13:44:27 +09:00
  249a8f259b
• Merge pull request #13397 from ekrctb/fix-event-not-unregistered

  Fix registered event not unregistered on dispose

  Dean Herbert · 2021-06-09 13:12:06 +09:00
  2f6227e0f2
• Fix event not unregistered on dispose
  ekrctb · 2021-06-09 12:35:14 +09:00
  555ab8fccd
• Merge pull request #13396 from ekrctb/fix-circle-piece

  Fix hit circle animation is removed when a replay is rewound

  Dean Herbert · 2021-06-09 11:39:38 +09:00
  e914fbf449
• Fix hit circle animation when a replay is rewound
  ekrctb · 2021-06-09 10:53:52 +09:00
  4707918c6a
• Reduce unnecessary background changes via IEquatable implementation
  Bartłomiej Dach · 2021-06-08 22:37:18 +02:00
  97204b6f27