125 Commits

Author	SHA1	Message	Date
tsrk	a4e146ad9b	style: remove usage of HIT_FLOURISH ... Unaware clueless usage	2023-09-01 21:02:43 +02:00
tsrk	2e2dcd99a6	fix(AudioCheckUtils): use Path.GetExtension() ... To avoid filename escaping	2023-09-01 20:56:54 +02:00
tsrk	5f00d3e2a4	style: convert to using declaration for less nesting	2023-09-01 20:54:02 +02:00
tsrk	5ecd5142d8	fix(AudioCheckUtils): add license header	2023-08-29 23:27:15 +02:00
tsrk	b3d432b0d5	fix: issue template typo in CheckDelayedHitsounds	2023-08-29 20:15:33 +02:00
tsrk	c1a7ad09b4	style: move common audio utils to separate static class	2023-08-29 20:10:35 +02:00
tsrk	a7a64b57e9	fix: use using statement for waveform auto-disposal	2023-08-29 19:46:19 +02:00
tsrk	a04333c17b	style: use HitSampleInfo.All properties	2023-08-29 19:42:37 +02:00
tsrk	29a46f5b36	style(editor/checks): add issues for delays with no silence	2023-08-25 11:46:09 +02:00
tsrk	4c32e9a479	style: use more rigorous hitsound filtering	2023-08-25 00:37:45 +02:00
tsrk	50dbf564a5	revert: use old wording ... This makes more sense wrt to the complete silence thing. Refs: f7599c5b	2023-08-24 23:52:41 +02:00
tsrk	f7599c5bc4	style: reword	2023-08-24 23:41:56 +02:00
tsrk	273593a0ee	style: typo	2023-08-24 23:25:42 +02:00
tsrk	208e94e9be	style(editor/checks): add type nullability for Stream	2023-08-24 21:33:54 +02:00
tsrk	df55a2f683	style(editor/checks): fix inconsistent argument names	2023-08-24 21:31:28 +02:00
tsrk	a885bf6ebf	feat(editor/checks): check for delayed hitsounds ... I really just borrowed the implementation from MapsetVerifier	2023-08-24 21:05:40 +02:00
Dean Herbert	9cfe9164fa	Add helper method to get drain length (and rename some usages)	2023-07-25 16:58:41 +09:00
Bartłomiej Dach	699b66be42	Do not reimplement binary sort manually	2023-07-22 17:12:21 +02:00
NiceAesth	fa29c25097	Change check to use binary search	2023-07-20 00:32:35 +03:00
NiceAesth	ff529d9df7	Rename variables, fix check message formatting	2023-07-17 20:48:53 +03:00
NiceAesth	3888471148	Add break length and bounds checks	2023-07-16 23:03:21 +03:00
NiceAesth	1dae1d8f0a	Account for break time	2023-07-11 13:40:19 +03:00
NiceAesth	9a2915f423	Add beatmap minimum length checks	2023-07-10 17:29:49 +03:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dean Herbert	a842f79ad4	Refactor IWorkingBeatmap.Background to GetBackground()	2023-06-08 16:19:32 +09:00
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
Dean Herbert	5b3d7a8f26	Fix typo in missing-preview-point message	2023-02-02 14:34:59 +09:00
Dean Herbert	c2cde8361a	Fix message not reading well	2023-02-02 14:33:41 +09:00
Dean Herbert	3a861fd943	Remove multiple cases of excess braces	2023-02-02 14:28:21 +09:00
cdwcgt	76296eb35a	Consistent with BeatmapsetVerifier	2023-02-01 11:52:14 +08:00
cdwcgt	5afb733fb2	change IssueTemplatePreviewTimeConflict's text	2023-01-23 15:26:28 +09:00
cdwcgt	e5eab72aeb	add check for preview time setting	2023-01-19 01:08:37 +09:00
andy840119	a1a9238bd1	Use empty string instead of null because issue template not accept null.	2022-10-30 16:31:07 +08:00
andy840119	505ec800da	File name should be nullable.	2022-10-30 16:29:54 +08:00
andy840119	db48a57fa7	Remove nullable disable annotation in some checks class.	2022-10-30 16:28:49 +08:00
andy840119	24c27e62f6	Remove nullable disable annotation in the issue and issue template-related class.	2022-10-30 16:25:15 +08:00
Dean Herbert	ac99c1ad69	Migrate the majority of existing file lookups to use new extension methods	2022-08-10 16:01:16 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Dean Herbert	eb70a1eeb7	Replace compatibility properties with direct references	2022-01-12 18:13:14 +09:00
Dean Herbert	3811bd8520	Fix some null inspections	2022-01-12 17:00:16 +09:00
Dean Herbert	59e763467f	Move StoragePath implementation to an extension method	2021-11-19 16:08:38 +09:00
Naxesss	b888185799	Properly dispose of Stream in bg quality check	2021-11-10 05:06:11 +01:00
Dean Herbert	e43d91ad5d	Fix another case of incorrect null checking in editor verification processing	2021-11-04 15:18:10 +09:00
Dean Herbert	1e73b09e57	Fix another couple of cases of incorrect string null/empty checking	2021-11-04 14:22:28 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Bartłomiej Dach	c7db286b94	Merge branch 'master' into file-sanity-checks	2021-10-14 00:17:29 +02:00
Dean Herbert	82f7f99f37	Refactor to use scoped using (and also correctly dispose TagLib portion)	2021-10-12 10:46:26 +09:00
Naxesss	f2f97602f2	Dispose of video resource later ... We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.	2021-10-12 00:40:39 +02:00