Dan Balasescu
af7d35bfbf
Doubly quote strings
...
Note the external-action case (currently used for tags) doesn't match
osu!web but it doesn't matter because tags are single words
anyway.
2024-10-23 16:15:49 +09:00
Dean Herbert
7df3976d1c
Merge pull request #30284 from bdach/mania-selection-preservation-again
...
Fix flip operations sometimes not preserving selection in mania editor
2024-10-23 16:13:20 +09:00
Dean Herbert
5939c78760
Merge branch 'master' into auto-addition2
2024-10-23 15:53:07 +09:00
Dean Herbert
2103b3e186
Merge pull request #28863 from OliBomby/additions
...
Add toggles and hotkeys for configuring sample addition bank
2024-10-23 15:52:55 +09:00
Dean Herbert
21351b1be4
Quote source text when searching for it via click
...
Addresses https://github.com/ppy/osu/discussions/30181 .
2024-10-23 15:41:42 +09:00
Dan Balasescu
71eb7120ba
Merge pull request #27691 from Finadoggie/estimation-removal
...
Remove estimations where score data is available for osu! difficulty calculations
2024-10-23 00:59:34 +09:00
Bartłomiej Dach
1008d32ddb
Fix old looping samples not stopping when replacing a SkinnableSound's Samples
...
Closes https://github.com/ppy/osu/issues/30365 .
2024-10-22 14:35:21 +02:00
Dean Herbert
53a340938a
Merge pull request #30377 from bdach/very-bad-completely-no-good-comparer
...
Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted
2024-10-22 20:20:03 +09:00
Bartłomiej Dach
24dfc1b66e
Merge pull request #30328 from TaterToes/seekingControlPointFix
...
Add breathing room to seek back between control points in editor
2024-10-22 13:14:24 +02:00
Dean Herbert
213be029ed
Merge pull request #30382 from Maks1mio/ChatChannelListSearch
...
Add search box to chat overlay
2024-10-22 20:10:53 +09:00
Dean Herbert
e37d415c6f
Keep editor sidebars expanded by default
...
They will not only contract if the user chooses to have them contract
(new setting in the `View` menu) or if the game isn't wide enough to
allow full interaction with the playfield while they are expanded.
Addressess https://github.com/ppy/osu/discussions/28970 .
2024-10-22 20:08:50 +09:00
Bartłomiej Dach
54aeeaa529
Add test coverage
2024-10-22 12:29:34 +02:00
Bartłomiej Dach
2ab68c6ab9
Select first filtered channel on search box commit
2024-10-22 12:29:23 +02:00
Bartłomiej Dach
826b35e031
Use SearchContainer instead of manual search implementation
2024-10-22 12:29:20 +02:00
Dean Herbert
c15490ed58
Merge pull request #30146 from bdach/lookup-users-endpoint
...
Fix currently online display hitting rate limits
2024-10-22 19:24:14 +09:00
Dean Herbert
7b3376ccd6
Merge pull request #30385 from peppy/fix-selection-lost-during-update
...
Fix beatmap selection being lost during update process
2024-10-22 19:24:01 +09:00
Dean Herbert
3158338fe4
Merge pull request #30137 from bdach/send-mods-in-frame-headers
...
Send mods in spectator frame headers
2024-10-22 19:23:21 +09:00
Dean Herbert
187fa5eccd
Use full async flow rather than ContinueWith
2024-10-22 18:48:01 +09:00
Dean Herbert
6ea1623889
Merge branch 'master' into lookup-users-endpoint
2024-10-22 18:48:00 +09:00
Bartłomiej Dach
256d8c6559
Move search box to the top, remove redundant heading, and use existing search box
2024-10-22 11:28:59 +02:00
Bartłomiej Dach
84e08d96ca
Merge pull request #30330 from jhk2601/mod_acronym_search_fix
...
Prioritize selecting exact searched acronym with select keybind
2024-10-22 11:20:06 +02:00
Dean Herbert
a35551ecd9
Merge pull request #30383 from CloneWith/feature/placeholder-hoverbk
...
Add hover background back to `ClickablePlaceholder`
2024-10-22 18:17:36 +09:00
Dean Herbert
16bc188ba7
Refactor code to read better (and adjust lenience to match stable)
2024-10-22 18:08:25 +09:00
Dean Herbert
e1a950e2d3
Fix beatmap selection being lost during update process
...
Broke due to something changing in the way we handle realm things in the
carousel. The deselection happens in `updateBeatmapSet` so we need to
store / check the original selection before this occurs.
Doesn't seem this had test coverage? Probably implies that the overhead
of adding a test was very large, so maybe best to leave it that way.
2024-10-22 17:53:34 +09:00
Bartłomiej Dach
9258916fa8
Merge pull request #30263 from frenzibyte/editor-slider-touch-support-1
...
Fix drawing slider with touch inserts a random control point at beginning
2024-10-22 10:29:30 +02:00
Dean Herbert
13fba9f92e
Adjust glow slightly
2024-10-22 17:16:09 +09:00
Bartłomiej Dach
03683e28be
Merge branch 'master' into editor-slider-touch-support-1
2024-10-22 09:31:03 +02:00
Dan Balasescu
1bdae2af41
Merge pull request #30379 from peppy/dont-delete-scores
...
Don't delete scores when deleting beatmaps
2024-10-22 14:22:14 +09:00
Dan Balasescu
17702ead0b
Fix ruleset not being reset correctly in tests
2024-10-22 14:20:10 +09:00
EvT
17cd411567
Added search box to ChannelGroup Private Message
2024-10-22 01:33:53 +03:00
Dean Herbert
cbaee98674
Don't delete scores when deleting beatmaps
...
The score model's spec allows for null `BeatmapInfo` so the reasoning of
the inline comment is no longer valid. We match based on hash these
days.
2024-10-22 01:39:05 +09:00
Bartłomiej Dach
455ed0607f
Merge pull request #30346 from wezwery/perfect-combo-and-accuracy-highlighted
...
Highlight maximum combo and accuracy on user best score display to match web
2024-10-21 15:34:03 +02:00
CloneWith
9940be818d
Add hover color back to ClickablePlaceholder
2024-10-21 21:09:26 +08:00
Bartłomiej Dach
dbc2e78dd9
Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted
...
Closes https://github.com/ppy/osu/issues/30324 .
2024-10-21 14:48:57 +02:00
Bartłomiej Dach
d6497640d9
Add failing test case
2024-10-21 14:44:09 +02:00
Bartłomiej Dach
1e03bd11a3
Fix test compile failures
2024-10-21 13:57:34 +02:00
Bartłomiej Dach
0a15eec7de
Remove unused using directive
2024-10-21 13:52:17 +02:00
Bartłomiej Dach
22c3a25575
Merge pull request #30326 from jhk2601/barrel_roll_fix
...
Fix cursor rotating with barrel roll mod active
2024-10-21 13:51:28 +02:00
Bartłomiej Dach
e89a4561ab
Fix playfield skinning layer no longer correctly rotating with the playfield
...
Closes https://github.com/ppy/osu/issues/30353 .
Regressed in
4a39873e2a
2024-10-21 13:49:12 +02:00
Bartłomiej Dach
3111844809
Merge pull request #30373 from smoogipoo/tone-down-ternary-warning
...
Change convert-to-ternary warning to hint
2024-10-21 12:51:46 +02:00
Bartłomiej Dach
a90ad63493
Change property type
...
Nobody is supposed to be using `ColourInfo` directly, really.
2024-10-21 12:47:41 +02:00
Bartłomiej Dach
59e9ed7bac
Add test coverage
2024-10-21 12:44:01 +02:00
Bartłomiej Dach
8349226d9f
Merge branch 'master' into barrel_roll_fix
2024-10-21 12:33:37 +02:00
StanR
acf282dddd
Fix effectiveMissCount being calculated wrong
2024-10-21 15:06:34 +05:00
StanR
bcb997028e
Refactor and add comments
2024-10-21 14:38:03 +05:00
Dan Balasescu
fc0ec20db9
Change convert-to-ternary warning to hint
2024-10-21 18:26:42 +09:00
finadoggie
98800fea71
Fix variables being used before being assigned
...
slightly miffed by the lack of build errors but oh well
2024-10-21 00:34:26 -07:00
finadoggie
5907c2a1c4
Only clamp estimated miss count with relevant statistics
2024-10-20 22:47:02 -07:00
finadoggie
3778246a55
Addressed code quality concerns
2024-10-20 22:15:15 -07:00
finadoggie
e31e10d616
merge effectivemisscount functions
...
having two functions was unnecessary
2024-10-20 21:47:01 -07:00
