54057 Commits

This Branch

This Branch

All Branches

• Remove the null check.
  andy840119 · 2022-08-02 23:14:08 +08:00
  8d175bc402
• give the object a default value(null).
  andy840119 · 2022-08-02 23:02:14 +08:00
  c8c2758d63
• give the field a default value.
  andy840119 · 2022-08-02 22:29:54 +08:00
  13b2441c51
• Prevent return the null value.
  andy840119 · 2022-08-02 22:29:54 +08:00
  11a4bb5833
• Remove nullable disable annotation and fix the api broken.
  andy840119 · 2022-08-02 22:29:54 +08:00
  78cc28d75f
• Merge pull request #19479 from frenzibyte/carousel-update-on-resume

  Fix song select not updating selected beatmap card on editor resume

  Dean Herbert · 2022-08-02 00:48:18 +09:00
  01cc9bd7ef
• Merge pull request #16589 from mk56-spn/Wiggle-strength-duration

  Add strength setting for wiggle mod

  Dean Herbert · 2022-08-02 00:03:53 +09:00
  c53a4f1c45
• Rename variable to not include mode name itself
  Dean Herbert · 2022-08-01 23:30:00 +09:00
  a5fac70c3b
• Merge branch 'master' into Wiggle-strength-duration
  Dean Herbert · 2022-08-01 23:29:03 +09:00
  d09976bb39
• Merge pull request #19500 from andy840119/remove-nullable-disable-in-the-audio-namespace

  Remove nullable disable annotation in audio namespace

  Salman Ahmed · 2022-08-01 15:59:19 +03:00
  49ee78babb
• Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace
  Salman Ahmed · 2022-08-01 15:25:12 +03:00
  7c9f8648a5
• Merge pull request #19262 from goodtrailer/stable-slider-tick-anims

  Imitate stable's slider followcircle tick-based behavior

  Dean Herbert · 2022-08-01 21:11:33 +09:00
  8ef777405d
• Merge branch 'master' into stable-slider-tick-anims
  Salman Ahmed · 2022-08-01 15:01:09 +03:00
  03eccc2f7e
• Remove canBeNull: true.
  andy840119 · 2022-08-01 19:45:15 +08:00
  6cccb6b848
• Merge pull request #19508 from gutyina70/fix-tags-overflow

  Prevent tags overflowing on beatmap info overlay

  Salman Ahmed · 2022-08-01 13:16:04 +03:00
  2465e8ed68
• Merge branch 'master' into fix-tags-overflow
  Salman Ahmed · 2022-08-01 12:40:43 +03:00
  2a127c6ef8
• Merge pull request #19516 from peppy/fix-editor-track-disposal-crash

  Fix editor potentially playing a track post-disposal

  Dan Balasescu · 2022-08-01 18:12:21 +09:00
  d4eec9122f
• Update animations to final versions
  Dean Herbert · 2022-08-01 18:03:32 +09:00
  e0940c6c22
• Merge branch 'master' into stable-slider-tick-anims
  Dean Herbert · 2022-08-01 18:03:22 +09:00
  0b8d3cbce9
• Merge pull request #19517 from peppy/add-more-missing-realm-refreshres

  Add more missing realm `Refresh()` calls to new beatmap import tests

  Dan Balasescu · 2022-08-01 17:54:51 +09:00
  225033c3b2
• Merge pull request #19514 from peppy/dont-throw-copy-failure-migration

  Fix migration failing on single file copy failure

  Dean Herbert · 2022-08-01 17:43:05 +09:00
  14c2348df7
• Merge branch 'master' into stable-slider-tick-anims
  Dean Herbert · 2022-08-01 17:40:16 +09:00
  0d9edcfa24
• Use masking instead of scrollable container to prevent tags overflow
  Gutyina Gergő · 2022-08-01 10:36:53 +02:00
  c65747d1b8
• Merge pull request #19513 from peppy/isolate-development-storage

  Isolate development builds' storage from release builds

  Dan Balasescu · 2022-08-01 17:30:25 +09:00
  5f9c3b42e8
• Merge pull request #19504 from peppy/skin-serialisation-test-coverfage

  Add test coverage of deserialisation of skin layouts

  Dan Balasescu · 2022-08-01 17:17:16 +09:00
  1d27c4f020
• Merge pull request #19467 from frenzibyte/taiko-samples-priority

  Allow osu!taiko hitsounds to fall back to classic skin rather than use non-taiko samples

  Dean Herbert · 2022-08-01 17:10:50 +09:00
  e0aaacc419
• Add more missing realm Refresh() calls to new beatmap import tests

  As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true

  Dean Herbert · 2022-08-01 17:06:46 +09:00
  ee68113913
• Re-query file existence before failing a recursive copy operation during migration
  Dean Herbert · 2022-08-01 17:01:19 +09:00
  cc8a71b65d
• Revert "Fix migration failing on single file copy failure"

  This reverts commit fc8835d43a.

  Dean Herbert · 2022-08-01 16:57:50 +09:00
  59210ecc9d
• Fix changes to audio / background not triggering an editor state change
  Dean Herbert · 2022-08-01 16:53:49 +09:00
  6e7c298aaf
• Fix editor potentially using a track post-disposal

  This changes the editor to track the current track as it is *loaded* by
  `MusicController`, rather than haphazardly following the current global
  `WorkingBeatmap` (with a potentially unloaded track) or relying on local
  immediate-load behaviour (as implemented in `ResourcesSection`).

  Dean Herbert · 2022-08-01 16:53:49 +09:00
  2f60f91a0e
• Add test coverage of editor crash
  Dean Herbert · 2022-08-01 16:53:49 +09:00
  2519706ad6
• Remove unused using
  Dan Balasescu · 2022-08-01 16:33:59 +09:00
  47860bb966
• Fix migration failing on single file copy failure

  No longer throw if copying of single files fails during data migration.
  
  Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).
  
  If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).
  
  Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.

  Dean Herbert · 2022-08-01 15:02:39 +09:00
  fc8835d43a
• Merge pull request #19407 from andy840119/remove-nullable-disable-in-the-mods-for-osu-ruleset

  Remove nullable disable annotation in mods for osu ruleset.

  Dan Balasescu · 2022-08-01 14:51:48 +09:00
  5335d60748
• Merge pull request #19510 from bdach/mod-overlay/presets-persistence

  Add persistence of mod presets to realm

  Dean Herbert · 2022-08-01 14:43:52 +09:00
  8ee4f1e60b
• Isolate development builds' storage from release builds
  Dean Herbert · 2022-08-01 14:38:02 +09:00
  a5f48e336a
• Add test coverage of remaining components which weren't already included
  Dean Herbert · 2022-08-01 14:16:26 +09:00
  3b6349a145
• Improve test coverage of skin serialisation to ensure full coverage

  Will fail when new skinnable components are added until they have
  coverage in resources.

  Dean Herbert · 2022-08-01 14:04:12 +09:00
  d112743cea
• Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components
  Dean Herbert · 2022-08-01 14:04:08 +09:00
  5b98a73edc
• Remove unnecessary AsNonNull()
  Dan Balasescu · 2022-08-01 13:22:58 +09:00
  415d6def2d
• Merge pull request #19507 from naipofo/playlist-capture-fix

  Prevent capturing arrow keys on playlist creation.

  Dan Balasescu · 2022-08-01 11:46:00 +09:00
  195396309a
• Fix code quality inspection about ambiguous equality
  Bartłomiej Dach · 2022-07-31 23:53:46 +02:00
  85f77abee1
• Fix test breakage after realm migration
  Bartłomiej Dach · 2022-07-31 23:53:46 +02:00
  5a34122a85
• Fix test scene to handle restarts properly
  Bartłomiej Dach · 2022-07-31 23:53:46 +02:00
  9d3cdae4bb
• Add test coverage of preset soft deletion
  Bartłomiej Dach · 2022-07-31 23:53:46 +02:00
  9dea8e3d12
• Add extended test coverage of preset realm subscription
  Bartłomiej Dach · 2022-07-31 23:53:45 +02:00
  c837848238
• Migrate mod preset column to use realm
  Bartłomiej Dach · 2022-07-31 23:53:45 +02:00
  345f103119
• remove unneded guard
  notmyname · 2022-07-31 23:42:20 +02:00
  fa3b9ee32f
• Convert ModPreset to realm object
  Bartłomiej Dach · 2022-07-31 22:10:15 +02:00
  cbabc4886c