69319 Commits

This Branch

This Branch

All Branches

• Merge pull request #30017 from peppy/file-picker-hover-states

  Add basic hover states for file selector elements

  Bartłomiej Dach · 2024-09-27 08:57:16 +02:00
  8ca68be5fe
• Merge pull request #29936 from u4vh3/skinning-colour-customisation

  Add colour customisation to layout editor

  Dean Herbert · 2024-09-27 14:20:58 +09:00
  5efdc6cdd7
• Move dependent files to namespace
  Dean Herbert · 2024-09-27 14:00:54 +09:00
  eacd9b9756
• Add basic hover states for file selector elements
  Dean Herbert · 2024-09-27 13:44:37 +09:00
  cbeeb4a2b4
• Merge pull request #30005 from bdach/editor/setup-screen-file-picker

  Implement "form" file picker

  Dean Herbert · 2024-09-27 13:42:52 +09:00
  cec3f1487a
• Update velopack with zstd changes

  Closes https://github.com/ppy/osu/issues/29810.

  Dean Herbert · 2024-09-27 12:48:50 +09:00
  9e9bfc3721
• Merge pull request #29997 from peppy/async-wait-exit-velopack

  Update velopack and switch to using async version of `WaitExitThenApplyUpdates`

  Dan Balasescu · 2024-09-26 21:56:24 +09:00
  33c40079b6
• Implement "form" file picker
  Bartłomiej Dach · 2024-09-26 14:36:24 +02:00
  f4a4807449
• Merge pull request #29983 from bdach/directory-selector-redesign

  Redesign directory & file selector

  Bartłomiej Dach · 2024-09-26 14:14:22 +02:00
  f16f419928
• Reduce size of hidden toggle slightly
  Dean Herbert · 2024-09-26 19:42:31 +09:00
  b1a05f463e
• Merge pull request #29992 from smoogipoo/fix-ios-realm-crashes

  Fix reflection-related iOS crashes

  Dean Herbert · 2024-09-26 17:34:36 +09:00
  78c1426a30
• Add inline comments for iOS locals
  Dean Herbert · 2024-09-26 16:48:42 +09:00
  89e8baf1d3
• Update velopack and switch to using async version of WaitExitThenApplyUpdates
  Dean Herbert · 2024-09-26 01:12:19 +09:00
  df0966abb2
• Inline condition
  Dan Balasescu · 2024-09-25 22:47:37 +09:00
  2fe229d620
• Fix similar Bindable-related crashes
  Dan Balasescu · 2024-09-25 20:59:35 +09:00
  fd4891cf31
• Merge pull request #29986 from OliBomby/refactor-placement-tool

  Refactor placement blueprints to not be limited to hit objects

  Dan Balasescu · 2024-09-25 17:59:43 +09:00
  3111d6a74d
• Merge pull request #29962 from Givikap120/use_max_combo

  Make all difficulty calculators use `GetMaxCombo` function

  Dan Balasescu · 2024-09-25 17:51:49 +09:00
  5b8ae90ec1
• Fix Realm-related iOS crashes by removing object references
  Dan Balasescu · 2024-09-25 16:45:37 +09:00
  3ab04d98f6
• fix warnings
  OliBomby · 2024-09-24 20:32:08 +02:00
  d26e677bb7
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-24 20:31:00 +02:00
  e3b4483872
• Merge pull request #29985 from bdach/user-statistics-update-too-fast

  Fix statistics update not being shown on results screen if it arrives too fast

  Dean Herbert · 2024-09-25 01:35:28 +09:00
  84d7fed23d
• Fix statistics update not being shown on results screen if it arrives too fast

  As reported in
  https://discord.com/channels/188630481301012481/1097318920991559880/1288160137286258799.

  Bartłomiej Dach · 2024-09-24 17:52:19 +02:00
  20e7ade3b0
• Add failing test case
  Bartłomiej Dach · 2024-09-24 17:51:54 +02:00
  555d4ffe89
• Actually use bindables rather than stick things in Update()
  Bartłomiej Dach · 2024-09-24 15:15:28 +02:00
  9f4e48dde7
• Apply NRT to directory & file selectors
  Bartłomiej Dach · 2024-09-24 14:55:05 +02:00
  16fc413a4a
• Redesign directory & file selector (and update usages accordingly)
  Bartłomiej Dach · 2024-09-24 14:54:48 +02:00
  7f8b64bb6d
• Merge pull request #29968 from bdach/cache-for-spectate-screen

  Use cache for beatmap lookups on spectate screen

  Dean Herbert · 2024-09-24 20:59:33 +09:00
  b7d8cb2371
• Merge branch 'master' into skinning-colour-customisation
  Bartłomiej Dach · 2024-09-24 13:02:22 +02:00
  4f57a67ea4
• Merge pull request #29942 from minetoblend/fix/slider-scale-origin

  Fix scaling sliders ignoring the scale origin

  Bartłomiej Dach · 2024-09-24 13:02:04 +02:00
  145f2b6de7
• Simplify accent colour assignment in argon wedge piece
  Bartłomiej Dach · 2024-09-24 12:53:54 +02:00
  4c2ebdb2db
• Remove usage of switch expression syntax

  It's not universally accepted here and a `when` crept in that can be
  bypassed entirely using rather clean baseline language constructs, so
  why bother at this point.

  Bartłomiej Dach · 2024-09-24 11:53:02 +02:00
  86432078dd
• Merge pull request #29966 from bdach/unsafe-deep-clone

  Fix score being cloned in async method causing random errors (again)

  Dean Herbert · 2024-09-23 23:37:46 +09:00
  f08134f443
• Merge pull request #29972 from bdach/editor/setup-screen-dropdown

  Implement "form" dropdown control

  Dean Herbert · 2024-09-23 23:30:25 +09:00
  31e423058d
• Implement "form" dropdown control
  Bartłomiej Dach · 2024-09-23 14:41:39 +02:00
  d6c17f6ac0
• Use cache for beatmap lookups on spectate screen

  @peppy noticed recently that attempting to spectate just a few users was
  very likely to end up in requests very quickly being rejected with code
  429 ("Too Many Requests").
  
  I'm somewhat certain that the reason for that is that a significant
  number of players is wont to retry a lot in quick succession. That means
  that spectator server is going to note a lot of gameplay start and end
  messages in quick succession, too. And as it turns out, every gameplay
  start would end up triggering a new beatmap set fetch request:
  
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Spectate/SpectatorScreen.cs#L131-L134
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Play/SoloSpectatorScreen.cs#L168-L172
  	https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Play/SoloSpectatorScreen.cs#L243-L256
  
  To attempt to curtail that, use the beatmap cache instead, which should
  prevent these unnecessary requests from firing in the first place,
  therefore reducing the chance of the client getting throttled.
  
  This technically means that a different endpoint is used to fetch the
  data (`GET /beatmaps/?ids[]=` rather than `GET
  /beatmapsets/lookup?beatmap_id={id}`), but docs claim that both should
  return the same data, and it looks to work fine in practice.

  Bartłomiej Dach · 2024-09-23 12:15:19 +02:00
  4b349ba387
• Fix score being cloned in async method causing random errors (again)

  Compare: https://github.com/ppy/osu/pull/24548.
  
  I don't have a reproduction scenario (judging from the stack trace
  of the crash it's likely to be nigh-impossible to concoct a reliable
  one), but there is some circumstantial evidence that this might help,
  namely that that previous fix above worked, and the pathway that's
  failing here is similarly async to the one that pull fixed. So I'm just
  gonna start with that and hope that it does the job.

  Bartłomiej Dach · 2024-09-23 09:51:02 +02:00
  881c9dfbba
• removed unnecessary includes
  Givikap120 · 2024-09-22 15:04:21 +03:00
  2995df7903
• initial commit
  Givikap120 · 2024-09-22 15:01:58 +03:00
  1b77b3912b
• Remove nullable disable
  Daniel Cios · 2024-09-20 18:07:26 +02:00
  59df9cbf0f
• Restore previous scale behavior when using scale popover
  Marvin Schürz · 2024-09-20 17:38:49 +02:00
  8bca8d6072
• Use scale origin when scaling sliders
  Marvin Schürz · 2024-09-20 17:19:38 +02:00
  8ceea9a5f7
• Rename FontColour to TextColour
  Daniel Cios · 2024-09-20 16:50:17 +02:00
  73b6744a97
• Rename Colour to AccentColour
  Daniel Cios · 2024-09-20 16:38:26 +02:00
  ec575e9de4
• Merge pull request #29933 from bdach/fix-dodgy-dim

  Fix `DrawableOsuHitObject` not properly cleaning up dim application callbacks

  Dan Balasescu · 2024-09-20 14:21:14 +09:00
  ccf1acce56
• Fix test failures
  Daniel Cios · 2024-09-19 21:50:59 +02:00
  1a48b46536
• Fix code inspection failure
  Daniel Cios · 2024-09-19 19:24:05 +02:00
  b86f246095
• Fix spacing
  Daniel Cios · 2024-09-19 17:31:33 +02:00
  94c2f522ff
• Add tests
  Daniel Cios · 2024-09-19 17:27:26 +02:00
  c77afe2a13
• Fix default color
  Daniel Cios · 2024-09-19 17:27:26 +02:00
  67f04f75a6
• Add colour customisation to skin components
  Daniel Cios · 2024-09-19 17:27:25 +02:00
  e81e356d59