Dean Herbert
9c68b3edc5
Merge branch 'master' into fix-spectator-seeks
2022-04-13 12:33:41 +09:00
Dean Herbert
282fccb4c8
Fix typo in xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-04-13 12:24:47 +09:00
Dan Balasescu
567d755794
Merge pull request #17790 from huoyaoyuan/remove-binary-serialization
...
Remove usages of binary serialization
2022-04-13 11:00:23 +09:00
Dan Balasescu
abf7954a9c
Merge pull request #17792 from peppy/multi-match-footer-test-remove
...
Fix `MultiplayerMatchFooter` test crash due to missing `PopoverContainer`
2022-04-13 10:53:27 +09:00
Dan Balasescu
76517cecab
Merge pull request #17789 from peppy/rank-range-pill-test-refactor
...
Refactor `TestSceneRankRangePill` to not depend on `TestMultiplayerClient`
2022-04-13 10:46:00 +09:00
Dean Herbert
d73be7f177
Reword comment to read clearer
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-04-13 09:36:44 +09:00
Bartłomiej Dach
9719b443a1
Merge pull request #17791 from peppy/gameplay-chat-display-test-refactor
...
Refactor `GameplayChatDisplay` test scene to not require `MultiplayerTestScene` inheritance
2022-04-12 21:11:07 +02:00
Bartłomiej Dach
63e2a84d7f
Nest one more container to fix popover not being dismissable
2022-04-12 20:54:54 +02:00
Dean Herbert
ef7ab12b40
Fix MultiplayerMatchFooter test crash due to missing PopoverContainer
...
Clicking the countdown button would crash. I did consider removing the
test altogether but maybe it'll be useful in the future?
2022-04-12 23:01:39 +09:00
Dean Herbert
1ebbef88ec
Refactor GameplayChatDisplay test scene to not require MultiplayerTestScene inheritance
2022-04-12 22:56:48 +09:00
Huo Yaoyuan
80e312dbbc
Remove unused binary serialization related code.
2022-04-12 20:29:13 +08:00
Huo Yaoyuan
bf677ad0ac
Remove usages of BinaryFormatter.
2022-04-12 20:28:14 +08:00
Dean Herbert
20eca9bf6a
Refactor TestSceneRankRangePill to not depend on TestMultiplayerClient
2022-04-12 19:39:24 +09:00
Dean Herbert
6dbfc26158
Add log output when a model is undeleted
2022-04-12 18:23:38 +09:00
Dean Herbert
b51abfc722
Fix ScoreDownloadTracker matching on empty hash equality
2022-04-12 18:22:23 +09:00
Dean Herbert
45d79c1a73
Ensure previous test score is cleaned up to allow visual test runs to work better
2022-04-12 18:21:40 +09:00
Dean Herbert
e901857610
Merge pull request #17776 from frenzibyte/dangerous-dialog-button-bounds
...
Fix dialog dangerous button being clickable at edges
2022-04-12 15:40:50 +09:00
Dean Herbert
8b1cee75fa
Use BindableLong instead of BindableInt for user score tracking
2022-04-12 14:13:07 +09:00
Dean Herbert
22c75a518e
Fix headers not getting reset on re-run of test
2022-04-12 12:38:15 +09:00
Dean Herbert
f29e329700
Move user count to a constant to allow easier adjustment
2022-04-12 12:11:51 +09:00
Dean Herbert
0ba95a4483
Ensure all users are shown on leaderboard (even when API lookup fails)
2022-04-12 11:54:30 +09:00
Dean Herbert
577e29351e
Ensure players are always on both leaderboard teams
...
In a very rare case, the randomisation may cause all users to be on one
team, causing a test failure. The odds make it basically impossible, but
if adjusting the number of users in the test scene this can more readily
be hit.
2022-04-12 11:46:22 +09:00
Dean Herbert
ebee9e6888
Fix MultiplayerGameplayLeaderboard not immediately updating totals on scoring mode change
2022-04-12 11:27:27 +09:00
Dan Balasescu
94e2a90af2
Merge pull request #17767 from peppy/multiplayer-gameplay-leaderboard-test-improvements
...
Refactor multiplayer gameplay leaderboard tests to remove reliance on `Test` implementations
2022-04-12 11:19:53 +09:00
Dean Herbert
a0e3a2102a
Also expand match score component when leaderboard is (in test)
2022-04-12 10:49:57 +09:00
Bartłomiej Dach
0eb0b5b456
Merge pull request #17773 from peppy/fix-skin-duplication
...
Fix skins getting duplicated when importing after export
2022-04-11 22:52:32 +02:00
Salman Ahmed
bad30d9e60
Fix dialog dangerous button being clickable at edges
2022-04-11 21:05:37 +03:00
Salman Ahmed
74dfa79f17
Add failing test case
2022-04-11 21:04:55 +03:00
Dean Herbert
82939b0556
Fix skins getting duplicated when importing after export
...
Closes #17614 .
2022-04-12 00:29:19 +09:00
Dean Herbert
4ab6c11079
Add failing test coverage of skin import after exporting from lazer
2022-04-12 00:29:15 +09:00
Dean Herbert
01cec7d3fb
Remove unnecessary string literals
2022-04-11 19:37:01 +09:00
Dean Herbert
09d560c93e
Add test coverage of spectator requests
2022-04-11 19:27:14 +09:00
Dean Herbert
6a61fd95eb
Tidy up base implementation
2022-04-11 19:19:45 +09:00
Dean Herbert
b52f070fdb
Update existing multiplayer leaderboard tests to use new mocked implementation
2022-04-11 19:15:57 +09:00
Dean Herbert
0ccac24f76
Split out base implementation of MultiplayerGameplayLeaderboard test
2022-04-11 19:15:46 +09:00
Dan Balasescu
a7eb5d71f1
Merge pull request #17765 from peppy/fix-multiplayer-room-type
...
Fix `MultiplayerTestScene` not setting match type correctly
2022-04-11 19:12:57 +09:00
Dean Herbert
34457b4742
Expose mocked members as virtual on Multiplayer and SpectatorClient
2022-04-11 19:04:15 +09:00
Dean Herbert
abb42a54fd
Fix MultiplayerTestScene not actually setting match type correctly
2022-04-11 17:57:05 +09:00
Dean Herbert
5cfafee83c
Merge pull request #17764 from smoogipoo/fix-playlist-results-screen-test
...
Fix incorrect cursor parameterisation in test scene
2022-04-11 16:10:20 +09:00
Dan Balasescu
d1de516b11
Fix incorrect cursor parameterisation in test scene
2022-04-11 15:40:28 +09:00
Dan Balasescu
37976c569a
Merge pull request #17762 from peppy/fix-unobserved-exceptions
...
Avoid throwing unobserved exception when `PerformancePointsCounter` requests timed attributes
2022-04-11 14:50:12 +09:00
Dan Balasescu
489f064b13
Merge pull request #17761 from peppy/fix-drawable-room-null-reference
...
Fix potential crash in `DrawableRoom` due to lack of null check on post-lookup beatmap
2022-04-11 14:50:01 +09:00
Dean Herbert
cb6e557212
Fix MasterGameplayClockContainer having incorrect rate-based offsets immediately after LoadComplete
...
I've attempted to explain why this is required using inline comments.
There's also further conversation at
https://github.com/ppy/osu/pull/17302#issuecomment-1091850927 .
2022-04-11 14:11:26 +09:00
Dean Herbert
808f0ecb74
Ensure running state is updated before performing Seek in GameplayClockContainer.Reset
2022-04-11 14:10:50 +09:00
Dean Herbert
2b74dbca28
Fix potential crash in DrawableRoom due to lack of null check on post-lookup beatmap
2022-04-11 13:44:34 +09:00
Dean Herbert
779f7390b7
Add test coverage of DrawableRoom actually showing post-retrieval text
2022-04-11 13:44:34 +09:00
Dean Herbert
19b655d75b
Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes
2022-04-11 13:30:21 +09:00
Dean Herbert
f2e67d00cc
Merge pull request #17743 from smoogipoo/fix-particle-spewer-nan
...
Fix ParticleSpewer outputting NaN values in vertices
2022-04-09 23:06:14 +09:00
Dan Balasescu
d482ab0287
Fix ParticleSpewer outputting NaN in vertices
2022-04-09 22:29:55 +09:00
Salman Ahmed
2702f7b9f9
Merge pull request #17731 from peppy/fix-highlight-null-ref
2022-04-08 20:20:03 +03:00
