Dean Herbert
47d81e7dee
Fix null inspections on GameplayChatDisplay
2024-12-17 19:10:09 +09:00
Salman Alshamrani
22e74cc0ee
Fix iOS app configuration missing certain specifications
2024-12-16 12:22:28 -05:00
Salman Alshamrani
4bf90a5571
Use time-based resume overlay when playing osu! on touchscreen
2024-12-16 08:24:22 -05:00
Salman Alshamrani
c46e81d890
Roll our own iOS application delegates
2024-12-16 06:51:21 -05:00
Dean Herbert
09fc30e377
Hide !mp
commands from tournament streaming chat
2024-12-16 17:39:27 +09:00
Bartłomiej Dach
68a5618e81
Add test coverage
2024-12-16 16:03:26 +09:00
Dean Herbert
d97ea78136
Change beat snap divisior adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll
...
Matches stable.
- [ ] Depends on https://github.com/ppy/osu/pull/31146 , else this will
adjust the global volume.
2024-12-16 15:22:30 +09:00
Dean Herbert
bdd417c1a1
Move "global" scroll-adjusts-volume to a per-screen component-based implementation
2024-12-16 15:21:07 +09:00
Bartłomiej Dach
d72a0b04b8
Merge pull request #31084 from NicholasChin28/mania-profile-overlay-tooltip
...
Add missing mania tooltip overlay for 4k and 7k
2024-12-16 14:22:41 +09:00
Dean Herbert
85ada3275b
Skip the pause cooldown when in intro / break time
...
Had a quick look at adding test coverage in `TestScenePause` but the
setup to get into either of these states seems a bit annoying..
2024-12-16 14:14:30 +09:00
Bartłomiej Dach
8a2f161619
Merge pull request #31139 from peppy/settings-sensitivity
...
Expose high precision mouse toggle when searching for "sensitivity" and other keywords
2024-12-16 13:40:32 +09:00
Bartłomiej Dach
9652c5a7ca
Merge pull request #31110 from peppy/timing-current-point-indicator
...
Change the way "current" points are hinted on timing screen
2024-12-16 13:27:06 +09:00
Bartłomiej Dach
ecb7a809f2
Revert "Fix text anchor for mania tooltip"
...
This reverts commit c0b6e784a5
.
The change affects editor and other stuff and I'm not sure it's correct.
It's not like client needs to match the appearance really. It already
doesn't in many places.
2024-12-16 13:18:47 +09:00
Bartłomiej Dach
cfdb959cf6
Split actual methods & fix completely broken localisation
...
Localisable strings cannot be plainly interpolated or joined. That is a
lossy operation that loses data.
2024-12-16 13:16:52 +09:00
Bartłomiej Dach
8d1d026f56
Clean up model
...
- Properly annotate things as nullable
- Remove weird passthrough property (more on that later)
2024-12-16 13:14:21 +09:00
Dean Herbert
a8948628e6
Expose high precision mouse toggle when searching for "sensitivity" and other keywords
2024-12-16 13:12:21 +09:00
Bartłomiej Dach
573d709fae
Merge pull request #31109 from peppy/fix-editor-timing-undo-redo
...
Fix adjusting control point offset after undo/redo causing catastrophic failure
2024-12-16 12:40:22 +09:00
Bartłomiej Dach
98e8d0b497
Merge branch 'master' into timing-current-point-indicator
2024-12-16 12:22:14 +09:00
Bartłomiej Dach
1058abb4ab
Fix code quality
2024-12-16 12:22:06 +09:00
Bartłomiej Dach
a6e00d6eac
Implement ability to mark beatmap as played
...
Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1 .
Would you believe it that this button that has been there for literal
years never did anything?
Implemented at a per-beatmap level. Also additionally added to context
menu (at @peppy's suggestion), and also copy reworded from "Delete from
unplayed" to "Mark as played" because double negation hurt my tiny
brain.
2024-12-16 10:49:19 +09:00
Nicholas Chin
e2edd9e0d5
Fix code quality issues
2024-12-15 13:53:33 +08:00
Nicholas Chin
153e6c0c22
Use Count comparison instead of Any
2024-12-14 08:29:32 +08:00
Dean Herbert
c93b6dba2b
Merge pull request #31108 from peppy/quick-retry-for-replays
...
Allow using "quick retry" shortcut in more cases from results screen
2024-12-13 08:18:59 -08:00
Nicholas Chin
c0b6e784a5
Fix text anchor for mania tooltip
2024-12-13 21:58:23 +08:00
Dean Herbert
9025103b8b
Reword comment to hopefully be more understandable
2024-12-13 20:02:17 +09:00
Dean Herbert
da840e3fac
Change the way "current" points are hinted on timing screen
...
I actually thought things were bugged with the previous display method,
since the hinting was very similar to the hover colour/state.
I've adjusted this to hopefully give users a better idea of what this is
intending to show them.
2024-12-13 19:45:18 +09:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
...
Closes https://github.com/ppy/osu/issues/31098 .
Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00
Dan Balasescu
35c70ceb18
Merge pull request #31106 from peppy/player-settings-fix-overlap-skins
...
Fix player settings overlay cog overlapping skin elements
2024-12-13 19:30:39 +09:00
Dean Herbert
4b0cdd761d
Add note about player settings overlay button
2024-12-13 18:58:20 +09:00
Dan Balasescu
f84c67babd
Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing
...
Add recommended difficulty numerical value near filter in beatmap listing
2024-12-13 18:57:16 +09:00
Dan Balasescu
e2af8820de
Merge pull request #31107 from bdach/flaky-editor-test
...
Attempt to fix flaky editor beatmap creation test
2024-12-13 18:53:43 +09:00
Dan Balasescu
22a5ed8a07
Merge branch 'master' into player-settings-fix-overlap-skins
2024-12-13 18:36:12 +09:00
Dan Balasescu
c29c3d48bf
Merge pull request #31105 from peppy/player-settings-no-show-skin-editor
...
Fix player settings overlay appearing while in skin editor
2024-12-13 18:34:05 +09:00
Dean Herbert
d00bc4bdd1
Also allow using "quick retry" for other replays
2024-12-13 18:14:45 +09:00
Dean Herbert
0e0d96829f
Fix "quick retry" hotkey not working for autoplay
2024-12-13 18:08:29 +09:00
Dan Balasescu
edbaaa9468
Fix test
2024-12-13 17:41:55 +09:00
Bartłomiej Dach
fdc41ace7e
Fix flaky editor beatmap creation test
...
As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53 .
Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.
2024-12-13 17:35:41 +09:00
Dean Herbert
a796af9511
Fix player settings overlay cog overlapping skin elements
...
This brings it down to be in line with the flowing elements that usually
do their best to not get in the way.
Decided against putting it in the `HUDOverlay` flow for simplicity. It
will work fine until it doesn't.
2024-12-13 17:28:15 +09:00
Dean Herbert
1e809c7f16
Fix player settings overlay appearing while in skin editor
2024-12-13 17:18:34 +09:00
Dean Herbert
b470e30cc0
Add failing test showing player settings appearing in skin editor
2024-12-13 17:18:34 +09:00
Dan Balasescu
2930db5d6e
Merge pull request #31073 from bdach/filter-playing-rooms
...
Add ability to filter out currently playing rooms
2024-12-13 17:03:30 +09:00
Dan Balasescu
7bb1a5118e
Unbind event on disposal
2024-12-13 16:39:16 +09:00
Dan Balasescu
62a1a5883a
Merge branch 'master' into recommended-diff-beatmap-listing
2024-12-13 16:38:07 +09:00
Dan Balasescu
d597232c2a
Fix incorrect lastPattern
value
...
In particular, mania-specific beatmaps that normally go via the
"passthrough" generator should not adjust the stored pattern value.
The "spinner" generator, which was previously intended to be used for
non-mania-specific beatmaps, is now valid even for mania-specific
beatmaps, and uses this value.
In other words, another way of writing this would be:
```csharp
if (conversion is SpinnerPatternGenerator || conversion is
PassThroughPatternGenerator) ? lastPattern : newPattern;
```
2024-12-13 16:08:12 +09:00
Dan Balasescu
12e5999700
Add another failing test
2024-12-13 15:53:27 +09:00
Dean Herbert
313de33986
Adjust padding to avoid wrapping on checkbox text
2024-12-13 15:42:30 +09:00
Dan Balasescu
ae1030197a
Merge pull request #31103 from Joehuu/update-taiko-recommended-diff
...
Update recommended difficulty for osu!taiko
2024-12-13 14:26:02 +09:00
Joseph Madamba
38b3d5fc00
Update recommended difficulty for osu!taiko
2024-12-12 16:17:57 -08:00
Joseph Madamba
f7364de01a
Add test and null protections
2024-12-12 15:23:00 -08:00
Joseph Madamba
92e07b4f99
Add recommended difficulty numerical value near filter in beatmap listing
2024-12-12 15:23:00 -08:00