42386 Commits

This Branch

This Branch

All Branches

• Replace "offset" term in combo index documentations with "index" instead
  Salman Ahmed · 2021-07-23 07:31:03 +03:00
  8600a3bf5b
• Update colours once on TimelineHitObjectBlueprint
  Salman Ahmed · 2021-07-23 06:25:56 +03:00
  ee3791ccf2
• Remove unnecessary parentheses

  I... forgot to amend that.

  Salman Ahmed · 2021-07-22 16:42:07 +03:00
  20adfabc97
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Check nested hitobjects while asserting accent colour
  Salman Ahmed · 2021-07-22 16:40:28 +03:00
  cd7b90363a
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Remove no longer correct usage of "legacy" in offsets
  Salman Ahmed · 2021-07-20 14:35:21 +03:00
  300b3f22b1
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Merge branch 'master' into legacy-beatmap-combo-offset
  Dean Herbert · 2021-07-20 19:49:35 +09:00
  3a974d5027
• Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval

  Refactor combo colours retrieval to use skin config lookups instead

  Dean Herbert · 2021-07-20 19:47:57 +09:00
  d066ebcd70
• Merge pull request #13943 from peppy/fix-subscreen-exit-before-loaded

  Ensure online play subscreen is loaded before forwarding `OnExiting`

  Dan Balasescu · 2021-07-20 18:36:42 +09:00
  13733d8c75
• Revert unintended changes
  Dean Herbert · 2021-07-20 16:44:51 +09:00
  26cc4af87c
• Add test coverage of fail scenario
  Dean Herbert · 2021-07-20 16:37:13 +09:00
  4113eae6ad
• Update outdated test cases
  Salman Ahmed · 2021-07-20 10:28:30 +03:00
  a1001542f3
• Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
  Salman Ahmed · 2021-07-20 10:11:52 +03:00
  554652b033
• Merge branch 'master' into refactor-combo-colour-retrieval
  Salman Ahmed · 2021-07-20 10:08:25 +03:00
  1af230c48c
• Ensure online play subscreen is loaded before forwarding OnExiting

  Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
  framework issue; the framework correctly guards against this scenario,
  see
  https://github.com/ppy/osu-framework/blob/4e29504384bb78bbccc0d492de58124f17270eb2/osu.Framework/Screens/ScreenStack.cs#L277).
  
  Added the assertions to be very explicit about the nested stack's state
  at this point. Both of those events can only be triggered if the stack
  has a loaded screen (as far as I can tell), making this check
  unnecessary in those cases.

  Dean Herbert · 2021-07-20 15:51:34 +09:00
  fe414b942f
• Merge pull request #13785 from ekrctb/dependency-providing-container

  Add a convenient way to provide ad-hoc dependency to children in visual test

  Dean Herbert · 2021-07-20 14:18:17 +09:00
  6cc81c24b4
• Merge pull request #13941 from Henry-YSLin/update-TargetBeatContainer

  Update `OsuModTarget` to take advantage of the new `BeatSyncedContainer`

  Dean Herbert · 2021-07-20 12:30:49 +09:00
  f415dc18a7
• Disallow mistimed event firing
  Henry Lin · 2021-07-20 10:31:19 +08:00
  1c6a13fca7
• Use BeatSyncClock
  Henry Lin · 2021-07-20 10:30:40 +08:00
  a387d8df74
• Don't consider version suffixes when checking for updates

  This is just to make life easier for me with deploys for now.

  Dean Herbert · 2021-07-20 01:05:37 +09:00
  2021.720.0 9ea1f5900a
• Merge pull request #13921 from Game4all/localise-profile-overlay

  Localise user profile overlay

  Dean Herbert · 2021-07-20 00:37:01 +09:00
  e77597c2b6
• Merge pull request #13861 from peppy/add-password-support

  Add multiplayer room password support

  Dean Herbert · 2021-07-19 23:32:28 +09:00
  844152e1b1
• Merge pull request #13894 from peppy/fix-beat-synced-container-alt

  Fix multiple issues with `BeatSyncedContainer`

  Dan Balasescu · 2021-07-19 23:19:20 +09:00
  6e104fe084
• Merge pull request #13931 from peppy/fix-replay-date

  Fix replay dates being unexpectedly updated on play completion

  Dan Balasescu · 2021-07-19 22:56:27 +09:00
  0fc1d3e404
• Revert unintended change

  It's a deeper issue with ScreenStack (see:
  https://github.com/ppy/osu-framework/issues/4619).

  smoogipoo · 2021-07-19 22:52:07 +09:00
  6a55cb9df0
• Move initial content into step
  smoogipoo · 2021-07-19 22:31:53 +09:00
  7956f73f62
• Fix password icon not disappearing when no password
  smoogipoo · 2021-07-19 22:31:01 +09:00
  57a99886d5
• Fix compile error
  smoogipoo · 2021-07-19 22:23:31 +09:00
  892d858d5f
• Merge branch 'master' into add-password-support
  smoogipoo · 2021-07-19 22:23:09 +09:00
  b7c2d6b1ab
• Merge pull request #13928 from ekrctb/juice-stream-path

  Add `JuiceStreamPath` as alternative representation of `JuiceStream` path for catch editor

  Dean Herbert · 2021-07-19 22:18:05 +09:00
  6d49165664
• Merge branch 'master' into fix-replay-date
  Dan Balasescu · 2021-07-19 21:58:37 +09:00
  5ef1fe6948
• Merge pull request #13929 from peppy/i-deep-cloneable

  Create a deep clone of score for score submission purposes

  Dan Balasescu · 2021-07-19 21:58:27 +09:00
  f3bcaf7f11
• Fix request failing due to parameters
  smoogipoo · 2021-07-19 21:24:22 +09:00
  0a43e54dfc
• Fix web request failing if password is null
  smoogipoo · 2021-07-19 20:57:16 +09:00
  a001e4aa16
• Add room joining tests
  smoogipoo · 2021-07-19 20:55:14 +09:00
  05295241b8
• Fix possible exception
  smoogipoo · 2021-07-19 20:50:30 +09:00
  3168a927dc
• Fix password not copied from multiplayer client
  smoogipoo · 2021-07-19 20:20:08 +09:00
  2eec524f27
• Remove local APIRoom from test multiplayer client
  smoogipoo · 2021-07-19 20:19:23 +09:00
  d6aa15e5d7
• Add test
  smoogipoo · 2021-07-19 20:08:29 +09:00
  1b9d297911
• Also copy password in test room manager
  smoogipoo · 2021-07-19 20:07:56 +09:00
  a5a0f12e19
• Set HasPassword correctly in the response room
  smoogipoo · 2021-07-19 20:03:32 +09:00
  26d0eea485
• Use room password to fill settings textbox
  smoogipoo · 2021-07-19 20:03:32 +09:00
  2515785f93
• Make test multiplayer client validate password
  smoogipoo · 2021-07-19 20:03:27 +09:00
  8c0daa89a0
• Update test room manager to not return passwords
  smoogipoo · 2021-07-19 20:03:27 +09:00
  063f14da98
• Fix date being updated on replays unexpectedly
  Dean Herbert · 2021-07-19 19:28:35 +09:00
  b3f60c8253
• Move clone to earlier in the process
  Dean Herbert · 2021-07-19 19:18:34 +09:00
  f16b4957aa
• Merge pull request #13887 from ekrctb/legacy-converted-y

  Preserve Y position of hit objects in osu!catch

  Dean Herbert · 2021-07-19 18:48:23 +09:00
  23ef666f34
• Merge pull request #13926 from peppy/set-rank-on-failed-submission

  Set score's rank on a failed submission

  Dan Balasescu · 2021-07-19 18:45:21 +09:00
  f1f6af88a1