Salman Ahmed
6ab8960fdc
Add step for toggling skins in results screen test scene
2024-02-01 16:08:48 +03:00
Salman Ahmed
35c3f5e250
Merge branch 'master' into fix-results-f-rank
2024-02-01 15:29:07 +03:00
Dean Herbert
a1fe5eedd5
Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score
...
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
...
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections
2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Andrei Zavatski
809ca81b9c
Add TestSceneGradedCircles
2024-01-29 05:29:29 +03:00
Salman Ahmed
64b61108ad
Move solution to multiplayer flow instead
2024-01-28 00:42:04 +03:00
Salman Ahmed
5f68999893
Fix TestSceneFailJudgement asserts no longer being correct
2024-01-27 23:23:32 +03:00
Salman Ahmed
ea641bb8d2
Rename GameplayState.HasFailed to properly clarify its meaning
2024-01-27 23:23:10 +03:00
Salman Ahmed
d38779f962
Add failing test case
2024-01-27 23:22:56 +03:00
Salman Ahmed
2ccd0e3692
Add visual and failing test cases
2024-01-27 01:45:39 +03:00
Bartłomiej Dach
a2e69d37e8
Add basic testing of failure flow
2024-01-26 11:17:32 +01:00
Dean Herbert
e54502eef1
Add full editor save test coverage
2024-01-26 13:59:32 +09:00
Dean Herbert
a77db5d837
Add failing test coverage of editor metadata not saving
2024-01-26 13:59:32 +09:00
Chandler Stowell
93bd3ce5ae
update DrawableHitCircle.ApplyResult to pass this to its callback
2024-01-25 11:25:41 -05:00
Bartłomiej Dach
3d3506b906
Merge branch 'decouple-notification-websocket-from-chat' into 2fa
2024-01-25 14:51:42 +01:00
Dean Herbert
d66a2c452f
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-01-25 21:18:16 +09:00
Dean Herbert
baaf33d995
Merge pull request #26689 from myQwil/divisor_cycle
...
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
OliBomby
c2d57dc77c
Merge remote-tracking branch 'upstream/master' into edit-nodesample
2024-01-25 11:33:29 +01:00
Dean Herbert
f22bfa350a
Add test coverage of hidden scores on accuracy circle
2024-01-25 15:02:44 +09:00
Nguyên Minh Hồ
e1f8bc9692
Rename CanRotate property of SelectionRotationHandler to a more descriptive name
2024-01-25 12:10:50 +07:00
Mike Will
9e1c242713
Prevent custom divisor ranges from halting preset cycling
...
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Bartłomiej Dach
2f8747776e
Fix nullability inspection
2024-01-24 22:01:59 +01:00
Dean Herbert
b272d34960
Merge pull request #26630 from peppy/s-rank-change
...
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor
2024-01-23 18:04:41 +01:00
Bartłomiej Dach
d7e957087e
Fix account creation overlay test not clearing second auth factor
2024-01-23 17:00:16 +01:00
Bartłomiej Dach
d0d09a8657
Fix login overlay test not clearing second auth factor
2024-01-23 17:00:14 +01:00
Bartłomiej Dach
2cfaa1c103
Merge branch 'master' into 2fa
2024-01-23 16:51:23 +01:00
Andrei Zavatski
da992ccc55
Implement per-axis triangles clamping
2024-01-23 04:54:27 +03:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present
2024-01-22 21:43:32 +09:00
Dean Herbert
c8521b49cd
Change S rank to require no miss
2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
...
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
...
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
In https://github.com/ppy/osu/pull/26484 , I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"
Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.
You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom
2024-01-22 10:37:06 +01:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons
2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request #26605 from peppy/simplify-gameplay-pause
...
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework
2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b
Rename Masking to ClampToDrawable
2024-01-21 05:20:42 +03:00
OliBomby
9459c66981
fix test
2024-01-20 15:53:08 +01:00
OliBomby
bc0e6baba7
fix test
2024-01-20 01:13:05 +01:00
smallketchup82
87369f8a80
Conform to code style & remove unused imports
2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050
Add failing test case
2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing
2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
...
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee
Add tests for DifficultyIcon
2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence
2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour
2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync
2024-01-18 14:01:37 +09:00
Dean Herbert
6a8a45bb13
Merge pull request #26585 from frenzibyte/fix-editor-ux
...
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
