1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 15:32:55 +08:00
Commit Graph

313 Commits

Author SHA1 Message Date
ansel
ca3be71381 Track comment's nesting and reduce padding for too nested 2023-01-18 02:11:07 +03:00
ansel
12544c16ea Remove canBeNull 2023-01-18 02:10:02 +03:00
Bartłomiej Dach
3640342805
Add logging on comment post failure 2023-01-17 21:30:46 +01:00
ansel
1480c691ae Explain empty string in editor's footer 2023-01-14 23:42:56 +03:00
ansel
c36922dd2c Use clock to obtain a position for comment insertion 2023-01-14 22:57:51 +03:00
ansel
c2bb0949f5 Take type and id from container directly on submit 2023-01-14 22:57:23 +03:00
ansel
cdf3aafddd Add check for any drawables in content before looking for placeholder 2023-01-14 22:37:05 +03:00
ansel
88c3eef8e1 Add test case with no existing comments 2023-01-14 20:59:13 +03:00
ansel
bb8bcd7248 Move avatar update bind to LoadComplete 2023-01-14 02:50:30 +03:00
ansel
9e7ecbf4a1 Adapt to changes in base class 2023-01-14 02:41:11 +03:00
ansel
e9995410e8 Merge branch 'master' into comment-editor-3 2023-01-14 02:32:06 +03:00
ansel
0bd1c46c74 Undo sizing changes 2023-01-12 19:48:11 +03:00
ansel
b38cf8c56c Use empty string as default 2023-01-11 02:26:25 +03:00
Dean Herbert
23a78e6fad Combine commit button enabled handling 2023-01-10 23:59:17 +09:00
ansel
23e4cfb469 Show spinner next to buttons and get rid of EditorCommitButton 2023-01-09 23:37:36 +03:00
Dean Herbert
13b00928c8 Rename loading spinner bool to reflect that it has a setter 2023-01-09 15:52:18 +09:00
ansel
927773d565 Display submitted comments locally 2023-01-07 04:15:43 +03:00
ansel
32e90829e3 Integrate comment editor into container 2023-01-07 02:59:24 +03:00
ansel
387326db0d Make commit action abstract 2023-01-06 22:51:57 +03:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1 2022-12-28 17:46:01 +05:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management 2022-12-19 20:19:51 +01:00
Dean Herbert
b64a5cbda6 Merge branch 'master' into guard-url-protocols 2022-12-19 15:46:45 +09:00
Joseph Madamba
6e62033bc4 Fix some comment actions not being lowercased 2022-12-18 20:20:15 -08:00
Dean Herbert
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
ansel
1763618488 Fix spinner presense check & field click 2022-11-30 13:58:03 +03:00
ansel
43628903a7 Make spinner bigger 2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39 Keep button's text 2022-11-30 13:40:47 +03:00
ansel
bedc771e99 Remove useless check 2022-11-30 13:32:01 +03:00
ansel
a8422961dc Rename button spinner prop again 2022-11-30 13:30:57 +03:00
ansel
5ea824534b Use default button 2022-11-30 13:25:59 +03:00
ansel
642e0ac718 Increase footer height to look better with default buttons 2022-11-30 13:25:18 +03:00
ansel
956acbc86f Use fixed width 2022-11-30 13:11:54 +03:00
Dean Herbert
4a747182b4 Merge branch 'master' into comment-editor-1 2022-11-30 17:22:59 +09:00
ansel
e30d97c94e Comments 2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf Change ways to access submit button state 2022-11-29 14:37:35 +03:00
ansel
6c126f5223 Remove useless local actions on click 2022-11-29 14:25:51 +03:00
ansel
16962d9a57 Localize deleted string 2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c Localize actions 2022-11-29 07:01:52 +03:00
ansel
472d9274b6 Reorder members 2022-11-29 06:23:25 +03:00
ansel
af0ee9dbd6 Make spinner a little bigger 2022-11-29 06:19:54 +03:00
ansel
894fb98fa2 Rebase CommitButton to RoundedButton 2022-11-29 06:17:02 +03:00
ansel
a874345da0 Rebase CancelButton to RoundedButton 2022-11-29 05:46:30 +03:00
ansel
d20dc3668e Enable nullability 2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7 Allow localisable strings 2022-11-29 05:13:54 +03:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set 2022-11-03 17:47:49 +09:00
Salman Ahmed
6c82bc36ed Encapsulate report logic inside button implementation
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599 Remove dependency on DrawableComment from report popover and simplify logic
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47 Adjust comment report popover design 2022-10-22 02:45:31 +03:00