76809 Commits

This Branch

This Branch

All Branches

• Fix discord multiplayer invites (#37598)

  Downgrade the `DiscordRichPresence` package until
  https://github.com/Lachee/discord-rpc-csharp/issues/286 is resolved.
  
  Also reported on
  [discord](https://discord.com/channels/188630481301012481/1097318920991559880/1497244317801119866)
  before.
  
  I don't know if it's reproducible for everyone, but at least for me it
  is on both Windows and Linux, and also for everyone I asked to try
  inviting.
  
  Closes #37626
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Zihad · 2026-05-05 00:26:47 +09:00
  80a29eb6a2
• Fix duel crash due to failing lookups (#37606)
  Dan Balasescu · 2026-05-02 15:55:33 +09:00
  3924fc7d86
• Implement duels for ranked play (#37556)

  I've seen this suggested quite a bit and is a pretty easy implementation
  all things considered.
  
  For now, while on the queue screen, you can open up the dashboard
  overlay and select another player to duel. This will bring you into an
  unranked lobby.
  
  
  https://github.com/user-attachments/assets/712897a9-9350-4741-899d-59662c722e43

  Dan Balasescu · 2026-04-29 16:12:27 +09:00
  2026.429.0 2026.429.0-lazer a3b8b9aee9
• Stop song preview when entering spectator (#37564)

  Song preview keeps playing when clicking "Start Watching" on
  `SoloSpectatorScreen`. Making `SoloSpectatorScreen` suspends the screen
  rather than exiting it, so neither `clearDisplay()` nor `OnExiting()`
  fire.
  
  Closes: https://github.com/ppy/osu/issues/36987

  Piotrr0 · 2026-04-29 14:41:33 +09:00
  3b84429e86
• Fix beatmap panels now showing "downloaded" green strip (#37566)

  Regressed in https://github.com/ppy/osu/pull/37558, my bad.

  Dean Herbert · 2026-04-29 11:27:28 +09:00
  bc1c3d09e0
• Add beatmap panel to the ranked play results screen (#37558)

  Different take to / supersedes / closes
  https://github.com/ppy/osu/pull/37550
  
  Just going for minimal lines of code compared to the PR above, by
  reusing the quick play panel which is in a pretty good state.
  
  <img width="1298" height="864" alt="image"
  src="https://github.com/user-attachments/assets/409e163d-d7ea-4c07-874f-aaca7e145221"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-28 22:08:23 +09:00
  2026.428.0-tachyon 71f841d8ae
• Add pen input settings (#37500)

  - depends on https://github.com/ppy/osu-framework/pull/6737
  
  Adds simple input settings section for pens that allows disabling the
  handler and adjusting sensitivity. The section appears in-between Tablet
  and Touch, and only on SDL3 (desktop and mobile). The pen sensitivity is
  completely independent from mouse sensitivity.
  
  <img width="537" height="149" alt="image"
  src="https://github.com/user-attachments/assets/448eebba-84ea-4daf-8428-3bd07739bd6f"
  />
  
  <br>
  
  Keep in mind that the "Confine mouse cursor to window" mouse setting
  also affects pens, feel free to suggest UX improvements. Also, toggling
  "High precision mouse" might affect pens on certain configurations.
  
  Edit: added image with updated header. Previously, it was "Device: Pen".
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Susko3 · 2026-04-28 20:18:30 +09:00
  9b3dba939e
• Implement animation for RankedPlayBottomOrnament (#37504)

  Based off of https://github.com/ppy/osu/pull/37478 with some
  improvements such as:
  * Simpler `progress` handling (single adjustable value instead of 2)
  * 2 less drawable paths (replaced with circlular containers)
  * Reworked remaining paths to have as little texture sizes as possible
  
  ---------
  
  Co-authored-by: Krzysztof Gutkowski <krzysio.gutkowski@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Andrei Zavatski · 2026-04-27 18:40:20 +09:00
  662c85d4c2
• Enhance ranked play stage countdown timer SFX (#37524)

  - adjust the warning stopwatch sample to start from when the timer shows
  10.xxx s instead of 9.xxx s
  - add an additional 'time almost up' sample that layers on top for the
  last 3s
  - re-add the 'time ran out' audio cue, with an updated sample
  
  in context, with bgm:
  
  
  https://github.com/user-attachments/assets/11f105e9-2baa-4d23-bdbc-ac7d16e3d7d8
  
  without bgm:
  
  
  https://github.com/user-attachments/assets/006d6b5a-398c-4e4b-a74e-10889ac6b922
  
  I'm not 100% on the 'time ran out' sample, but at least it sounds
  deliberate now, unlike the previous buzzer which could have been
  mistaken for an audio glitch.
  
  ---
  - [x] depends on ppy/osu-resources#420
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Jamie Taylor · 2026-04-27 18:40:03 +09:00
  428af047f9
• Remove points statistic from MatchmakingStatsTooltip (#37495)

  matches web
  
  | master | `osu-web` | PR |
  |-|-|-|
  | <img width="335" height="81" alt="image"
  src="https://github.com/user-attachments/assets/942fc6c0-488b-49b8-97d4-d2d81eeeed92"
  /> | <img width="307" height="83" alt="image"
  src="https://github.com/user-attachments/assets/3ade843e-c735-4697-bf89-622de2d23d9c"
  /> | <img width="338" height="135" alt="image"
  src="https://github.com/user-attachments/assets/5867023b-145d-4836-ba95-9e2bdd9e1bbc"
  /> |

  Denis Titovets · 2026-04-27 13:58:37 +09:00
  34deaad718
• Minor design improvements to the extended result screen (#37144)

  I am aware of the possibly-one-day-definitely-upcoming redesign, but
  while it's not yet ready I've made a couple of small design improvements
  to the current result screen.
  
  This includes: 
  - Slightly tighter and more consistent paddings
  - StatisticPanel's header being consistent with other similar panels
  (it's using subsection design right now which probably made sense back
  when it was all one panel)
  - More compact PerformanceBreakdown section
  - Slightly less background blur and slightly more transparent statistics
  panels
  
  Before:
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/89b564fd-0205-40bd-a7d5-9e0484fbe5dd"
  />
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/6d58f538-7a78-4de2-9316-7d070dabaf2c"
  />
  
  
  After: 
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/fa242349-27a1-4391-90fa-4d53be718fd4"
  />
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/9a755e6f-d6fe-4df2-880c-1f6195bd2a69"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  StanR · 2026-04-25 00:42:47 +09:00
  2026.425.0-lazer 4b9335ca59
• Improve visual appearance and animation of ranked play match history (#37501)

  master:
  
  
  https://github.com/user-attachments/assets/d96c7cf1-4f80-46f8-8c72-427aaf7f965d
  
  This PR:
  
  
  https://github.com/user-attachments/assets/d8c3467e-810d-4473-9078-0e858782cfa5
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-24 23:36:14 +09:00
  c35782ce9c
• Hide red failing layer in ranked play (#37503)

  In ranked play, scores are always counted regardless of whether they are
  a fail or a pass. Beyond that, there's also no concept of revival in
  multiplayer right now, so players are just stuck at 0 HP with a red
  overlay.
  
  Not doing what `ModNoFail` does, which is to hide the healthbar
  altogether, because some user skins use the healthbar to skin a gameplay
  border.

  Dan Balasescu · 2026-04-24 21:56:26 +09:00
  1b86ff11e5
• Persist last queued pool in ranked play screen (#37490)

  Closes #37443
  
  Previously it would select the first pool that matches the user's
  current ruleset.
  
  At first I tried passing the `MatchmakingPool` object to the
  notification and have it passed back to the screen, but with that method
  only clicking the notification would show the correct pool, if you enter
  ranked play normally then it would show the "default" pool instead.
  This method needed fewer changes too.

  Zihad · 2026-04-24 16:55:40 +09:00
  ea87510139
• Add localisation support for some more notifications (#37237)

  - part of https://github.com/ppy/osu/pull/36994
  
  changes can be reviewed commit by commit

  Denis Titovets · 2026-04-24 12:39:55 +09:00
  0fa7824a23
• Update resources
  Dean Herbert · 2026-04-24 11:11:57 +09:00
  88f0be8b22
• Adjust score submission error handling slightly (#37474)

  Based on internal feedback.
  
  I was going to apply other changes (like always posting to sentry) but
  don't want to go too far down a rabbit hole, so just fixed messaging a
  bit.

  Dean Herbert · 2026-04-23 08:41:25 +02:00
  c9ad0e497f
• Add empty hand check to moveCardFocus (#37489)

  Resolves #37486
  
  Original error log:
  ```
  2026-04-22 21:47:58 [error]: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
  2026-04-22 21:47:58 [error]: at System.Collections.Generic.List`1.get_Item(Int32 index)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.moveCardFocus(Int32 direction)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.OnKeyDown(KeyDownEvent e)
  ```
  
  Currently,
  ```osu.Game\Screens\OnlinePlay\Matchmaking\RankedPlay\Hand\PlayerHandOfCards.cs::moveCardFocus```
  does not account for the hand being empty (cards.Count ==0 ), and will
  attempt to move the card focus in the given direction regardless, which
  causes the above index out of range error.
  
  Added empty hand check to moveCardFocus, and a matching test case to
  TestScenePlayerCardHand.cs
  
  New test case before changes, recreating the error:
  <img width="986" height="232" alt="image"
  src="https://github.com/user-attachments/assets/daa62081-c776-44bd-b0d2-382b2dac7938"
  />
  
  After:
  <img width="638" height="223" alt="image"
  src="https://github.com/user-attachments/assets/d6dcd8b8-8caf-42e3-9999-93dfe3fb6452"
  />

  Austin Moore · 2026-04-23 12:23:17 +09:00
  f1ea3b354c
• Add web localisation support to MatchmakingStatsDisplay (#37246)

  <img width="399" height="174" alt="image"
  src="https://github.com/user-attachments/assets/9a9af6e1-1ea4-4010-8a46-edfbb71185e8"
  />

  Denis Titovets · 2026-04-23 10:31:26 +09:00
  70093c90fb
• Apply different workaround to fix ranked play single thread audio issues (#37477)

  Thing to make release happen.
  
  Reverts #37453
  Reverts #37463
  Alternative to #37473
  
  Not that I disagree with any of these but I'm just looking to return to
  what works so we can do a release because we're on a clock here for
  other reasons.
  
  Test which should work but doesn't, so I'm not adding:
  
  ```diff
  diff --git a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  index f747004bbd..eb8e360d1e 100644
  --- a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  +++ b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  @@ -1,12 +1,17 @@
   // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
   // See the LICENCE file in the repository root for full licence text.
   
  +using System.Linq;
  +using NUnit.Framework;
   using osu.Framework.Extensions;
  +using osu.Framework.Testing;
   using osu.Game.Online.API;
   using osu.Game.Online.Multiplayer;
   using osu.Game.Online.Multiplayer.MatchTypes.RankedPlay;
   using osu.Game.Online.Rooms;
   using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Card;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand;
   
   namespace osu.Game.Tests.Visual.RankedPlay
   {
  @@ -14,6 +19,8 @@ public partial class TestSceneOpponentPickScreen : RankedPlayTestScene
       {
           private RankedPlayScreen screen = null!;
   
  +        private readonly BeatmapRequestHandler requestHandler = new BeatmapRequestHandler();
  +
           public override void SetUpSteps()
           {
               base.SetUpSteps();
  @@ -26,8 +33,6 @@ public override void SetUpSteps()
               AddStep("load screen", () => LoadScreen(screen = new RankedPlayScreen(MultiplayerClient.ClientRoom!)));
               AddUntilStep("screen loaded", () => screen.IsLoaded);
   
  -            var requestHandler = new BeatmapRequestHandler();
  -
               AddStep("setup request handler", () => ((DummyAPIAccess)API).HandleRequest = requestHandler.HandleRequest);
   
               AddStep("set pick state", () => MultiplayerClient.RankedPlayChangeStage(RankedPlayStage.CardPlay, state => state.ActiveUserId = 2).WaitSafely());
  @@ -44,7 +49,11 @@ public override void SetUpSteps()
                       }).WaitSafely();
                   }
               });
  +        }
   
  +        [Test]
  +        public void TestBasic()
  +        {
               AddWaitStep("wait", 15);
   
               AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  @@ -54,5 +63,29 @@ public override void SetUpSteps()
                   BeatmapID = requestHandler.Beatmaps[0].OnlineID
               }).WaitSafely());
           }
  +
  +        [Test]
  +        public void TestPickPreviewPlayedOnOpponentPick()
  +        {
  +            RankedPlayCard.SongPreviewContainer? originalPreview = null;
  +
  +            AddStep("hover first card",
  +                () => InputManager.MoveMouseTo(this.ChildrenOfType<PlayerHandOfCards>().Single().Cards
  +                                                   .First(c => c.Item.PlaylistItem.Value != null && c.Item.PlaylistItem.Value.BeatmapID != requestHandler.Beatmaps[0].OnlineID)));
  +            AddUntilStep("preview playing", () => originalPreview = this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().FirstOrDefault(p => p.IsRunning), () => Is.Not.Null);
  +
  +            AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  +            AddStep("reveal card", () => MultiplayerClient.RankedPlayRevealUserCard(2, hand => hand[0], new MultiplayerPlaylistItem
  +            {
  +                ID = 0,
  +                BeatmapID = requestHandler.Beatmaps[0].OnlineID
  +            }).WaitSafely());
  +
  +            AddUntilStep("wait for original preview stopped", () => originalPreview?.IsRunning, () => Is.False);
  +
  +            AddUntilStep("preview playing is opponent's pick",
  +                () => ((RankedPlayCard)this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().SingleOrDefault(p => p.IsRunning)?.Parent!).Item.PlaylistItem.Value?.BeatmapID,
  +                () => Is.EqualTo(requestHandler.Beatmaps[0].OnlineID));
  +        }
       }
   }
  
  ```
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-23 02:05:52 +09:00
  2026.423.0-lazer a4f79f7c99
• Refactor audio preview logic in ranked play cards to match expectations while hopefully not looking buggy anymore (#37463)

  RFC.
  
  See https://github.com/ppy/osu/pull/37453#issuecomment-4289403735 for
  why.
  
  Of note:
  
  - To facilitate mutual exclusivity of playback `PlayerHandOfCards`
  maintains a bindable pointing at the currently playing song preview.
  - Because of how card drawables are passed between multiple parenting
  drawables, some of which are and some of which are not
  `PlayerHandOfCards` instances, DI fails horribly at working with this
  bindable unless it is manually managed. See relevant overrides in
  `PlayerHandOfCards`.
  - I renamed one of the overloads of `HandOfCards.RemoveCard()` to
  `DetachCard()` because I found the fact that there are two overloads of
  one method that do WILDLY DIFFERENT THINGS utterly *asinine*. (One
  overload scrapes the `RankedPlayCard` out for you to plop elsewhere. One
  *drops it on the floor entirely*.)
  
  This took way too long to write.

  Bartłomiej Dach · 2026-04-22 12:48:45 +09:00
  2026.422.0-lazer f1a9be4a19
• Code quality improvements for child/draw order handling in HandOfCards (#37423)

  Attempt at adressing the points made in
  https://github.com/ppy/osu/pull/37419#issuecomment-4279123323
  
  - `CardContainer` is now being sorted immediately instead of only doing
  it once per frame. Given that its only ever gonna have a handful of
  children there wasn't really a need to optimize that that in the first
  place.
  - `HandOfCards.Cards` now exposes `cardLookup.Values` as an
  `IEnumerable` instead of exposing the card container's children
  directly.
  - `HandOfCard` now exposes `GetCardsInDisplayOrder` which returns a copy
  of all cards in display order. Since it's making a copy I made sure this
  isn't called on any hot code paths.
  - `HandOfCard.Clear` previously didn't clear the `cardLookup`
  dictionary. Didn't cause any issues since we're not re-adding cards to
  the hand anywhere but not good regardless.
  Switched to looping over all cards and calling `RemoveCard` to make sure
  changes to the removal logic can't get overlooked there again.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  maarvin · 2026-04-21 22:54:36 +09:00
  7b0e5ecc13
• Rewrite ranked play card song preview playback logic to hopefully work around framework breakage (#37453)

  Similar idea to
  https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7
  (which was included in https://github.com/ppy/osu/pull/37218).
  
  Probably closes https://github.com/ppy/osu/issues/37420.
  
  I wouldn't be myself if I didn't remark that the WTF/sec on ranked play
  code continues to be quite high as I fix these issues. Like, look at the
  old code: why does `Enabled` becoming false stop the preview track, but
  `CardHovered` becoming false *doesn't*? Even though `shouldBePlaying`
  was explicitly defined as derived from *both flags*? Maybe me changing
  this to be actually consistent incurs a behaviour change, but like... I
  can't tell if it is a bug or not.
  
  Not to mention this nugget:
  
  
  https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/HandOfCards.HandCard.cs#L107
  
  https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs#L47-L50
  
  What is this naming even?

  Bartłomiej Dach · 2026-04-21 22:19:25 +09:00
  71b3d51ed5
• Use placeholder user models in ranked play if online lookups fail (#37455)

  Suboptimal? Sure. But the primary goal is not to crash. Crashing is a
  failure of the game programmer.
  
  Better can be done later.
  
  Remedies/fixes https://github.com/ppy/osu/issues/37421.

  Bartłomiej Dach · 2026-04-21 22:16:45 +09:00
  71356a9455
• Do not cache null values in beatmap lookup cache (#37456)

  RFC.
  
  The reason I'm bringing this up is
  https://github.com/ppy/osu/issues/37383.
  
  In this case, the retrieval of the beatmap failed on a timeout:
  
  ```
  2026-04-19 02:43:10 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 failed with System.Net.WebException: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 timed out after 10 seconds idle (read 0 bytes, retried 0 times)..
  2026-04-19 02:43:10 [verbose]: Failing request osu.Game.Online.API.Requests.GetBeatmapsRequest (System.Net.WebException: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 timed out after 10 seconds idle (read 0 bytes, retried 0 times).)
  ```
  
  ```
  2026-04-19 02:43:10 [error]: Failed to load beatmap 5090069 for playlistItem 0.
  2026-04-19 02:43:10 [verbose]: ⚠️ Failed to load beatmap 5090069 for playlistItem 0.
  ```
  
  This fails at
  
  
  https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs#L167-L171
  
  Just this failing wouldn't cause the game to soft-lock; when I suppress
  the lookup locally, the game continues as normal. *However*, suppressing
  the lookup is not the same as the lookup *failing*, because a failed
  lookup will write a null to the cache, which means that when a beatmap
  download is initiated later in
  
  
  https://github.com/ppy/osu/blob/1b488949e13568c23faa0d88b18c8036f4a7dbc8/osu.Game/Screens/OnlinePlay/Matchmaking/Match/ScreenMatchmaking.cs#L308-L320
  
  it'll just do nothing and the user will be stuck, even though they could
  very well attempt to download the beatmap here if the lookup were to
  succeed on the second go.
  
  To a degree changing the whole cache for this could be viewed as the
  tail wagging the dog, but I think in general caching nulls here seems
  pretty anti-user. From within the client I would generally not expect
  very many complete misses when looking up beatmaps.
  
  Note that this wouldn't soft-lock the match anymore since
  https://github.com/ppy/osu-server-spectator/pull/471. It's just another
  step in making degradation less impactful.

  Bartłomiej Dach · 2026-04-21 22:12:50 +09:00
  553c20397a
• Attempt to improve safety of pushing matchmaking screens (#37452)

  Due to the push of the relevant screens being delayed it's possible that
  the room goes away between the scheduling of the push and the actual
  execution of the push.
  
  This maybe closes https://github.com/ppy/osu/issues/37374 but my hopes
  are not high.
  
  Includes some extra cleanups I noticed along the way.

  Bartłomiej Dach · 2026-04-21 19:11:35 +09:00
  1eee6dc870
• Implement WebSocket server skeleton for external integrations (#37335)

  - Supersedes / closes https://github.com/ppy/osu/pull/18129. Reasons I
  didn't use that PR are hopefully obvious upon comparing diffs but I can
  elaborate if they are not.
  - Single metric included for demonstration purposes.
  - Do not want to talk about further schema design at this time.
  - Specify `OSU_WEBSOCKET_SERVER=1` envvar to enable.
  - Can test consumption with [this five minute html
  job](https://github.com/user-attachments/files/26839923/index.html)
  (works even as a standalone file opened in browser, no CORS bs!)
  - There's a lot of inline comments, go read them. There are many WTFs
  because the .NET frozen websocket API is weird and stanky and reeks of
  the year 2007. The inline comments attempt to explain.

  Bartłomiej Dach · 2026-04-21 18:25:12 +09:00
  9a2846539f
• Fix ranked play chat deselecting when typing shift-numbers (#37450)

  Fixes https://github.com/ppy/osu/issues/37434
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2026-04-21 11:07:11 +02:00
  a7ac628e94
• Disable discord invites for ranked play (#37439)

  Closes #37196

  Zihad · 2026-04-21 08:24:38 +02:00
  b3987741d6
• Hide beatmap download notification in ranked play (#37444)

  Similar implementation to `BundledBeatmapDownloader`. The notification
  should not be cancellable, but there's no easy way to do that right now
  other than hiding the notification altogether.
  
  The beatmap availability status visible on the corner pieces is probably
  a little too small/hides importance, but that will be addressed later to
  make up for this.

  Dan Balasescu · 2026-04-21 08:04:45 +02:00
  4f02594265
• Update resources
  Dean Herbert · 2026-04-21 00:05:56 +09:00
  2026.421.0-lazer 0ecb8926bd
• Fix illegible star rating text colour in ranked play intro animation (#37429)

  Closes https://github.com/ppy/osu/issues/37406.
  
  I almost applied
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  index 318572d28f..76719a7de8 100644
  --- a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  +++ b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  @@ -5,8 +5,10 @@
   using osu.Framework.Allocation;
   using osu.Framework.Audio;
   using osu.Framework.Audio.Sample;
  +using osu.Framework.Extensions.Color4Extensions;
   using osu.Framework.Graphics;
   using osu.Framework.Graphics.Containers;
  +using osu.Framework.Graphics.Effects;
   using osu.Framework.Graphics.Shapes;
   using osu.Framework.Graphics.Sprites;
   using osu.Framework.Graphics.Transforms;
  @@ -134,6 +136,14 @@ private void load(OsuColour colour, AudioManager audio)
                       Anchor = Anchor.BottomLeft,
                       Origin = Anchor.BottomLeft,
                       Colour = colour.ForStarDifficulty(Math.Max(difficulty, 0.1)),
  +                    EdgeEffect = difficulty < OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF
  +                        ? default
  +                        : new EdgeEffectParameters
  +                        {
  +                            Type = EdgeEffectType.Glow,
  +                            Colour = colour.ForStarDifficultyText(difficulty).Opacity((difficulty - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / (10 - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / 2),
  +                            Radius = 4
  +                        },
                       Height = 0
                   });
  
  ```
  
  as a bonus but I'm not that confident in myself.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-20 23:50:25 +09:00
  c148e2056e
• Stop all samples when exiting ranked play results screen early (#37427)

  Intends to close https://github.com/ppy/osu/issues/37408.
  
  I have got to say, the way ranked play apparently re-invents screen
  sub-stacks *again* in a slightly different way to everything else before
  had me *very* confused as to why things I would expect to get called
  aren't getting called.

  Bartłomiej Dach · 2026-04-20 22:32:59 +09:00
  8691004499
• Fix queue screen crashes on mobile (#37425)

  Closes https://github.com/ppy/osu/issues/37345
  
  Aside from
  https://github.com/ppy/osu/commit/9f4b1c8b8dbba68f815af61bf46824cfb25b2d3b,
  this also tweaks the grid sizings on mobile which were the secondary
  cause of the android crashes. I'm bothering because it looked awful even
  with the primary crash fixed.
  
  Only tested on android. I wanted to test visually on iOS but rider
  doesn't want to talk to xcode *or* my iPhone anymore, so I give up.
  
  | before | after |
  | :-: | :-: |
  | <img width="2400" height="1080"
  alt="Screenshot_2026-04-20-12-04-17-44_25a1a32208bbcdc1d450b7aa854bb161"
  src="https://github.com/user-attachments/assets/e9bac850-7256-4a0d-8358-992490e1381d"
  /> | <img width="2400" height="1080"
  alt="Screenshot_2026-04-20-12-07-35-26_25a1a32208bbcdc1d450b7aa854bb161"
  src="https://github.com/user-attachments/assets/a525485e-f2b5-4252-ae50-dc84c29945ec"
  /> |

  Bartłomiej Dach · 2026-04-20 21:14:13 +09:00
  a0be214d03
• Disable sentry during test runs

  Exposed to be running by 48434dd683 which
  caused test failures.
  
  You'd think that the `IsDeployedBuild` check would catch it but it
  doesn't. `IsDeployedBuild` is `AssemblyVersion.Major > 0`, and the
  assembly version is taken from the entry assembly. In tests the entry
  assembly is either resharper or nunit.

  Bartłomiej Dach · 2026-04-20 13:37:53 +02:00
  16bbfbb4e2
• Fix crash when dragging card as discard phase ends (#37419)

  Closes: #37402
  
  Issue was `HandOfCards.CardContainer.Compare` working under the
  assumption that the it would never be called with the same child for
  both entries, which can happen when doing a `BinarySearch` (called in
  `RemoveInternal`).
  This lead to `IndexOf` returning a negative value despite the card being
  present in the container, and the drawable getting disposed but not
  actually removed.
  
  I also included a precautionary `cardContainer.Sort()` call before the
  removal as well, seemed to work without that from testing but better not
  rely on that.
  
  TLDR: card container child sorting was unstable due to poor assumptions

  maarvin · 2026-04-20 10:58:27 +02:00
  11f01113a1
• Remove sentry DSN from repo

  People doing stupid shit submitting stupid errors we don't care about.

  Dean Herbert · 2026-04-20 17:16:41 +09:00
  48434dd683
• Fade out "waiting for a game" sound effect loop (#37415)

  Feedback that this can be annoying when waiting for a match with the
  game in the background for several minutes. Agree with this.

  Dean Herbert · 2026-04-20 09:36:54 +02:00
  6c7487f774
• Unify damage multiplayer formatting (#37366)

  Previously the current stage overlay would not display the decimal part
  of the damage multiplier.
  
  Resolves #37357.

  Krzysztof Gutkowski · 2026-04-20 09:28:38 +02:00
  10543e6b8f
• Fix viewing beatmap details in ranked play not working (#37351)

  https://discord.com/channels/188630481301012481/1440912440224120882/1495066077175222422
  
  Haven't really tested whether this works - dev server is also lacking
  data in general, however relying on the previous example set by quick
  play:
  
  
  https://github.com/ppy/osu/blob/1168c477d95f019aea2b676ef51db4ab6cd7253f/osu.Game/Screens/OnlinePlay/Matchmaking/Match/BeatmapSelect/MatchmakingSelectPanel.CardContentBeatmap.cs#L418-L421

  Dan Balasescu · 2026-04-20 09:01:03 +02:00
  5995ecf5de
• Set user activity during ranked play matches (#37342)

  Best that can be done for the time being.

  Dan Balasescu · 2026-04-20 08:54:56 +02:00
  807b21ed97
• Disallow external beatmap changes during ranked play (#37358)

  Fixes https://osu.ppy.sh/community/forums/topics/2198450?n=3

  Dan Balasescu · 2026-04-20 12:29:03 +09:00
  b1ef351f83
• Turn on ranked play
  Dean Herbert · 2026-04-18 19:52:52 +09:00
  2026.418.0-lazer 1168c477d9
• Avoid recomputing full path vertices in SliderPath when possible (#36285)

  In some cases `SliderPath.GetPathToProgress` used to compute the whole
  path when it can be not needed since it can be already stored inside
  `calculatedPath` list.
  Also some of these use cases will no longer require additional array
  wheen only readonly access is all we need.

  Andrei Zavatski · 2026-04-17 21:35:27 +09:00
  b36f8f9c47
• Fix failing test
  Dan Balasescu · 2026-04-17 17:06:24 +09:00
  9bea31986c
• Limit maximum password length for multiplayer lobbies to conformant value (#37329)

  See https://github.com/ppy/osu/issues/37324.

  Dean Herbert · 2026-04-17 15:33:49 +09:00
  2026.417.0-tachyon cb843b1a2b
• Avoid moving auth files during storage migration
  Dan Balasescu · 2026-04-17 15:00:37 +09:00
  964d3fbdbc
• Reduce log spam from spectator client when playing offline (#37316)

  Noticed in passing when doing something else.

  Bartłomiej Dach · 2026-04-16 22:17:46 +09:00
  9ac1ad2843
• Update framework (#37315)
  Dean Herbert · 2026-04-16 14:11:24 +02:00
  c2ed2f7d65
• Add note on AI usage in contributions
  Dean Herbert · 2026-04-16 18:24:14 +09:00
  96513ceb3b