1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 00:52:59 +08:00
Commit Graph

8166 Commits

Author SHA1 Message Date
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling 2022-09-12 20:09:21 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6 Fix flinging a notification not correctly running Close 2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087 Don't play fling animation when activating a notification 2022-09-12 18:57:18 +09:00
Dean Herbert
58c1ea0321 Fix potential crash when opening changelog overlay if entry has no URL 2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126 Don't trigger fling animation when Close is triggered by non-user action 2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713 Use padding instead of FillFlow.Spacing to avoid artifact during animation 2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571 Make bounding box shrink faster to allow for rapid flinging 2022-09-12 16:39:46 +09:00
Dean Herbert
931049aec1 Merge branch 'master' into notification-dismiss 2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9 Fix being able to drag after already closing a notification 2022-09-12 16:25:32 +09:00
Dean Herbert
8e6b2796eb Merge branch 'master' into notification-fling 2022-09-12 16:19:36 +09:00
Dean Herbert
2476cf8fb3 Adjust movement to look less sudden when snapping back to Y=0 2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300 Fix dragged state not being exposed correctly 2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7 Hide notification read light when in a toast state
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
60b0b909a5 Move update icon to background to avoid colour collission with progress spinner 2022-09-12 14:58:46 +09:00
Dean Herbert
9ef23c79ce Disallow forwarding during a drag operation 2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90 Ensure drag position is reset when transferred to tray 2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e Disallow flinging when not in toast state 2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f Add basic fling-to-dismiss support 2022-09-11 21:32:22 +09:00
Dean Herbert
a9094c6b03 Add test coverage of clicking close button to dismiss 2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b Allow dismissing notifications without performing action using middle / right click 2022-09-10 15:10:37 +09:00
andy840119
1398a7e11e Property should accept the nullable state. 2022-09-10 10:46:40 +08:00
Salman Ahmed
5e4e3dfc2c Fix markdown container not rendering certain text correctly 2022-09-10 02:55:20 +03:00
Dean Herbert
6e52dbb266 Update IsDisplayingToasts to check the flow count directly 2022-09-06 17:30:24 +09:00
Dean Herbert
9e3228aa65 Fix completion notification not being posted if completion occurs during NotificationOverlay load 2022-09-06 04:07:49 +09:00
Dean Herbert
510972e3ad Avoid reference counting by using height calculation for IsPresent instead
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.

Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521 Remove necessity of AlwaysPresent for ProgressUpdate completion posting 2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80 Centralise ability to fetch all toast tray notifications (including animating ones) 2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988 Fix completion notifications not always showing as toasts 2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0 Set all progress notifications to non-important 2022-09-05 18:29:35 +09:00
Dean Herbert
7eaa4c5ccd Update new usages of Remove / RemoveInternal 2022-09-01 23:05:34 +09:00
Dean Herbert
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray 2022-08-31 16:07:11 +09:00
Dan Balasescu
ccc08b816c
Merge pull request #20030 from peppy/notification-design-update
Update notification overlay design
2022-08-31 16:06:59 +09:00
Dean Herbert
8b9ccc66b7 Update ProgressNotification font spec to match other notifications 2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032 Adjust dismiss button background colour to avoid conflict with background 2022-08-31 12:48:30 +09:00
Dean Herbert
7c72c6b43f Fix unread count potentially missing notifications in a transforming state 2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917 Mark toasts as read when closing the overlay for added safety
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
9eb615f942 Fix remaining test failures by strengthening PlayerLoader tests
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686 Update remaining test expectations with new behaviour 2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9 Remove notification blocking behaviour of first run setup 2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f Improve forwarding flow to not use piling delegates 2022-08-31 00:40:53 +09:00
Dean Herbert
224ab29ef4 Don't dismiss toasts while hovered (and adjust timings slightly) 2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976 Fix notification completion events not being run when overlay not visible 2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0 Play notification appear sample immediately 2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c Reduce notification post delay now that it's less important 2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a Add toast notification tray 2022-08-30 21:13:43 +09:00