Bartłomiej Dach
cee66c51d6
Merge branch 'master' into fix-timeline-context-menu
2022-05-29 16:06:05 +02:00
Bartłomiej Dach
18f75d8c58
Remove redundant initialiser
2022-05-29 16:06:01 +02:00
Dean Herbert
c078c06902
Fix unsafe config fetching
2022-05-29 22:55:53 +09:00
Dean Herbert
186999c4eb
Merge pull request #18473 from peppy/fix-skin-changed-disposal
...
Fix potential `ObjectDisposedException` on realm notification in `SkinSection`
2022-05-29 22:43:47 +09:00
Dean Herbert
70c8a43961
Update framework
2022-05-29 21:31:20 +09:00
Dean Herbert
7c97719db1
Move Schedule to only drawable pieces
2022-05-29 21:28:09 +09:00
Salman Ahmed
9cc5df9b13
Fix context menu no longer open on hitobjects in timeline
2022-05-29 15:23:32 +03:00
Salman Ahmed
12d5b355e4
Add failing test coverage
2022-05-29 15:23:32 +03:00
Dean Herbert
c7570fbce5
Fix potential ObjectDisposedException on realm notification in SkinSection
2022-05-29 15:15:03 +09:00
Dean Herbert
20701edc23
Merge pull request #18459 from bdach/unobserved/convert-slider
...
Fix unobserved exceptions in multiple tests due to constructing `GameplayState` instances with unconverted beatmaps
2022-05-29 00:54:11 +09:00
Salman Ahmed
02baf9a97a
Fix timeline objects disappearing prematurely on wide-screens
2022-05-28 17:45:38 +03:00
Salman Ahmed
0349d92f8b
Add failing test case
2022-05-28 17:45:00 +03:00
Bartłomiej Dach
a8e1c5ba87
Fix remaining cases of incorrect GameplayState construction in tests
...
Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.
2022-05-28 15:23:29 +02:00
Bartłomiej Dach
dcf3d76954
Fix unobserved exceptions due to using unconverted beatmap
...
`TestSceneBeatmapSkinFallbacks` was locally caching a `GameplayState`
instance to fulfill dependencies of a
`SkinnableTargetComponentsContainer`. However, it was doing so using
`new TestBeatmap()`, which is a raw decoded beatmap that hasn't been
converted to any ruleset yet, which was causing failures in
`BeatmapDifficultyCache.GetTimedDifficultyAttributesAsync()` as that
method is expecting to receive a post-conversion, ready-for-gameplay
beatmap.
Resolve by proxying forward dependency instances from the
already-known-to-be-working `actualComponentsContainer`.
2022-05-28 15:23:29 +02:00
Bartłomiej Dach
1641918c51
Revert "Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes"
...
This reverts commit 19b655d75b
2022-05-28 15:23:28 +02:00
Dean Herbert
10d0238e39
Merge pull request #18457 from bdach/unobserved/not-implemented
...
Fix unobserved exceptions in `TestSceneStatisticsPanel` due to unimplemented beatmap converter
2022-05-28 22:22:25 +09:00
Bartłomiej Dach
e18fec3d89
Fix unobserved exceptions due to unimplemented beatmap converter
...
`TestSceneStatisticsPanel` intends to check the operation of statistics
panels using dummy ruleset classes. However, `StatisticsPanel` relies on
being able to retrieve the playable beatmap, which requires a converter.
One was not provided by the dummy rulesets, therefore the retrieval
would fail with an unobserved exception.
To fix, add a barebones converter implementation that is enough for the
test to pass.
2022-05-28 14:10:57 +02:00
sw1tchbl4d3
ede3ab9dc0
Add OnFocus handler to CurrentlyPlayingDisplay
2022-05-28 12:04:44 +02:00
Dean Herbert
62266c72ea
Merge pull request #18448 from frenzibyte/editor-metronome-rate
...
Fix metronome speed not adjusted on different playback rates
2022-05-28 10:58:51 +09:00
Dean Herbert
4f2910cdb1
Merge pull request #18445 from frenzibyte/editor-background-colour
...
Darken background colour in "setup" and "verify" screens
2022-05-28 10:56:22 +09:00
Dean Herbert
3aa7e3141e
Merge pull request #18443 from frenzibyte/fix-beatmap-badge-colouring
...
Fix beatmap badge colours not updated inline with recent changes
2022-05-28 10:55:07 +09:00
Dean Herbert
68684f5fe7
Merge pull request #18446 from frenzibyte/editor-row-attribute-background
...
Update row attribute background colour to fit screen
2022-05-28 10:53:50 +09:00
Dean Herbert
6ed21973b0
Merge pull request #18447 from frenzibyte/editor-verify-settings-width
...
Fix editor verify settings looking cramped up due to small width
2022-05-28 10:51:52 +09:00
Dean Herbert
93a8092da6
Increase usable width slightly further
2022-05-28 10:51:39 +09:00
Salman Ahmed
2fac710d4b
Add step for adjusting editor clock rate in test scene
2022-05-28 04:10:39 +03:00
Salman Ahmed
e12d188dad
Fix metronome speed not adjusted on different playback rates
2022-05-28 04:10:39 +03:00
Salman Ahmed
d12e4928e6
Increase editor verify settings width to give more breathing space
2022-05-28 03:09:04 +03:00
Salman Ahmed
e71d907164
Update row attribute background colour to fit screen
2022-05-28 02:20:04 +03:00
Salman Ahmed
eec9248cde
Darken background colour in "setup" and "verify" screens
2022-05-28 02:10:18 +03:00
Salman Ahmed
aee3e2a4ed
Add shadow effect to editor's bottom bar
2022-05-28 01:58:55 +03:00
Salman Ahmed
06832a4baf
Fix beatmap badge colours not updated inline with recent changes
2022-05-28 01:05:43 +03:00
sw1tchbl4d3
cd84200ad9
Add HoldFocus and ReleaseFocusOnCommit attributes to searchbar
2022-05-27 21:23:37 +02:00
Jai Sharma
c5845f307a
Code quality
2022-05-27 20:12:00 +01:00
Dean Herbert
5eb16ff46c
Update framework
2022-05-28 04:02:35 +09:00
Dean Herbert
254039b8fe
Address remaining code quality concerns
2022-05-28 04:01:51 +09:00
Dean Herbert
ca9b2648a3
Merge pull request #18421 from peppy/reconnect-on-server-shutdown-exception
...
Handle server shutdown messages in room creation and spectator initialisation
2022-05-28 03:52:24 +09:00
Jai Sharma
e950c8c1d0
Refactor ChannelList to use new ChannelGroup class for each type of channel
2022-05-27 19:46:53 +01:00
Dean Herbert
03d9ca0d8d
Merge pull request #18437 from peppy/fa-playlist-category
...
Add featured artist playlist category
2022-05-28 01:28:21 +09:00
Dean Herbert
f708b98058
Merge pull request #18438 from Susko3/use-normalised-precise-scrolling
...
Adjust `ScrollDelta` usages to account for normalised `IsPrecise` values
2022-05-28 01:10:10 +09:00
Jai Sharma
320b6ca631
Display Announce type channels separately in new chat overlay
2022-05-27 16:18:22 +01:00
Bartłomiej Dach
e511c1dfff
Merge branch 'master' into use-normalised-precise-scrolling
2022-05-27 16:55:13 +02:00
Bartłomiej Dach
aadcf25129
Merge pull request #18441 from peppy/update-resources
...
Update resources
2022-05-27 16:52:50 +02:00
Bartłomiej Dach
a94432f3bd
Fix drawable room border colour not matching badge
2022-05-27 16:40:15 +02:00
sw1tchbl4d3
e2951d70d1
Address code style issues
2022-05-27 16:38:54 +02:00
Dean Herbert
6960bec52d
Update resources
2022-05-27 23:29:48 +09:00
Dean Herbert
d9ecf69d20
Update framework
2022-05-27 23:29:39 +09:00
Dean Herbert
046867f5f4
Merge pull request #18436 from peppy/fix-unsafe-mutation
...
Fix potential crash from unsafe drawable mutation in scoreboard update code
2022-05-27 21:00:15 +09:00
Dean Herbert
2f57849bcb
Fix unexpected assertion failure
2022-05-27 20:59:00 +09:00
Dean Herbert
883c6f1eb3
Update colour of spotlights playlist to match new specs
2022-05-27 20:26:35 +09:00
Dean Herbert
ef47b380c6
Add featured artist playlist category
2022-05-27 20:18:46 +09:00
