619 Commits

• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Expose no-op constructors as protected
  Dean Herbert · 2024-10-18 13:30:29 +09:00
  8193038986
• Fix mouseX legacy replay parsing for high key counts in mania
  clayton · 2024-08-11 09:45:43 -07:00
  9620c58751
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Merge branch 'master' into negative-frame-handling
  Dan Balasescu · 2024-05-29 13:14:59 +09:00
  655b0f5343
• Do not attempt to match score by equality of hash if it's empty

  Closes https://github.com/ppy/osu/issues/28216.
  
  The affected user's database contained six sentakki scores with an empty
  hash. When an online score is being imported, an online model (which
  does not have a hash) will be transmogrified into a `ScoreInfo` with
  an empty hash, which would end up accidentally matching those scores
  and basically breaking everything at that point.
  
  To fix, avoid attempting to match anything on empty hash. This does not
  break online score matching because for those cases the actual online ID
  of the score will be used.

  Bartłomiej Dach · 2024-05-20 15:05:41 +02:00
  ed498f6eed
• Use hash rather than online ID as primary lookup key when presenting score

  Something I ran into when investigating
  https://github.com/ppy/osu/issues/28169.
  
  If there are two scores with the same online ID available in the
  database - for instance, one being recorded locally, and one recorded by
  spectator server, of one single play - the lookup code would use online
  ID first to find the score and pick any first one that matched. This
  could lead to the wrong replay being refetched and presented / exported.
  
  (In the case of the aforementioned issue, I was confused as to whether
  after restarting spectator server midway through a play and importing
  the replay saved by spectator server after the restart, I was seeing a
  complete replay with no dropped frames, even though there was nothing in
  the code that prevented the frame drop. It turns out that I was getting
  presented the locally recorded replay instead all along.)
  
  Instead, jiggle the fallback preference to use hash first.

  Bartłomiej Dach · 2024-05-14 11:16:50 +02:00
  03a279a48d
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Use score.User.OnlineID instead of score.UserID

  You'd hope that they'd be the same thing, but
  post-https://github.com/ppy/osu-server-spectator/pull/230 it turns out
  that cannot be guaranteed, so just attempt to use `User` in the encoder
  consistently everywhere...

  Bartłomiej Dach · 2024-05-06 16:29:03 +02:00
  9c6968c13a
• Look up users by ID if available when importing scores
  Bartłomiej Dach · 2024-05-06 13:24:34 +02:00
  abfb2c00bc
• Decode user ID from score if available
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  554ead0d9d
• Encode user ID to replays
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  4d9ccdc3b2
• Do not perform username lookups for scores without an online ID
  Bartłomiej Dach · 2024-05-03 13:59:36 +02:00
  afb491dff0
• Merge pull request #28058 from frenzibyte/export-score-rank

  Preserve score rank on lazer scores during encode/decode

  Bartłomiej Dach · 2024-05-02 08:44:10 +02:00
  555305bf7f
• Preserve score rank on encode/decode
  Salman Ahmed · 2024-05-01 23:31:23 +03:00
  0106f1fe3e
• Disable inconsistent naming in some fields of ScoreRank
  Salman Ahmed · 2024-05-01 17:22:10 +03:00
  97fc2a5473
• Return Task.CompletedTask instead of null
  Joseph Madamba · 2024-04-22 11:22:39 -07:00
  35eddf35c5
• Improve xmldoc wording
  Joseph Madamba · 2024-04-22 11:17:27 -07:00
  a59bf6d373
• Add xmldoc to GetScore() and Export() and remove xmldoc from private getDatabasedScoreInfo()
  Joseph Madamba · 2024-04-17 21:52:36 -07:00
  d08b1e5ae7
• Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)
  Bartłomiej Dach · 2024-04-17 09:08:15 +02:00
  2f1a4cdaa4
• Add ScoreInfo.TotalScoreWithoutMods
  Bartłomiej Dach · 2024-04-17 08:51:53 +02:00
  a386068ed3
• Make getDatabasedScoreInfo() private and move to GetScore() and Export()
  Joseph Madamba · 2024-04-15 20:48:51 -07:00
  514e316b49
• Fix replay export not working correctly from online leaderboards
  Joseph Madamba · 2024-04-14 16:22:58 -07:00
  ed8b596325
• Enable NRT to ScoreManager
  Joseph Madamba · 2024-04-14 15:53:29 -07:00
  f282152f99
• Bump legacy score version to recalculate all scores
  Bartłomiej Dach · 2024-03-25 19:27:38 +01:00
  73926592b9
• Rewrite handling of legacy replay frame quirks to match stable closer
  Bartłomiej Dach · 2024-03-21 21:11:29 +01:00
  990a07af0e
• Merge branch 'master' into negative-frame-handling
  Bartłomiej Dach · 2024-03-21 16:45:35 +01:00
  c47463ee0e
• Compare against MaxCombo instead
  Dan Balasescu · 2024-03-19 17:46:18 +09:00
  f6069d8d93
• Remove added property, use local decoding instead
  Dan Balasescu · 2024-03-19 17:44:37 +09:00
  6e33509417
• Fix incorrectly encoded score IsPerfect value
  Dan Balasescu · 2024-03-19 17:20:59 +09:00
  af713a7869
• Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good

  Fix osu! standardised score estimation algorithm violating basic invariants

  Dan Balasescu · 2024-03-07 17:05:32 +09:00
  e0fe33a7a7
• Bump score version
  Bartłomiej Dach · 2024-03-06 21:30:09 +01:00
  3121cf81e6
• Merge pull request #27489 from bdach/fix-catch-pp-mismatch

  Fix catch pp calculator not matching live with respect to miss handling

  Dan Balasescu · 2024-03-06 19:39:20 +09:00
  d8003ab8e8
• Use new ToDictionary() overload without delegates
  Berkan Diler · 2024-03-05 10:27:12 +01:00
  6fabbe2616
• Fix incorrect implementation of GetCountMiss() for catch
  Bartłomiej Dach · 2024-03-04 11:49:12 +01:00
  dcd6b02809
• Bump score version
  Bartłomiej Dach · 2024-02-24 13:20:42 +01:00
  4bc92a263f
• Remove placeholder classes and inline everything
  Salman Ahmed · 2024-02-12 21:30:10 +03:00
  4f0f07d55a
• Combine other cases of displaying dash in scores PP
  Salman Ahmed · 2024-02-12 12:29:33 +03:00
  2ae616a88e
• Use localised string
  Bartłomiej Dach · 2024-02-07 13:38:05 +01:00
  706a16677c
• Remove unnecessary #nullable disable
  Bartłomiej Dach · 2024-02-07 13:35:12 +01:00
  9a3c947319
• Update design of "unprocessed PP" placeholder to match web
  Salman Ahmed · 2024-02-05 23:29:24 +03:00
  b78c6ed673
• Support displaying "unranked PP" placeholder
  Salman Ahmed · 2024-02-05 23:29:24 +03:00
  6b7ffc240b
• Add "ranked" attribute to scores
  Salman Ahmed · 2024-02-05 23:29:24 +03:00
  4be4ed7ab2
• Make LegacyScoreDecoder.PopulateMaximumStatistics() public

  For `osu-tools` consumption.

  Bartłomiej Dach · 2024-01-29 21:42:38 +01:00
  6888cda02c
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Move transferal of LegacyTotalScore back to original spot

  This subtle detail was messing with server-side score import flows.
  Server-side, legacy total score will *already* be in `LegacyTotalScore`
  from the start, and `TotalScore` will be zero until recomputed via
  `StandardisedScoreMigrationTools.UpdateFromLegacy()` - so in that
  context, attempting to move it across is incorrect.

  Bartłomiej Dach · 2024-01-23 12:42:57 +01:00
  cb87d6ce50
• Remove redundant assertion

  It does look pretty dumb to be checking if something is `null` *after
  calling an instance method on it*...

  Bartłomiej Dach · 2024-01-22 22:01:03 +01:00
  4d253ebf3c
• Remove legacy computation of accuracy & ranks
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  cdd6e71d01
• Unify legacy total score / accuracy / rank recomputation flows
  Bartłomiej Dach · 2024-01-22 20:52:51 +01:00
  db4849442e