614 Commits

• Add failing test case
  Bartłomiej Dach · 2025-03-18 12:02:12 +01:00
  85076081d2
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Add failing test case
  Bartłomiej Dach · 2025-03-03 09:32:27 +01:00
  0a50fb1dfa
• Add failing encoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 11:10:33 +01:00
  e48d36ad1e
• Add failing decoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 10:56:28 +01:00
  76bf03b05d
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Add failing test case
  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  ecf64dfc57
• Add failing test case
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0c02369bdc
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Merge branch 'master' into beatmap-info-purge
  Bartłomiej Dach · 2024-11-26 10:21:16 +01:00
  cf905d0f5c
• Fix incorrect unit test
  Bartłomiej Dach · 2024-11-25 12:53:40 +01:00
  c8847e8da8
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Add test case covering stability of compatibility export operation

  This is important as the format will be used more when lazer beatmap
  submission comes online, and its stability is a useful property for
  that.
  
  Included archive contains an `.osu` with a few fractional-millisecond
  timing points and objects, as well as a multi-segment-type slider. That
  should cover the range of all possible modifications that the
  compatibility exporter currently performs.

  Bartłomiej Dach · 2024-11-20 13:26:54 +01:00
  dfa32302ac
• Adjust test to have better assertions
  Bartłomiej Dach · 2024-11-14 14:24:11 +01:00
  8df7a6f2f3
• Create LegacyBeatmapExporterTest
  OliBomby · 2024-11-13 14:09:19 +01:00
  f15b6b1d71
• Fix LegacyBeatmapEncoderTest swapping expected/actual values around

  Was making test output look confusing.

  Bartłomiej Dach · 2024-11-05 11:51:59 +01:00
  0e8dce5527
• Remove more no-longer-required checks

  The scenario that remaining guard was trying to protect against is
  obviated by and no longer possible after
  776fabd77c.

  Bartłomiej Dach · 2024-10-30 08:44:23 +01:00
  2b0fd3558f
• Remove no longer applicable test

  After dd06dd0e699311494412e36bc3f37bb055a01477 the behaviour set up on
  the mock in the test in question is no longer realistic. Online
  metadata lookups will no longer fall back to online ID or filename.

  Bartłomiej Dach · 2024-10-30 08:17:54 +01:00
  2c2f307a63
• Adjust test to match desired reality
  Bartłomiej Dach · 2024-10-30 07:35:00 +01:00
  40c2d4e942
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-09-15 04:53:35 +09:00
  58fe502af4
• Fix another test

  The last two PRs didn't interact well together.

  Dan Balasescu · 2024-08-13 17:18:11 +09:00
  58354e3e68
• Update mania replay decode test to include 18K keypress
  clayton · 2024-08-11 09:45:42 -07:00
  2233602184
• Add failing test coverage showing coordinate truncation
  Dean Herbert · 2024-08-09 16:34:39 +09:00
  2114f092c7
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Fix slider tail volume not saving

  Closes https://github.com/ppy/osu/issues/28587.
  
  As outlined in the issue thread, the tail volume wasn't saving because
  it wasn't actually attached to a hitobject properly, and as such the
  `LegacyBeatmapEncoder` logic, which is based on hitobjects, did not
  pick them up on save.
  
  To fix that, switch to using `NodeSamples` for objects that are
  `IHasRepeats`. That has one added complication in that having it work
  properly requires changes to the decode side too. That is because the
  intent is to allow the user to change the sample settings for each node
  (which are specified via `NodeSamples`), as well as "the rest of the
  object", which generally means ticks or auxiliary samples like
  `sliderslide` (which are specified by `Samples`).
  
  However, up until now, `Samples` always queried the control point
  which was _active at the end time of the slider_. This obviously can't
  work anymore when converting `NodeSamples` to legacy control points,
  because the last node's sample is _also_ at the end time of the slider.
  To bypass that, add extra sample points after each node (just out of
  reach of the 5ms leniency), which are supposed to control volume of
  ticks and/or slides.
  
  Upon testing, this *sort of* has the intended effect in stable, with
  the exception of `sliderslide`, which seems to either respect or _not_
  respect the relevant volume spec dependent on... not sure what, and not
  sure I want to be debugging that. It might be frame alignment, or it
  might be the phase of the moon.

  Bartłomiej Dach · 2024-06-26 15:52:16 +02:00
  fff27e619d
• Move CountdownOffset out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  dd50d6fa6e
• Move Countdown out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  d373f752d6
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• Move GridSize out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  6685c5ab74
• Move DistanceSpacing out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:14:58 +02:00
  3634307d7c
• Move SamplesMatchPlaybackRate out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:32:23 +02:00
  c216283bf4
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5
• Move WidescreenStoryboard out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:23:53 +02:00
  1ab86ebd24
• Move LetterboxInBreaks out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:18:44 +02:00
  a6b7600bf2
• Move SpecialStyle out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:12:30 +02:00
  011c2e3651
• Move StackLeniency out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:33 +02:00
  0a4560a03e
• Move AudioLeadIn out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:28 +02:00
  4339e2dc4a
• Merge branch 'master' into negative-frame-handling
  Dan Balasescu · 2024-05-29 13:14:59 +09:00
  655b0f5343
• Add whitespace to appease R#
  Dan Balasescu · 2024-05-23 00:21:19 +09:00
  0d13848421
• Added tests for difficulty clamping
  Aurelian · 2024-05-22 13:26:00 +02:00
  f3cae73e2e
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Fix test failure
  Bartłomiej Dach · 2024-05-08 09:45:52 +02:00
  7551cf01d1
• Decode user ID from score if available
  Bartłomiej Dach · 2024-05-06 12:28:13 +02:00
  554ead0d9d
• Fix test failure
  Bartłomiej Dach · 2024-05-02 08:02:55 +02:00
  1eac34667d
• Add failing test case
  Salman Ahmed · 2024-05-01 23:00:24 +03:00
  eb45a406e1
• Add testing for actual presence of video after encode-decode
  Dean Herbert · 2024-04-30 00:50:40 +08:00
  19897c4c07
• Preserve storyboard events when saving a beatmap in the editor

  Until we have full encoding support for storyboards, this stop-gap
  measure ensures that storyboards don't just disappear from existence.

  Dean Herbert · 2024-04-30 00:01:56 +08:00
  fd3f4a9e7b
• Export and import TotalScoreWithoutMods to replays (or recalculate if it missing)
  Bartłomiej Dach · 2024-04-17 09:08:15 +02:00
  2f1a4cdaa4
• Add failing tests
  Bartłomiej Dach · 2024-03-21 20:57:04 +01:00
  5f7028b574
• Merge branch 'master' into negative-frame-handling
  Bartłomiej Dach · 2024-03-21 16:45:35 +01:00
  c47463ee0e